From 744f4b626c245d4c56c91c0f5244a568886492de Mon Sep 17 00:00:00 2001
From: Paul Licameli <paul.licameli@audacityteam.org>
Date: Thu, 26 Dec 2019 15:15:09 -0500
Subject: [PATCH] Fix unreported bug in AudioUnit effects...

... When locale is not English (and translation is complete enough, as in
French) then the switching from Generic to Full interface in Options... did not
work.

(Locales lacking translations of the strings "Full" and "Generic" didn't have
this problem.)

(AudioUnit effects still don't implement a "Basic" interface distinct from
"Generic" regardless of locale.  That's another matter.)
---
 src/effects/audiounits/AudioUnitEffect.cpp | 4 ----
 src/effects/audiounits/AudioUnitEffect.h   | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/effects/audiounits/AudioUnitEffect.cpp b/src/effects/audiounits/AudioUnitEffect.cpp
index 81f1bf05e..ade26d7da 100644
--- a/src/effects/audiounits/AudioUnitEffect.cpp
+++ b/src/effects/audiounits/AudioUnitEffect.cpp
@@ -1049,8 +1049,6 @@ bool AudioUnitEffect::SetHost(EffectHostInterface *host)
       mHost->GetSharedConfig(wxT("Options"), wxT("UseLatency"), mUseLatency, true);
       mHost->GetSharedConfig(wxT("Options"), wxT("UIType"), mUIType, wxT("Full"));
 
-      mUIType = wxGetTranslation(mUIType);
-
       bool haveDefaults;
       mHost->GetPrivateConfig(mHost->GetFactoryDefaultsGroup(), wxT("Initialized"), haveDefaults, false);
       if (!haveDefaults)
@@ -1868,8 +1866,6 @@ void AudioUnitEffect::ShowOptions()
       // Reinitialize configuration settings
       mHost->GetSharedConfig(wxT("Options"), wxT("UseLatency"), mUseLatency, true);
       mHost->GetSharedConfig(wxT("Options"), wxT("UIType"), mUIType, wxT("Full"));
-
-      mUIType = wxGetTranslation(mUIType);
    }
 }
 
diff --git a/src/effects/audiounits/AudioUnitEffect.h b/src/effects/audiounits/AudioUnitEffect.h
index eb0d6cdc4..115d73753 100644
--- a/src/effects/audiounits/AudioUnitEffect.h
+++ b/src/effects/audiounits/AudioUnitEffect.h
@@ -200,7 +200,7 @@ private:
    EffectUIHostInterface *mUIHost;
    wxWindow *mParent;
    wxDialog *mDialog;
-   wxString mUIType;
+   wxString mUIType; // NOT translated, "Full", "Generic", or "Basic"
    bool mIsGraphical;
 
    AudioUnitEffect *mMaster;     // non-NULL if a slave