Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-30 23:49:28 +02:00
Code Issues Releases Wiki Activity

So we prove that MissingFlags was always reassigned zero...

Browse Source 
... so remove this piece of confused logic that did nothing
This commit is contained in:
Paul Licameli 2019-06-09 02:09:48 -04:00
parent 94d9593df8
commit 6c6d0b869e
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Menus.cpp
View File

@ -947,19 +947,9 @@ bool MenuManager::TryToMakeActionAllowed(
if( (flagsRqd & NoAutoSelect).any() )
return false;
// Why is action still not allowed?
// 0's wherever a required flag is missing (or is don't care)
MissingFlags = (flags & ~flagsRqd) & flagsRqd;
// IF selecting all audio won't do any good, THEN return with failure.
if( (flags & WaveTracksExistFlag).none() )
return false;
// returns if mask wants a zero in some flag and that's not present.
// logic seems a bit peculiar and worth revisiting.
if( (MissingFlags &
~( TimeSelectedFlag | WaveTracksSelectedFlag )
).any() )
return false;
// This was 'DoSelectSomething()'.
// This made autoselect more confusing.