From 6c6d0b869ee8be591a7d87c06e7e1aae81334734 Mon Sep 17 00:00:00 2001
From: Paul Licameli <paul.licameli@audacityteam.org>
Date: Sun, 9 Jun 2019 02:09:48 -0400
Subject: [PATCH] So we prove that MissingFlags was always reassigned zero...

... so remove this piece of confused logic that did nothing
---
 src/Menus.cpp | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/Menus.cpp b/src/Menus.cpp
index 51cec1825..92dd43a44 100644
--- a/src/Menus.cpp
+++ b/src/Menus.cpp
@@ -947,19 +947,9 @@ bool MenuManager::TryToMakeActionAllowed(
    if( (flagsRqd & NoAutoSelect).any() )
       return false;
 
-   // Why is action still not allowed?
-   // 0's wherever a required flag is missing (or is don't care)
-   MissingFlags = (flags & ~flagsRqd) & flagsRqd;
-
    // IF selecting all audio won't do any good, THEN return with failure.
    if( (flags & WaveTracksExistFlag).none() )
       return false;
-   // returns if mask wants a zero in some flag and that's not present.
-   // logic seems a bit peculiar and worth revisiting.
-   if( (MissingFlags &
-        ~( TimeSelectedFlag | WaveTracksSelectedFlag )
-       ).any() )
-      return false;
 
    // This was 'DoSelectSomething()'.  
    // This made autoselect more confusing.