fixed initialization order warnings

src/toolbars/SelectionBar.cpp

@@ -125,13 +125,13 @@ END_EVENT_TABLE()
 
 SelectionBar::SelectionBar()
 : ToolBar(SelectionBarID, _("Selection"), wxT("Selection")),
-  mListener(NULL), mRate(0.0), 
+  mListener(NULL), mRate(0.0),
   mStart(0.0), mEnd(0.0), mLength(0.0), mCenter(0.0), mAudio(0.0),
-  mStartTime(NULL), mEndTime(NULL), mLengthTime(NULL), mCenterTime(NULL), 
-  mAudioTime(NULL),
-  mChoice(NULL),
   mDrive1( StartTimeID), mDrive2( EndTimeID ),
-  mSelectionMode(0)
+  mSelectionMode(0),
+  mStartTime(NULL), mCenterTime(NULL), mLengthTime(NULL), mEndTime(NULL),
+  mAudioTime(NULL),
+  mChoice(NULL)
 {
    // Make sure we have a valid rate as the NumericTextCtrl()s
    // created in Populate()

src/tracks/labeltrack/ui/LabelGlyphHandle.cpp

@@ -26,9 +26,9 @@ Paul Licameli split from TrackPanel.cpp
 LabelGlyphHandle::LabelGlyphHandle
 (const std::shared_ptr<LabelTrack> &pLT,
  const wxRect &rect, const LabelTrackHit &hit)
-   : mpLT{ pLT }
+   : mHit{ hit }
+   , mpLT{ pLT }
    , mRect{ rect }
-   , mHit{ hit }
 {
 }
 

src/tracks/playabletrack/notetrack/ui/NoteTrackVZoomHandle.cpp

@@ -53,8 +53,7 @@ namespace
 
 NoteTrackVZoomHandle::NoteTrackVZoomHandle
 (const std::shared_ptr<NoteTrack> &pTrack, const wxRect &rect, int y)
-   : mZoomStart(y), mZoomEnd(y), mRect(rect)
-   , mpTrack{ pTrack }
+   : mpTrack{ pTrack } , mZoomStart(y), mZoomEnd(y), mRect(rect)
 {
 }
 

src/tracks/playabletrack/wavetrack/ui/CutlineHandle.h

@@ -66,11 +66,11 @@ public:
    bool StopsOnKeystroke() override { return true; }
 
 private:
+   std::shared_ptr<WaveTrack> mpTrack{};
    enum Operation { Merge, Expand, Remove };
    Operation mOperation{ Merge };
    double mStartTime{}, mEndTime{};
    WaveTrackLocation mLocation {};
-   std::shared_ptr<WaveTrack> mpTrack{};
 };
 
 #endif

src/tracks/playabletrack/wavetrack/ui/WaveTrackVZoomHandle.cpp

@@ -49,8 +49,7 @@ bool IsDragZooming(int zoomStart, int zoomEnd)
 
 WaveTrackVZoomHandle::WaveTrackVZoomHandle
 (const std::shared_ptr<WaveTrack> &pTrack, const wxRect &rect, int y)
-   : mZoomStart(y), mZoomEnd(y), mRect(rect)
-   , mpTrack{ pTrack }
+   : mpTrack{ pTrack } , mZoomStart(y), mZoomEnd(y), mRect(rect)
 {
 }
 

src/tracks/ui/Scrubbing.cpp

@@ -183,7 +183,8 @@ void Scrubber::ScrubPoller::Notify()
 }
 
 Scrubber::Scrubber(AudacityProject *project)
-   : mScrubToken(-1)
+   : mInOneShotMode( false )
+   , mScrubToken(-1)
    , mPaused(true)
    , mScrubSpeedDisplayCountdown(0)
    , mScrubStartPosition(-1)
@@ -195,7 +196,6 @@ Scrubber::Scrubber(AudacityProject *project)
    , mProject(project)
    , mPoller { std::make_unique<ScrubPoller>(*this) }
    , mOptions {}
-   , mInOneShotMode( false )
 
 {
    if (wxTheApp)