Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-01 08:29:27 +02:00
Code Issues Releases Wiki Activity

Consistent cap. of config paths in EffectsPrefs with family names...

Browse Source 
... That is:  EffectsPrefs.cpp is consistent with overrides of
EffectDefinitionInterface::GetFamily for each of the six (separately).

(The six aren't consistent with each other.  LADSPA really is an acronym, but
Vamp is not.)

See VAMPEFFECTS_FAMILY, which isn't up-cased, and LADSPAEFFECTS_FAMILY,
which is.  We change EffectsPrefs.cpp to match those constants.

See also where PluginManager.cpp uses
PluginDescriptor::GetEffectFamily, which is where the preferences written by
EffectsPrefs.cpp are used.

Does this break compatibility of old config files?  No, because lookup of
keys in wxConfigFile is case-insensitive, as determined by the preprocessor
constant wxCONFIG_CASE_SENSITIVE, which is false for all of our platforms.

So, no real effects here, but the consistency of string literals is reassuring.

It would be better, though, not to rely on such a coincidence of literals.
This commit is contained in:
Paul Licameli 2019-04-07 17:10:30 -04:00
parent 1649e3669e
commit 21eaaeac99
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/prefs/EffectsPrefs.cpp
View File

@ -70,7 +70,7 @@ void EffectsPrefs::PopulateOrExchange(ShuttleGui & S)
// JKC: LADSPA, LV2, Nyquist, VST, VAMP should not be translated.
#if USE_LADSPA
S.TieCheckBox(wxT("&LADSPA"),
wxT("/Ladspa/Enable"),
wxT("/LADSPA/Enable"),
true);
#endif
@ -87,7 +87,7 @@ void EffectsPrefs::PopulateOrExchange(ShuttleGui & S)
#if USE_VAMP
S.TieCheckBox(wxT("&Vamp"),
wxT("/VAMP/Enable"),
wxT("/Vamp/Enable"),
true);
#endif