2020-12-09 Fred Gleason <fredg@paravelsystems.com>

* Added a deprecation warning for the 'Allow Duplicate Cart Titles' and 'Auto-Correct Duplicate Cart Titles' checkboxes on the 'System-Wide Settings' dialog in rdadmin(1) as well as the Operations Guide. Signed-off-by: Fred Gleason <fredg@paravelsystems.com>
2025-04-11 07:12:56 +02:00 · 2020-12-09 13:38:39 -05:00 · 2020-12-09 13:38:39 -05:00 · 414f2e2267
commit 414f2e2267
parent c89feb5ad1
10 changed files with 122 additions and 5 deletions
--- a/5
+++ b/5
@ -20673,3 +20673,8 @@
 	in rdadmin(1) was unchecked.
 2020-12-09 Fred Gleason <fredg@paravelsystems.com>
 	* Fixed a typo in 'lib/rdcart.h' that broke the build.
+2020-12-09 Fred Gleason <fredg@paravelsystems.com>
+	* Added a deprecation warning for the 'Allow Duplicate Cart Titles'
+	and 'Auto-Correct Duplicate Cart Titles' checkboxes on the
+	'System-Wide Settings' dialog in rdadmin(1) as well as the
+	Operations Guide.
--- a/docs/opsguide/rdadmin.xml
+++ b/docs/opsguide/rdadmin.xml
@ -2518,10 +2518,8 @@
      system and not altered thereafter.
    </para>
    <warning>
-      <para>
-	Changing this setting on a system with existing audio in the
-	audio store may result in incorrect play-out of that audio!
-      </para>
+      Changing this setting on a system with existing audio in the
+      audio store may result in incorrect play-out of that audio!
    </warning>
    <para>
      The <computeroutput>Allow Duplicate Cart Titles</computeroutput> box,
@ -2533,6 +2531,14 @@
      &quot;<userinput>[n]</userinput>&quot;, (where <userinput>n</userinput>
      is an integer) to the end of the title string.
    </para>
+    <warning>
+      The ability to disallow duplicate cart titles in Rivendell
+      <emphasis role="bold">has been deprecated</emphasis>
+      and may be removed from future versions; it is included
+      strictly to keep existing setups working. Use of it can cause other
+      features within Rivendell to operate unreliably. It should never be
+      used in new Rivendell setups!
+    </warning>
    <para>
      If the <computeroutput>Show User List in RDLogin</computeroutput> box
      is ticked, rdlogin(1) will require users to enter their user name as
@ -2706,9 +2712,14 @@
  <sect1 xml:id="sect.rdadmin.configuring_webget">
    <title>Configuring Webget</title>
    <para>
-      Configuration of the Webget service consists of two tasks:
+      Configuration of the Webget service consists of three tasks:
    </para>
    <itemizedlist>
+      <listitem>
+	<para>
+	  Configure Rivendell to disallow duplicate cart titles.
+	</para>
+      </listitem>
      <listitem>
 	<para>
 	  Configure a set of Encoder Formats
@ -2720,6 +2731,13 @@
 	</para>
      </listitem>
    </itemizedlist>
+    <sect2 xml:id="sect.rdadmin.disallowing_duplicate_cart_titles">
+      <title>Disallowing Duplicate Cart Titles</title>
+      <para>
+	See &quot;Allow Duplicate Cart Titles&quot; checkbox in
+	<xref linkend="sect.rdadmin.manage_system_settings" />.
+      </para>
+    </sect2>
    <sect2 xml:id="sect.rdadmin.configuring_encoder_formats">
      <title>Configuring Encoder Formats</title>
      <para>
--- a/rdadmin/edit_system.cpp
+++ b/rdadmin/edit_system.cpp
@ -283,6 +283,16 @@ QSizePolicy EditSystem::sizePolicy() const

 void EditSystem::duplicatesCheckedData(bool state)
 {
+  if((!state)&&edit_system->allowDuplicateCartTitles()) {
+    if(QMessageBox::warning(this,"RDAdmin - "+tr("Deprecation Warning"),
+			    tr("The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!")+"<p>"+
+			    tr("Attempt to disallow duplicate cart titles anyway?"),
+			    QMessageBox::No,QMessageBox::Yes)!=QMessageBox::Yes) {
+      edit_duplicate_carts_box->setChecked(true);
+      return;
+    }
+  }
+
  edit_fix_duplicate_carts_box->setDisabled(state);
  edit_fix_duplicate_carts_label->setDisabled(state);
 }
--- a/rdadmin/rdadmin_cs.ts
+++ b/rdadmin/rdadmin_cs.ts
@ -4488,6 +4488,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>
--- a/rdadmin/rdadmin_de.ts
+++ b/rdadmin/rdadmin_de.ts
@ -4233,6 +4233,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>
--- a/rdadmin/rdadmin_es.ts
+++ b/rdadmin/rdadmin_es.ts
@ -4429,6 +4429,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>
--- a/rdadmin/rdadmin_fr.ts
+++ b/rdadmin/rdadmin_fr.ts
@ -3492,6 +3492,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>
--- a/rdadmin/rdadmin_nb.ts
+++ b/rdadmin/rdadmin_nb.ts
@ -4138,6 +4138,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>
--- a/rdadmin/rdadmin_nn.ts
+++ b/rdadmin/rdadmin_nn.ts
@ -4138,6 +4138,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>
--- a/rdadmin/rdadmin_pt_BR.ts
+++ b/rdadmin/rdadmin_pt_BR.ts
@ -4213,6 +4213,18 @@ List</source>
        <source>Origin E-Mail Address</source>
        <translation type="unfinished"></translation>
    </message>
+    <message>
+        <source>Deprecation Warning</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>The ability to disallow duplicate cart titles in Rivendell &lt;strong&gt;has been deprecated&lt;/strong&gt; and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <source>Attempt to disallow duplicate cart titles anyway?</source>
+        <translation type="unfinished"></translation>
+    </message>
 </context>
 <context>
    <name>EditTtys</name>