From 414f2e226758b77fa42b030b8dcea192ea9dd2b1 Mon Sep 17 00:00:00 2001 From: Fred Gleason Date: Wed, 9 Dec 2020 13:38:39 -0500 Subject: [PATCH] 2020-12-09 Fred Gleason * Added a deprecation warning for the 'Allow Duplicate Cart Titles' and 'Auto-Correct Duplicate Cart Titles' checkboxes on the 'System-Wide Settings' dialog in rdadmin(1) as well as the Operations Guide. Signed-off-by: Fred Gleason --- ChangeLog | 5 +++++ docs/opsguide/rdadmin.xml | 28 +++++++++++++++++++++++----- rdadmin/edit_system.cpp | 10 ++++++++++ rdadmin/rdadmin_cs.ts | 12 ++++++++++++ rdadmin/rdadmin_de.ts | 12 ++++++++++++ rdadmin/rdadmin_es.ts | 12 ++++++++++++ rdadmin/rdadmin_fr.ts | 12 ++++++++++++ rdadmin/rdadmin_nb.ts | 12 ++++++++++++ rdadmin/rdadmin_nn.ts | 12 ++++++++++++ rdadmin/rdadmin_pt_BR.ts | 12 ++++++++++++ 10 files changed, 122 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index d7735ef2..bf59e2bf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -20673,3 +20673,8 @@ in rdadmin(1) was unchecked. 2020-12-09 Fred Gleason * Fixed a typo in 'lib/rdcart.h' that broke the build. +2020-12-09 Fred Gleason + * Added a deprecation warning for the 'Allow Duplicate Cart Titles' + and 'Auto-Correct Duplicate Cart Titles' checkboxes on the + 'System-Wide Settings' dialog in rdadmin(1) as well as the + Operations Guide. diff --git a/docs/opsguide/rdadmin.xml b/docs/opsguide/rdadmin.xml index 33c066e4..fb8deabd 100644 --- a/docs/opsguide/rdadmin.xml +++ b/docs/opsguide/rdadmin.xml @@ -2518,10 +2518,8 @@ system and not altered thereafter. - - Changing this setting on a system with existing audio in the - audio store may result in incorrect play-out of that audio! - + Changing this setting on a system with existing audio in the + audio store may result in incorrect play-out of that audio! The Allow Duplicate Cart Titles box, @@ -2533,6 +2531,14 @@ "[n]", (where n is an integer) to the end of the title string. + + The ability to disallow duplicate cart titles in Rivendell + has been deprecated + and may be removed from future versions; it is included + strictly to keep existing setups working. Use of it can cause other + features within Rivendell to operate unreliably. It should never be + used in new Rivendell setups! + If the Show User List in RDLogin box is ticked, rdlogin(1) will require users to enter their user name as @@ -2706,9 +2712,14 @@ Configuring Webget - Configuration of the Webget service consists of two tasks: + Configuration of the Webget service consists of three tasks: + + + Configure Rivendell to disallow duplicate cart titles. + + Configure a set of Encoder Formats @@ -2720,6 +2731,13 @@ + + Disallowing Duplicate Cart Titles + + See "Allow Duplicate Cart Titles" checkbox in + . + + Configuring Encoder Formats diff --git a/rdadmin/edit_system.cpp b/rdadmin/edit_system.cpp index 369c2577..8a0b99fc 100644 --- a/rdadmin/edit_system.cpp +++ b/rdadmin/edit_system.cpp @@ -283,6 +283,16 @@ QSizePolicy EditSystem::sizePolicy() const void EditSystem::duplicatesCheckedData(bool state) { + if((!state)&&edit_system->allowDuplicateCartTitles()) { + if(QMessageBox::warning(this,"RDAdmin - "+tr("Deprecation Warning"), + tr("The ability to disallow duplicate cart titles in Rivendell has been deprecated and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups!")+"

"+ + tr("Attempt to disallow duplicate cart titles anyway?"), + QMessageBox::No,QMessageBox::Yes)!=QMessageBox::Yes) { + edit_duplicate_carts_box->setChecked(true); + return; + } + } + edit_fix_duplicate_carts_box->setDisabled(state); edit_fix_duplicate_carts_label->setDisabled(state); } diff --git a/rdadmin/rdadmin_cs.ts b/rdadmin/rdadmin_cs.ts index 17fc5ce4..c4ed3b59 100644 --- a/rdadmin/rdadmin_cs.ts +++ b/rdadmin/rdadmin_cs.ts @@ -4488,6 +4488,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys diff --git a/rdadmin/rdadmin_de.ts b/rdadmin/rdadmin_de.ts index 966cbc59..a81dae53 100644 --- a/rdadmin/rdadmin_de.ts +++ b/rdadmin/rdadmin_de.ts @@ -4233,6 +4233,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys diff --git a/rdadmin/rdadmin_es.ts b/rdadmin/rdadmin_es.ts index 0a6f339c..a37042d3 100644 --- a/rdadmin/rdadmin_es.ts +++ b/rdadmin/rdadmin_es.ts @@ -4429,6 +4429,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys diff --git a/rdadmin/rdadmin_fr.ts b/rdadmin/rdadmin_fr.ts index 84604b05..58bac0f2 100644 --- a/rdadmin/rdadmin_fr.ts +++ b/rdadmin/rdadmin_fr.ts @@ -3492,6 +3492,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys diff --git a/rdadmin/rdadmin_nb.ts b/rdadmin/rdadmin_nb.ts index fe34475d..842078c8 100644 --- a/rdadmin/rdadmin_nb.ts +++ b/rdadmin/rdadmin_nb.ts @@ -4138,6 +4138,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys diff --git a/rdadmin/rdadmin_nn.ts b/rdadmin/rdadmin_nn.ts index fe34475d..842078c8 100644 --- a/rdadmin/rdadmin_nn.ts +++ b/rdadmin/rdadmin_nn.ts @@ -4138,6 +4138,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys diff --git a/rdadmin/rdadmin_pt_BR.ts b/rdadmin/rdadmin_pt_BR.ts index 1256fee4..12fa5c6a 100644 --- a/rdadmin/rdadmin_pt_BR.ts +++ b/rdadmin/rdadmin_pt_BR.ts @@ -4213,6 +4213,18 @@ List Origin E-Mail Address + + Deprecation Warning + + + + The ability to disallow duplicate cart titles in Rivendell <strong>has been deprecated</strong> and may be removed from future versions; it is included strictly to keep existing setups working. Use of it can cause other features within Rivendell to operate unreliably. It should never be used in new Rivendell setups! + + + + Attempt to disallow duplicate cart titles anyway? + + EditTtys