1
0
mirror of https://github.com/cookiengineer/audacity synced 2026-03-06 14:35:32 +01:00
Commit Graph

9310 Commits

Author SHA1 Message Date
Paul Licameli
7d55defde6 Rewrite channel iterations that don't generalize to more than two...
... requiring at least some message rewrites.

All these places have a comment:

// TODO: more-than-two-channels

or in simpler cases just

// TODO: more-than-two-channels-message
2018-10-01 13:42:33 -04:00
Paul Licameli
dbf44efc9f Iterations over channels in remaining places that won't generalize...
... simply to the more-than-stereo case.

All these places have the comment:

// TODO: more-than-two-channels
2018-10-01 13:42:33 -04:00
Paul Licameli
4aa990e835 Remove GetLink(ed) in various other places 2018-10-01 13:42:33 -04:00
Paul Licameli
c107fb298b Remove GetLink(ed) in channel manipulation menu items 2018-10-01 13:42:32 -04:00
Paul Licameli
ecc869bdbe Remove GetLink(ed) in TrackPanel resizing code 2018-10-01 13:42:32 -04:00
Paul Licameli
d2a18f01e3 Remove use of GetLink(ed) in AudacityProject::OnPaste 2018-10-01 13:42:32 -04:00
Paul Licameli
7eadd7a36f Iterations over channels involving third-party effects libraries...
... I don't know whether these libraries support more than two channels with
no problems.

All these places have the comment:

// TODO: more-than-two-channels
2018-10-01 13:42:31 -04:00
Paul Licameli
22c85dd99c Rewrite GetLink(ed) in SBSMS 2018-10-01 13:42:31 -04:00
Paul Licameli
48ae1eb3c9 Rewrite GetLink(ed) in SoundTouch 2018-10-01 13:42:31 -04:00
Paul Licameli
70f7b0f6ef Iterations over channels where more general messages may be needed...
... but otherwise the logic generalizes without a problem.

All these places have the comment:

// TODO: more-than-two-channels-message
2018-10-01 13:42:30 -04:00
Paul Licameli
518df314eb Rewrite GetLink(ed) in vamp effects 2018-10-01 13:42:30 -04:00
Paul Licameli
a68184f81d Remove GetLink(ed) in track panel drawing and refresh 2018-10-01 13:42:30 -04:00
Paul Licameli
46557a9a2d Rewrite many track type switches, track and channel iterations...
... that present no complications to more-than-stereo genralization
2018-10-01 13:42:29 -04:00
Paul Licameli
4c75175e41 Remove GetLink(ed) in Normalize effect...
... It's much simpler and should be easy to generalize, but what would be
appropriate messages?
2018-10-01 13:42:29 -04:00
Paul Licameli
f276373f3c Remove GetLink(ed) in clip-moving functions 2018-10-01 13:42:29 -04:00
Paul Licameli
3561154311 More rewrites of iterations over channels...
... that can generalize to more than stereo
2018-10-01 13:42:28 -04:00
Paul Licameli
669054b4f4 Remove many uses of GetLink in TrackPanel 2018-10-01 13:42:24 -04:00
Paul Licameli
0c0c2c0d1e Rewrite iteration over visible tracks in TrackArtist...
... also eliminating AudacityProject::GetFirstVisible.
2018-10-01 13:41:51 -04:00
Paul Licameli
51e0ae0447 Remove GetLink() in AudacityProject::AddImportedTracks...
... Be careful when you call IsLeader()!  It's correct only after the
tracks belong to the project's TrackList.
2018-10-01 13:41:51 -04:00
Paul Licameli
a7ca6db7c3 Rewrite many iterations over tracks and channels, track type tests...
... which do not require cautions for future more-than-stereo cases.
2018-10-01 13:41:50 -04:00
Paul Licameli
968d63d5fd Rewrite many iterations over tracks and channels in various places 2018-10-01 13:35:51 -04:00
Paul Licameli
fee0f284fe Rewrite many iterations over tracks and channels in src/toolbars 2018-10-01 11:25:07 -04:00
Paul Licameli
3eee8b8cf0 Rewrite many iterations over tracks and channels in src/import, src/export 2018-10-01 11:24:50 -04:00
Paul Licameli
c7ab9f2338 Rewrite many iterations over tracks and channels in src/commands 2018-10-01 11:24:37 -04:00
Paul Licameli
23a85893a1 Rewrite some iterations over tracks and channels in TrackPanel 2018-10-01 11:24:25 -04:00
Paul Licameli
aee4005044 Rewrite many iterations over tracks and channels in src/effects 2018-10-01 11:24:04 -04:00
Paul Licameli
b94e8fec96 Remove VisibleTrackIterator 2018-10-01 11:20:52 -04:00
Paul Licameli
ae2ce1ad90 Rewrite many iterations over tracks and channels in Project.cpp 2018-10-01 11:19:54 -04:00
Paul Licameli
d01013e0d0 Rewrite many iterations over tracks and channels in Menus.cpp 2018-10-01 11:19:35 -04:00
Paul Licameli
1e32309d24 Rewrite MenuCommandHandler::HandleAlign 2018-10-01 11:19:18 -04:00
Paul Licameli
b6a6b8e73e Rewrite iterations over sync-lock groups 2018-10-01 11:09:20 -04:00
Paul Licameli
bb3aa00f50 Effect::CopyInputTracks was only called with two values...
So now it simply takes a bool.
2018-10-01 11:06:31 -04:00
Paul Licameli
2e11844f6a Effect::inputTracks() now gives only const access 2018-10-01 10:59:48 -04:00
Paul Licameli
1be3187b99 Use TrackIterRange::Visit 2018-10-01 10:59:24 -04:00
Paul Licameli
17089d03bf Rewrite MenuCommandHandler::OnPaste with TypeSwitch and new iterators 2018-10-01 10:59:09 -04:00
Paul Licameli
51842fc78b Use TypeSwitch and track_cast 2018-10-01 10:58:47 -04:00
Paul Licameli
fd10ed26cd Use TypeSwitch and track_cast in TrackPanel 2018-10-01 10:58:33 -04:00
Paul Licameli
e17c4acd5d Rewrite sorting of tracks 2018-10-01 10:54:37 -04:00
Paul Licameli
48f5bd7353 Rewrite details of Track, TrackList with new iterators and track_cast 2018-10-01 10:54:27 -04:00
Paul Licameli
1a59ba6331 Simplify some internals of TrackList, don't assume at most 2 channels 2018-10-01 10:54:14 -04:00
Paul Licameli
7ec734b087 Rewrite TrackList::SwapNodes without GetLink(ed) 2018-10-01 10:54:04 -04:00
Paul Licameli
b05c32e2ac Remove some things from Track.h, replacing their uses with new iterators 2018-10-01 10:50:34 -04:00
Paul Licameli
05ddfaf82b Remove TrackList::Select 2018-10-01 10:47:51 -04:00
Paul Licameli
5c6fd64a0e TrackList::GetPrev and ::GetNext are private 2018-10-01 10:44:58 -04:00
Paul Licameli
a0e15cfbbd Remove TrackListIterator::RemoveCurrent 2018-10-01 10:42:02 -04:00
Paul Licameli
89748cbe3c Remove "skiplinked" argument of old track iterators 2018-10-01 10:35:46 -04:00
Paul Licameli
d19695022a Add new-style track_cast, iterators, and TypeSwitch for Track 2018-10-01 10:32:50 -04:00
Paul Licameli
52848e4483 Define Track::TypeSwitch for type-safe dispatching 2018-10-01 10:32:48 -04:00
Paul Licameli
a3cdb08ee0 Classes and functions for type-safe iteration over tracks 2018-09-29 22:17:55 -04:00
Paul Licameli
6a9f9d7899 Define track_cast, like dynamic_cast...
... but perhaps faster using our custom type-query method.
2018-09-29 21:41:47 -04:00