The welcome screen now has an extra prelude for Alphas, and as result no longer needs to force a version check onto our website. Users can still do that by clicking "check online".
I've also rearranged the version check code a little, so that there is better reuse. E.g. we can change the URL in just one place in the code.
- For ALPHA builds we do a check version with the Welcome screen (if welcome screen is enabled).
- A 'Check Online' in the About box provides a new route to check version
- Check Version now passes CommitId and Build Date/Time to identify a version.
To actually close the bug we need the javascript on the server page to put up informative messages.
... At startup, spawn a copy process in main() and crash it at once. The
child process continues. (The fix was ineffective when the parent continued
and the child crashed.)
Re-activiation of the application is also needed or else the windows are
hidden behind other applications.
Another sleep when closing a project, to fix occurrences of the bug caused by
closing of a project window without saving changes.
Previously this could/would fail to create a temporary directory if the earlier
components in the path did not exist. The user would then be prompted
unnecessarily for a location to store temporary files.
Also now disallow blank as a temporary directory name.
Also no longer search entire dmg for plug ins. Just search the app itself.
... Partial reversion of commit 2e8ee5fe75
Now, if you open an effect dialog, Return key will apply it. But, if you
cycle among windows with alt+f6, then the focus moves among the controls in
the effect dialog, and I don't know how to prevent that.
At least so it is in Mac. I have not verified it with Linux.
Very low risk workaround implemented - close and dispose of the splash screen before creating project.
It is pretty clear it is the interaction between two dialogs during AppInit that is the root cause of the problem.
A high risk solution would involve delving into and fixing wx3 internals.
Splash screen will now disappear fractionally sooner than before - the time it takes to create an empty project.
Space required in path name. Also force old names that were set to temp directory to update to ones that aren't on Mac too.
Something to test on Mac -> What happens if suggested directory does not exist?
Untested on Mac (I don't have one). Might perhaps even fail to compile. But 1220 is a P1. Important enough for our schedule that we clear it now that I am happy enough to risk a 'blind patch'.
This fix is good for Mac only, but maybe the same could apply to Linux.
See also commit a00f866b54
That commit fixed, e.g., alt+f6 cycling between the main window and the splash
dialog when starting Audacity. However, alt+tab to switch applications, then
again to return to Audacity, still trapped you.
This further change eliminates the other trap.
Perhaps the conditional compilation #ifdef __WXMAC__ in these two commits
could be broadened to cover Linux and the bug will be fixed there too.
... So it does not depend on the focused window, and can work when selection
toolbar has focus. But TrackPanel's escape handling may still take precedence
over it.
