With recent changes to the Nyquist code for freeing blocks, the pointer 'next' could be uninitialised when 'list' points to the zero chain. So Audacity would follow a rogue pointer. We'd get away with it if the uninitialised value happened to be zero.
... Windows didn't need them, Preferences already navigated correctly between
the panes, but the new changes caused navigation to get trapped in radio
button groups.
Bug682: fix Tab key navigation in Preferences, particulary Keyboard
Compensate for wxW 3 tab navigation deficiencies on Mac...
Allow tabbing to the button on the time ruler...
Fix Mac tabbing to sliders and meters, analogously to buttons...
Make tabbing between toolbar buttons work on Mac
Fix drawing of focus rectangles in buttons, meters, sliders on Mac
I confirmed that the currently used real FFT code in RealFFTf.cpp is faster
than the old one with a quick benchmark that calls PowerSpectrum() on 4-minute
audio file, with different sizes of computation windows:
Window_size: 256 method: new FFT time_s: 0.393
Window_size: 256 method: old FFT time_s: 1.065
Window_size: 1024 method: new FFT time_s: 0.38
Window_size: 1024 method: old FFT time_s: 0.958
Window_size: 4096 method: new FFT time_s: 0.413
Window_size: 4096 method: old FFT time_s: 1.084
Window_size: 16384 method: new FFT time_s: 0.518
Window_size: 16384 method: old FFT time_s: 1.338
Window_size: 65536 method: new FFT time_s: 0.655
Window_size: 65536 method: old FFT time_s: 1.524
Window_size: 262144 method: new FFT time_s: 0.735
Window_size: 262144 method: old FFT time_s: 1.873
To reproduce the bug: open audacity, press r, then spacebar to record some audio. The track is not the focus - the track panel is.
This was caused by commit 519a202. Most of the changes in this commit were latter reverted in commit 80e19f2, but not the changes to the file src/TrackPanelAx.cpp
The fix is to go back to the version of TrackPanelAx.cpp in commit db35301, the commit before 519a202.
Click twice on a grid cell; Cancel or OK dismiss the dialog. But ESC does not,
and a second ESC does not either. ESC dismisses the dialog only if the focus
is not in the grid.
... However there is some code in class ASlider meant to draw focus border.
But I verified that this had no effect on Mac, even in 2.1.1.
So, still no border.
