1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-11 06:07:44 +02:00

352 Commits

Author SHA1 Message Date
v.audacity
ee7e35b3eb (Fix Bug 250 - Pan sliders sometimes not drawn in Mixer Board, P2)
This bug was introduced in commit 10680 and caused in MixerTrackCluster::UpdatePan(), by using USE_MIDI (which is on in releases) instead of EXPERIMENTAL_MIDI_OUT (which is off). It checked whether a NoteTrack pointer was NULL, and if not, hid the Pan slider (not used in NoteTrack clusters). But an invalid pointer is non-null, so was causing the Pan slider to always be hidden.
2010-11-06 00:00:23 +00:00
BusinessmanProgrammerSteve
83ac7266c8 Reduce initial slider pool size to cut project-open time. 2010-11-05 06:25:26 +00:00
rbdannenberg
467aa5590a Fixed SAL effects so that correct line numbers are reported when an error occurs. 2010-11-02 19:46:19 +00:00
rbdannenberg
28661781be Modified so that when debugging SAL code, errors cause SAL traceback rather than XLISP stack trace. 2010-11-01 05:04:39 +00:00
rbdannenberg
f2e6d8ec0f Nyquist Effects now treat Nyquist code and output as UTF-8. Nyquist Prompt effect accepts both LISP and SAL (in SAL, either define function main or write return <expression> at the top level). 2010-11-01 03:15:39 +00:00
martynshaw99
38caac8648 Edgar's fix for problems with backslashes and double-quotes in the Audacity Nyquist text input widget, as approved by Steve, Al and Roger. 2010-10-28 23:22:02 +00:00
martynshaw99
b368c2d4d2 Fix VS build, and hope it doesn't break others. 2010-10-28 23:07:33 +00:00
rbdannenberg
92950e22fd Previous version did not compile on OS X due to confusion between USE_MIDI and EXPERIMENTAL_MIDI_OUT and some missing includes that didn't bother Visual C++. This revision fixes OS X builds. 2010-10-28 21:22:14 +00:00
rbdannenberg
f274c9fb2b Extended pitch, tempo, and speed effects to operate on NoteTracks. Fixed off-by-one error on channel buttons. 2010-10-28 17:57:14 +00:00
rbdannenberg
f3b91514d2 NoteTrack channel buttons have prettier graphics in down position which now means ON; VEL_SLIDER depends on EXPERIMENTAL_MIDI_OUT (not USE_MIDI); velocity slider changes are labeled as such to Undo manager; fixed an OS X bug where backing bitmap does not get yellow highlight and then highlight on screen gets clobbered when user moves gain sliders (!); Added a high-level overview of redraw to TrackArtist.cpp. 2010-10-28 17:34:35 +00:00
rbdannenberg
932ca88255 Minor bug fixes for EXPERIMENTAL_MIDI_OUT. Also added files for autoconf/automake to portmidi and libscorealign. I also modified my local build-related files in src and lib-src to handle EXPERIMENTAL_MIDI_OUT and EXPERIMENTAL_SCOREALIGN, but while I can build with these options, the build-related files are not entirely working, so I will not commit them and break the "normal" builds. I suspect these new build files in this commit are not entirely correct -- some review is in order. 2010-10-28 15:35:29 +00:00
BusinessmanProgrammerSteve
2499082baa Update Sync-Lock icons on toolbar, TrackInfo; add the ability to have
a different foreground icon when a toolbar button is pressed (which
will likely be used soon for the Sync-Lock icon).
2010-10-27 04:36:26 +00:00
windinthew
1fbf7136cb remove duplicate "enough" 2010-10-24 15:01:18 +00:00
v.audacity
dae6f69678 a little more commentary on the Theming flags 2010-10-24 00:35:07 +00:00
v.audacity
57ba7640ab Move an old comment past later additions, to the code it actually refers to.
Ask a question about the mSelectAllOnNone addition.
2010-10-22 21:30:38 +00:00
BusinessmanProgrammerSteve
29523e7aee Better fix for bug 175 (GTK+ slider background colour) 2010-10-21 06:06:38 +00:00
v.audacity
741fab0f61 Get rid of comments that are no longer accurate. 2010-10-18 21:38:25 +00:00
mchinen
29ac40e61f ImportPCM.cpp cleanup comments 2010-10-18 19:17:51 +00:00
BusinessmanProgrammerSteve
ece4d2ac8c Add B. Drung's patch for bug #175 under an #ifdef so it doesn't mess up Windows 2010-10-18 07:09:42 +00:00
BusinessmanProgrammerSteve
cb51d71099 Tilt the sync-lock tiles! 2010-10-18 01:58:57 +00:00
v.audacity
e2261d1473 // Note that History window should be available either for UndoAvailableFlag or RedoAvailableFlag,
// but we can't make the AddItem flags and mask have both, because they'd both have to be true for the 
   // command to be enabled. 
   //    If user has Undone the entire stack, RedoAvailableFlag is on but UndoAvailableFlag is off.
   //    If user has done things but not Undone anything, RedoAvailableFlag is off but UndoAvailableFlag is on.
   // So in either of those cases, (AudioIONotBusyFlag | UndoAvailableFlag | RedoAvailableFlag) mask 
   // would fail. 
   // The only way to fix this in the current architecture is to hack in special cases for RedoAvailableFlag
   // in AudacityProject::UpdateMenus() (ugly) and CommandManager::HandleCommandEntry() (*really* ugly -- 
   // shouldn't know about particular command names and flags).

   // So for now, enable the command regardless of stack. It will just show empty (except for Created Project) sometimes. 

   // FOR REDESIGN, clearly there are some limitations with the flags/mask bitmaps.
2010-10-17 23:00:01 +00:00
v.audacity
1f48404e16 In HistoryWindow::HistoryWindow():
// Vaughan, 2010-07-30: AudacityProject::OnHistory always calls Show() 
   //    then HistoryWindow::UpdateDisplay, so no need to do it here.
   // Vaughan, 2010-10-16: Not on Windows, anyway. 
   //    But Steve reported that on Ubuntu, View > History now crashes, 
   //    so restore it for non-Windows.
2010-10-16 23:24:45 +00:00
v.audacity
300d50a5d1 Standardize titles capitalization for buttons and static texts. 2010-10-16 08:37:27 +00:00
martynshaw99
500c84fe5d Improve the way that EQ curves with points beyond fs/2 are handled, making use of Envelope code. Why didn't I think of this before? :-) 2010-10-12 00:11:06 +00:00
v.audacity
d562770d70 (bug 29, P3: Input and/or output sliders operate incorrectly for any device when an external device is connected.)
If the Meter Toolbar was monitoring input, PrefsDialog can be opened, but then PrefsDialog::OnOK() needs to StopStream() or AudioIO::HandleDeviceChange() will no-op. We could instead disable the Preferences command while monitoring, i.e., set AudioIONotBusyFlag/AudioIOBusyFlag according to monitoring, as well as gAudioIO->IsAudioTokenActive(). Instead allow it because unlike recording, for example, monitoring is not clearly something that should prohibit opening prefs. 

This may have been some of the occasions of bug 29, where user changed device while monitoring, but the AudioIO::HandleDeviceChange() code did not actually change the device, so it look like the user had specificied the motherboard/sound card default device, but Audacity was still using the USB device.

      // TO-DO: We *could* be smarter in this method and call HandleDeviceChange()  
      // only when the device choices actually changed. True of lots of prefs!
      // As is, we always stop monitoring and handle the device change.

In AudacityProject::GetUpdateFlags(), don't need to check (GetAudioIOToken() == 0) alternative because gAudioIO->IsAudioTokenActive() checks that it's greater than zero.

In AudioIO.cpp, cleaned up some logic and encapsulation of boolean methods.
2010-10-09 00:50:52 +00:00
mchinen
a9a0d51454 Timetrack fixes and refactoring.
Possibly fixes:

Bug 206 - Time Tracks: Ruler warp goes in wrong direction
Bug 205 - Time Tracks that slow down the audio result in truncated exports
2010-10-07 23:01:49 +00:00
rbdannenberg
2fd5555378 Fixed playback/redraw interactions (redraw was converting from seconds to beats while player was trying to read seconds in another thread). Added compile-time option make channel select be the down position. Fixed problem with MIDI track mute to eliminate hung notes. 2010-10-07 21:36:39 +00:00
rbdannenberg
f52bafbf05 Removed Windows debugging commands accidentally left in. Play-at-speed should now work on NoteTracks if EXPERIMENTAL_MIDI_OUT is defined. 2010-10-06 04:55:14 +00:00
martynshaw99
0d84a2d934 Revert r10691 - re-allowing clips to be floating around, not on a sample. There has been much discussion on -devel about this and I think we can keep things in order without this restriction. 2010-10-05 21:46:51 +00:00
rbdannenberg
08b98dce53 PlayAtSpeed works for MIDI. Removed prefs for selecting MIDI input device (unless EXPERIMENTAL_MIDI_IN is on -- but there is no MIDI recording implemented at all) 2010-10-05 18:29:57 +00:00
rbdannenberg
28aaa34889 With EXPERIMENTAL_MIDI_OUT, pausing MIDI and audio playing together now turns off all MIDI notes currently playing (same behavior as pausing MIDI track alone) 2010-10-05 02:42:29 +00:00
v.audacity
c067f93838 Testing a link on a non-development machine, I wanted to make sure I had the right version of Audacity, so checked the AboutDialog. Found some problems and fixed them:
Martyn was out of alphabetical order. The reason was that the role values for Leland and Markus were not changed when they were moved to the emeritus list. 

Went ahead and split up the developer and support lists, and removed the comment, as that's how they'll appear in the interface and it's easier to alphabetize and maintain same-role lists rather than interleaved.
2010-10-05 00:42:13 +00:00
rbdannenberg
6fa857c3ae Fixed MIDI playback on Linux. Still need configure files for libscorealign and portmidi. (I tweaked makefiles by hand to build and test with EXPERIMENTAL_MIDI_OUT and EXPERIMENTAL_SCOREALIGN.) Also, I updated portmidi files, including some bug fixes from the portmidi project. 2010-10-01 17:59:18 +00:00
rbdannenberg
576dfe6653 Restore Audacity xcode project (undoing accidentally committed OS X 10.6 changes in revision 10695). Fix some midi playback problems. 2010-10-01 15:26:46 +00:00
v.audacity
339303e7ec (Bug 229, P3: It is possible to assign the same keyboard shortcut to 2 commands)
Ed Musgrove's patch to fix cases where the bug currently occurs. 

This does not completely fix the bug, because users can still set modifier keys in the wrong order so they would be two separate entries in CommandManager::mCommandKeyHash, but KeyEventToKeyString() will put them in the expected order, so the version in the expected order will always be the one CommandManager::HandleKey() uses.
2010-10-01 00:25:53 +00:00
v.audacity
8f20e65167 (bug 20, P2)
Fix auto-recovery failures that Gale reported, when auto-recovered projects had been saved to top-level directories, e.g., "E:\dtmf.aup" on Windows. Problem was with file separators. This DirManager code is quite convoluted, touched by multiple chefs, and called from many places, so this fix does not correct the origination(s) of the problem, but doesn't break anything higher up, and is a failsafe against probably multiple errors at higher levels.

Make some parameter names clearer vs class vars. Readability is better if the names are not lexicographically exactly the same.
2010-09-28 05:03:50 +00:00
v.audacity
bd39b07260 'How to Get Help' is a title, so needs title capitalization, so changed "get" to "Get". And it's a dialog box, not a message.
Internet is a proper name, so should always be capitalized.
2010-09-28 01:50:45 +00:00
rbdannenberg
e76bfa39ef Fix compiler warnings (string constant to char *) from allegro.h. Also implements play at speed for MIDI, but some MIDI playback problems remain. 2010-09-27 05:51:41 +00:00
windinthew
a267f86b2e Clarify in "Can't export multiple files" warning that the Label Track containing labels must be directly underneath the audio track. 2010-09-25 07:45:56 +00:00
martynshaw99
48e04173b1 Make sure that whenever a clip is offset, it is by a whole number of samples at it's sample rate. 2010-09-23 23:06:12 +00:00
v.audacity
ec047e7c71 (bugs 20 and 137, P2) Working on these bugs, tightened up some code and corrected some comments. 2010-09-23 00:30:05 +00:00
martynshaw99
e46abdbeaa Using QUANTIZED_TIME, functionally identical. 2010-09-22 23:24:52 +00:00
windinthew
31041351c5 Remove ellipses from title of Nyquist Prompt dialogue 2010-09-21 06:03:52 +00:00
v.audacity
afc2818026 Restore cruft declaration of clrTrackInfoSyncLockSel, per http://audacity.238276.n2.nabble.com/Deleting-colors-td5546304.html#a5546304. 2010-09-20 20:30:45 +00:00
prlivesey
3db9b4db68 Changes to fix compilation problems on a Mac after extensive changes to improve NoteTrack display. 2010-09-19 21:46:40 +00:00
richardash1981
312faf654d Experimental features (especially ones that don't work on all platforms) shouldn't be enabled by default! 2010-09-19 20:50:51 +00:00
BusinessmanProgrammerSteve
b016dc8386 Fix compile --without-midi 2010-09-19 17:32:03 +00:00
rbdannenberg
a1f0e5ed5b Extensive changes to improve NoteTrack display and (some) editing, NoteTrack playback via MIDI, and Midi-to-Audio alignment. 2010-09-18 21:02:36 +00:00
BusinessmanProgrammerSteve
f6327602e8 Improve consistency of copy/paste operations in label tracks;
use new background-drawing function in label tracks.
2010-09-18 17:41:15 +00:00
v.audacity
7e1db64bc2 (bug 20, P2) Log some summary messages as well, for auto-recovery mode, so the log indicates the "safe" choice that was taken for each of the four types of errors. 2010-09-18 00:32:59 +00:00