Paul Licameli
cde61edbf4
Don't assume BlockHashes contain non-null pointers ...
...
... They won't always, when they become weak pointers.
2016-08-16 12:29:59 -04:00
Paul Licameli
e7b4d935a5
Hide the use of new in factory functions for BlockFiles
2016-08-16 12:29:59 -04:00
Paul Licameli
2ede67be96
Use type alias for pointer to BlockFile, which is still a dumb pointer
2016-08-16 12:29:59 -04:00
Steve Daulton
7b14e68b37
Pass name of proxy effect to EffectSBSMS
...
Allows progress bar to show meaningful title when using SBSMS
time stretching in Change Pitch/Tempo.
2016-08-16 14:54:34 +01:00
David Bailes
19fa6d2833
Improvements to accessibility names in Change Tempo effect.
...
The change tempo effect was modified in commit 8e0089c.
The most significant change is to include the "from" length in the accessibility name of the "to" length textctrl. (The nvda screen reader cannot access the value of the "from" length textctrl, and it's not straightforward using Jaws. Note that this issue existed before the recent change of Change Tempo.)
There remains a minor issue of Jaws, but not NVDA reading the names of wxStaticBoxes, and so some repetition in what is read by Jaws.
2016-08-16 13:57:19 +01:00
Paul Licameli
1cad18c479
Merge pull request #150 from RaphaelMarinier/optimize_selection_bar_update_master
...
Optimize the refresh of the selection bar while Audacity is playing.
2016-08-15 22:04:42 -04:00
Paul Licameli
15a60bde4b
Fix linux debug complaints of missing thread shut-down...
...
... caused by commit b47bcb548e7866c1a44a4600ffbeff0ae0445516
2016-08-15 21:21:09 -04:00
Paul Licameli
c9204af7fe
Rewrite functions managing the missing block file...
...
... removing one ref and deref of block files.
This unblocks a future development that will manage all block files with
std::shared_ptr.
2016-08-15 13:04:19 -04:00
Paul Licameli
5752dbab02
shared_ptr manages AudacityProject objects, so weak_ptr may be used
2016-08-15 12:43:50 -04:00
Paul Licameli
3c4ac1861c
Declare a method as const
2016-08-15 12:43:50 -04:00
Gale Andrews
973358339d
Pinned option first (more logical), add access key
2016-08-15 15:40:24 +01:00
Steve Daulton
8e0089c552
Add SBSMS option to Change Tempo effect
...
Thanks to Clayton Otey for his help and patience.
2016-08-15 12:33:33 +01:00
James Crook
45606fa1f4
Fix default positions of toolbars.
...
Device toolbar had jumped to the top with a recent change of toolbar visibility.
2016-08-15 09:42:29 +01:00
Paul Licameli
fe5ab9a462
Remove the naked new in allocation of AudacityProject
2016-08-14 15:24:59 -04:00
James Crook
d0a32f27eb
Hide Scrubbing Toolbar by default.
2016-08-14 15:59:07 +01:00
James Crook
8a8b43d956
Bug 1419 - Restore "scrub indicator shows before we click in scrub ruler".
...
Restored Paul's original intention, which I inadvertently changed in my fix for Bug 1419. Moving into the scrub ruler shows the scrub indicator now even before we actually start scrubbing (or seeking). The tooltip is now seen as belonging to the scrub indicator rather than to the ruler. Additionally I show the indicator immediately on entry, rather than requiring a movement left or right first, which I think is better and I think the original version didn't.
2016-08-14 15:26:07 +01:00
Paul Licameli
d84e1cc45e
Fix memory leaks, though in unused code...
...
... Is this kept around for future use?
2016-08-14 10:20:50 -04:00
Paul Licameli
41efaeeef0
Fix Windows build
2016-08-14 09:35:04 -04:00
Paul Licameli
32f24eabb2
Review uses of safenew...
...
... add comments and assertions, and use make_unique instead where possible
2016-08-13 23:16:05 -04:00
Paul Licameli
84a6456788
Iterate over all clips of a track, including cutlines, where needed
2016-08-13 20:17:55 -04:00
Paul Licameli
6909bdf398
Define and use IteratorRange
2016-08-13 16:31:31 -04:00
Steve Daulton
90e400b0a7
Add SBSMS option to Change Pitch effect
2016-08-13 17:28:49 +01:00
Paul Licameli
46f38708ed
Dir manager uses std::shared_ptr
2016-08-13 12:23:05 -04:00
Paul Licameli
e412c13e78
Fix crash at program exit after use of Stereo to Mono
2016-08-13 10:39:56 -04:00
Paul Licameli
291aff18e1
Remove various naked news and deletes
2016-08-13 10:38:50 -04:00
Paul Licameli
bf1e8a1227
One more safenew for the logger object
2016-08-13 10:37:52 -04:00
Paul Licameli
2024c8b319
Remove a naked new in AudacityLogger.cpp
2016-08-13 10:37:52 -04:00
Paul Licameli
b6241c46d3
Remove a few more naked new in CommandManager.cpp
2016-08-13 10:37:52 -04:00
Paul Licameli
2917fe5087
One more make_unique for WaveClip, and comment changes
2016-08-13 10:37:52 -04:00
Paul Licameli
e599cfa6fa
Effect::mOutputTracks is managed by smart pointer
2016-08-13 10:37:51 -04:00
David Bailes
7f122a42f9
Fix Windows build
...
vs2013/5 do not support defaulted move constructed, so made it explicit.
2016-08-13 13:18:34 +01:00
Paul Licameli
dcceaca13c
Envelope bug
2016-08-12 20:53:38 -04:00
Paul Licameli
cb48ca2b91
Use arrays of smart pointers to WaveClip
2016-08-12 20:53:38 -04:00
Paul Licameli
a400a7408c
Distinguish whether clip ptr arrays own; vector; const-correctness
2016-08-12 20:53:38 -04:00
Paul Licameli
4cbca5d75c
Use std::vector to hold WaveClips
2016-08-12 20:53:38 -04:00
Paul Licameli
afc22caf5a
WaveClip::GetCutLines() returns a reference
2016-08-12 20:53:37 -04:00
Paul Licameli
bd57f6392f
Simplify iterations over cutlines in WaveClip.cpp; stl idioms
2016-08-12 20:53:37 -04:00
Paul Licameli
77a3647922
Simplify iterations over WaveClips in WaveTrack.cpp; stl idioms
2016-08-12 20:53:37 -04:00
Paul Licameli
b548e641ae
Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ...
...
... also add some const qualifiers
2016-08-12 20:53:37 -04:00
Paul Licameli
cb7872f980
use std::vector to hold TrackClip; move ctor and dtor out of line
2016-08-12 20:53:37 -04:00
James Crook
2d2cf5911f
Pinned/Unpinned button now affects PlayHead.
...
Bug 1451 comment 6 asks for PlayHead to change too with the change in the button icon on up/down, making the action of the button clearer.
This change does not though change the icon on the button to red when recording. It stays green, though the PlayHead does change correctly.
2016-08-12 17:32:30 +01:00
James Crook
c2eda38ee1
Bug 1455 - Windows/Linux: Scrub Bar button background colour darker than Timeline/other toolbar buttons
...
Background, over the part that shows the number '1.0' is now transparent.
2016-08-12 13:49:02 +01:00
James Crook
53bb478600
Bug 1457 - Transport Menu "Scrub" and "Seek" do not correctly indicate when either Scrubbing mode is active
2016-08-11 22:30:51 +01:00
James Crook
35c033d3fa
Bug 1451 - On Mac the background of the Pinned/Unpinned button is not the same color as the Timeline
...
Per comments in the bug, fixed by making the pinned/unpinned button more clearly a button.
This involved adding a new type of grabber that does not have the ribs for dragging it and acts as a spacer.
Also fixing grabber so that it does not have to be at position (0,0)
Also making the ruler 1 pixel higher.
Also changing the pin button to be a toggle button that changes from up to down on a click.
Also fixing AButton so that an image can be bigger than the button.
2016-08-11 21:54:45 +01:00
James Crook
eebe4a961e
Bug 1419 - Confusing and unnecessary widget change when clicking in Scrub Bar
...
Behaviour now is still (in my view) confusing, but the widget does update when you click and release and haven't moved yet, which it didn't do before.
2016-08-11 17:59:41 +01:00
Gale Andrews
f7a85f4d52
Fix typo in label
2016-08-11 17:12:00 +01:00
Paul Licameli
eef2669abd
One less indirection accessing containers in Importer
2016-08-11 11:51:33 -04:00
Paul Licameli
8226441210
use vector of smart pointers to ExtImportItem objects
2016-08-11 11:51:33 -04:00
Paul Licameli
28f0b11376
Use arrays of smart pointers to import plugins
2016-08-11 11:51:33 -04:00
Paul Licameli
7d89e5ff68
Pass containers by ref to import plugin factories, use STL idiom
2016-08-11 11:51:33 -04:00