1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-25 16:48:44 +02:00

37 Commits

Author SHA1 Message Date
v.audacity
6f50a64050 comments, cleanup 2012-07-19 23:42:47 +00:00
martynshaw99
ffea5a2273 Addressing one of the problems reported with 'Normalise' if the offset is greater than the signal. Comments on other possible problems. 2012-04-23 23:39:36 +00:00
james.k.crook@gmail.com
dd97cae3d9 Removed some (hidden) Cleanspeech cruft that had been used to disable effects. Made some static text open to translation. Added more i18n hints (thanks Thomas Breinstrup). 2012-04-05 11:21:15 +00:00
mchinen
57694a2449 Sequence.cpp: Convert all blockfiles types including aliases in ConvertToSampleFormat 2012-03-01 04:18:32 +00:00
v.audacity
d3513320d6 fix for typo on prev commit 2012-03-01 02:56:41 +00:00
v.audacity
b45d4dd998 further fix for additional P1 "repeatable crash set format to 16-bit..." thread, Gale's msg of 2012-02-29 2012-03-01 02:11:09 +00:00
v.audacity
01aeba01c1 fix for additional P1 "repeatable crash set format to 16-bit..." thread, Gale's msg of 2012-02-29 2012-03-01 00:47:46 +00:00
v.audacity
c699aa601d fix for P1 "repeatable crash set format to 16-bit..." thread 2012-02-29 04:16:08 +00:00
v.audacity
1f688cfb85 Failsafe against null dereferences if SeqBlock* has a null f. 2012-02-29 00:45:36 +00:00
v.audacity
5f5b9778de Fixes per Vigilant Sentry (http://www.vigilantsw.com/)
* Fix memory leaks.

* Add comments about initializations and checking for successful results.

* Add checks for NULL deref.

* Consistency in "TODO" vs "TO-DO" comments!
2012-02-08 05:09:14 +00:00
martynshaw99
d28404a3b6 Removing too stringent Asserts - the Sequence::GetRMS code is set up to find the rms of a number of samples > than a block length. 2012-01-11 00:28:22 +00:00
v.audacity
17083dffa5 (bug 451, p2) A bit more work on what I committed yesterday. 2011-12-03 01:27:13 +00:00
v.audacity
2f043dfb0f (bug 451, p2)
Correct Sequence::ConvertToSampleFormat() errors resulting in wrong block file sizes, per offline discussions with Martyn and James.

In WaveClip::ConvertToSampleFormat(), distinguish between failure and no change.

Changed deprecated calls to wxArray::Count() to GetCount(),

In Sequence::Blockify(), no reason to call Alloc() if we know we have no samples, so rearranged that code.
2011-12-02 06:54:52 +00:00
v.audacity
6f768cb889 (bug 451, p2) When I made the change to actually enforce the bounds on sampleCount s (i.e., [0, mNumSamples]), I used the test from the old (2002!) code. But the test on the upper limit was wrong -- the second test should have been >, not >=, because if (s == mNumSamples), there's no point in setting s to mNumSamples. This fired the new assert when s and mNumSamples are both 0. Fixed it to check >. 2011-11-20 19:28:45 +00:00
v.audacity
8cc8a275f8 (bug 451, P2)
Changes per Martyn's suggestion (http://bugzilla.audacityteam.org/show_bug.cgi?id=451#c24), i.e., deal with sample format mismatch in WaveClip::Paste() and Sequence::Paste().

Also add error checking for bad s parameter values passed to Sequence::Paste().
2011-11-20 03:46:00 +00:00
v.audacity
458152070e Fix some problems with asserts in 11308. Further wording corrections. 2011-11-18 03:47:43 +00:00
v.audacity
59db8d4ad4 See http://bugzilla.audacityteam.org/show_bug.cgi?id=451#c31 and http://bugzilla.audacityteam.org/show_bug.cgi?id=451#c32. 2011-11-16 05:59:48 +00:00
martynshaw99
8adac0ed64 Remove spurious ASSERT, Sequence::GetMinMax iterates over each of the blocks that go to make up the len. 2011-11-07 00:01:30 +00:00
v.audacity
4038f214cd (bug 451, p2) Add some asserts against mMaxSamples. In Sequence::Paste(), correct var largerBlockLen declaration to be sampleCount, not the smaller int, that can overflow on comparing to sampleCount and add log error msg. Add alert dialog, log warning, and limitation in Sequence::WriteXML() if mMaxSamples exceeded. Obviate EnvPoint::WriteXML(), unused. A few comments on some "TODO" comments. Make DirManager::WriteXML() fail in debug mode, as it should not be called. 2011-11-01 04:39:14 +00:00
v.audacity
a0db986d56 More detail in log message about Sequence with len > mMaxSamples. 2011-10-16 23:15:28 +00:00
v.audacity
5bb7d0ec84 This should fix the additional build problem Steve reported. 2011-10-16 22:16:24 +00:00
v.audacity
de54ae309d This should fix r11279 build problems on Linux. 2011-10-14 04:36:40 +00:00
v.audacity
1f352b0157 (bug 451, P2) Add more error checking and increase specificity of Sequence-reading code.
Add wxLogWarning messages to AudacityProject::OpenFile()

Fixed correction for "A linked track's partner should never itself be linked" to remove the link from the partner, not the original (left).

Fix possible NULL pointer dereference in previous commit.
2011-10-13 22:52:55 +00:00
v.audacity
5697e39ec0 (bug 451, P2) Improve specificity of one of the "Gap detected..." messages, so it includes blockfile name and extension if possible. Also changed some wxLogError calls to wxLogWarning, as the plan is to handle them rather than fail the load.
Also made the "...will not be loaded" messages in LoadModules.cpp consistently use wxLogError.
2011-10-12 23:17:40 +00:00
v.audacity
4d1e18d8fd In DirManager.cpp, probably fixed bug 451, by not deleting over-long blockfile.
Made Sequence::HandleXMLEndTag log errors more specific.

Differentiated "Gap detected in project file" error messages.
2011-10-12 05:40:23 +00:00
v.audacity
caf33fc995 Clarify some comments, in figuring out the cause of bug 451 (p2). 2011-10-10 21:26:35 +00:00
v.audacity
3a1d4334f2 Make wxLog* calls consistently not have \n at the end. Turn some wxLogWarning calls to wxLogError. Put some periods at the ends of sentences. 2011-10-09 21:14:03 +00:00
v.audacity
f2b02294b6 Fix memory leaks. 2011-09-29 22:10:42 +00:00
v.audacity
6eb3a524be [bug 451] Notify on the error where "len" tag (which is still valid, not legacy) for a "waveblock" is greater than mMaxSamples (max samples per block). 2011-09-29 01:48:56 +00:00
martynshaw99
605c2b156b Revert r11264 since it prevents more than one simpleblockfile per project (see http://bugzilla.audacityteam.org/show_bug.cgi?id=451#c9 but ref 11264, not 11267).
Add an assert on writing over-long sequences (there may be more places this should be done).
2011-09-26 23:36:07 +00:00
v.audacity
8e2ef8f986 bug 451 (P2, http://bugzilla.audacityteam.org/show_bug.cgi?id=451) Failsafe read of "numsamples" tag value > "maxsamples" tag value. It's now recognized as an error in .aup data. 2011-09-21 06:04:10 +00:00
martynshaw99
dde3c0e4cc Move memory allocation to where it's needed, at the request of Ed. No functional changes. 2011-07-28 23:02:53 +00:00
v.audacity
ec047e7c71 (bugs 20 and 137, P2) Working on these bugs, tightened up some code and corrected some comments. 2010-09-23 00:30:05 +00:00
BusinessmanProgrammerSteve
c046a80562 Fix random typo (extra backslash) in Sequence.cpp causing warning 2010-09-10 06:01:10 +00:00
v.audacity
f9be883b82 Made requests for bug reports consistently go to feedback@audacityteam.org and compile issues go to "Compling Audacity" board on the Forum rather than going to -devel. Removed some related code cruft. 2010-09-10 03:19:24 +00:00
v.audacity
8f8504b5a6 some progress on bug 113, including rewordings DependencyDialog based on some suggested by Gale
code cleanup

naming improvements for clarity (e.g., aliasedFileName instead of aliasedFile for an instance of wxFileName -- it's not an instance of AliasedFile)

parens, not square brackets, for parenthetic phrases
2010-07-28 23:06:10 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00