1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-24 16:38:07 +02:00

1934 Commits

Author SHA1 Message Date
Leland Lucius
d2b4a0e488 AUP3: Put checkpointing in a separate thread
This is highly experimental.  It's defers most checkpointing
to a separate thread to see if we get better throughput and
less choppiness when applying effects.
2020-07-19 03:28:02 -05:00
David Bailes
c174b254a1 Bug 2487 - Playback meters and preview of non-real-time effect
Problem:
Playback meters do not respond during preview of non-real-time effect.

Commit ba6db6e added the meters into AudioIOStartStreamOptions.
However Effect::Preview(bool) was not modified to set the playback meter.

Fix:
In Effect::Preview(bool), use DefaultPlayOptions, which includes a playback meter.
2020-07-16 14:41:48 +01:00
Leland Lucius
5b41115bd0 AUP3: Mostly rework of CopyTo()
It now uses VACUUM INTO instead of the SQLite backup API
in hopes that the copies will be smaller. And VACUUM INTO
is "supposed" to be faster, but time will tell.  It's easy
to put the backup API usage back in.

This also fixes a bit I missed with redoing the orphan block
handling that was reported by Paul.

And finally, it renames the AutoRecovery.cpp/.h files and AutoSaveFile
class to ProjectSerializer since the AutoSaveFile class is being
used for regular project documents now and it doesn't write to a
file anymore.

If anyone has a better idea for a name other than ProjectSerializer
feel free to change it.  I hate naming things.
2020-07-10 00:50:52 -05:00
David Bailes
5b4c9b3425 Bug 2498 - Loudness Normalization always displays LUFS on launch
Problem:
On opening, the units were always LUFS, and the "treat stereo as dual-mono" check box was always available.

Fix:
On opening, adjust the controls which depend on the value of the Normalize choice.
2020-07-09 15:48:01 +01:00
Paul Licameli
88ba35f520
Fix exception handling, as when trying to edit read-only database... (#607)
... Problem is that the delayed undo handling (in the lambda in AudacityApp ::
OnExceptionInMainLoop) should itself have only non-throwing steps.

But there was a redundant attempt at autosaving in ProjectHistory ::
RollbackState, which itself requires another data base write.

But when "rolling back" the in-memory structures to whatever the current state
of undo history is, we can assume that any required autosave was completed
before the current state of undo history was set.

So for rollback only, do not autosave again when discarding changes and
restoring the state.  (But do it still, throwing on failure, when moving around
in the undo history, among saved states.  We do want to keep the last autosave
consistent with the in-memory state.)
2020-07-08 00:44:41 -05:00
Leland Lucius
d39590cf41 AUP3: First round of updates
!!! THERE WILL NO DOUBT BE BUGS !!!

This is a big one and there's still several things to
complete. Just want to get this in the wild to start
receiving feedback.

One big thing right now is that it will NOT load pre-aup3
files.  An importer is on the way for that.
2020-07-01 02:30:18 -05:00
Leland Lucius
cbf1bb558e AUP3: Removes OD code related to project file handling
This removes all of the OnDemand code embedded throughout
    the main codebase. Individual files related specifically
    to OD have been left in place, but removed from the build.
2020-07-01 01:14:05 -05:00
Paul Licameli
e4260e2e95 virtual dtors should be non-inline 2020-06-14 21:00:06 -04:00
Leland Lucius
87cae3f0c8 Mac: AudioUnit effects are not applied if you initially use the preview 2020-06-14 13:58:30 -05:00
Paul Licameli
3869a8f460 Remove allegro.h from other headers 2020-06-14 10:32:16 -04:00
Paul Licameli
a7408a7f80 Remove TimeWarper.h from other headers 2020-06-13 11:22:41 -04:00
Paul Licameli
1bce7c1979 Disambiguate "Silence" 2020-06-06 15:14:42 -04:00
Paul Licameli
782ef138e0 Bug2431 residual: Restore commit 5e8cfb0...
... as urged by Leland.  It is really needed for a more complete fix.

This reverts commit 9894abc4f4477dee88022415a919adcfe96e2e80.
2020-06-06 14:59:32 -04:00
David Bailes
13ec3300a9 Bug 2471 - Mix Stereo down to Mono fails if space at start of track
Fix:
In the constructor for Mixer, the start and end times should be in seconds, not sample numbers.

Also fixed in passing, in computing end time of a track, the max of the two channels should be used, rather than the min.
2020-06-05 14:33:45 +01:00
James Crook
296a9a2291 Bug 2468 - Python scripting of Nyquist effects must set ALL parameters, or all parameters are ignored.
My code is for normal Nyquist effects.  This fix also incorporates a fix from Leland for Nyquist Prompt.  Thanks Leland.
2020-06-03 12:45:15 +01:00
Paul Licameli
3646bb8afe Bug2431: Enable checkbox for ALL realtime effects should work...
... not just for AudioUnits, but also WahWah, VST, etc.
2020-05-29 20:54:45 -04:00
Paul Licameli
c973f0d8ed Do restore a piece of 5e8cfb0c5adf9b3f917123e4d04d00423206d7d5...
... to initialize a variable
2020-05-29 20:54:45 -04:00
Paul Licameli
9894abc4f4 Revert "Bug 2431 - Mac: Real-time effects - Enable checkbox has no effect"
... so I can make a more general fix, for more than only AudioUnit effects

This reverts commit 5e8cfb0c5adf9b3f917123e4d04d00423206d7d5.
2020-05-29 20:54:45 -04:00
James Crook
637712489f Bug 2428 - Nyquist Effects do not display a Progress Dialog if run from a Macro. 2020-05-29 21:54:18 +01:00
Paul Licameli
9360359e9d
Module manager (#549)
* Eliminate ModuleManagerInterface...

... It was there only to provide RegisterModule(), but that was not used
anywhere.  So simplify.

* Remove nested #include of ModuleInterface.h
2020-05-29 10:48:52 -05:00
Paul Licameli
e9f63d43d1 Contexts & i18n-hints suggested by Joachim Huffer (thanks!) 2020-05-28 16:34:00 -04:00
Paul Licameli
f3d91f488e Remove extern declarations from .cpp files...
... Require the declarations to be in .h files, to be sure graph.pl detects the
dependencies.

Only one more #include was needed in Nyquist.cpp.   This doesn't reveal any
more hidden cycles.
2020-05-28 05:50:25 -04:00
Paul Licameli
fa4d35296e AllThemeResources.h has a .cpp & doesnt include Theme.h...
... (it used to, via MacroMagic)

This splits a cycle of 8 into 6 + 1 + 1
2020-05-28 05:50:24 -04:00
Paul Licameli
4ff0a9d74e Can build for windows without precompiled headers...
... Requires some more wx header inclusions, a renaming of CopyFile (to avoid
colliding with a certain macro changing it to CopyFileW), and an explicit
deletion of a copy constructor and assignment (to avoid generation of
std::vector members for an incomplete type)
2020-05-27 17:36:25 -04:00
Paul Licameli
83d5c81578 Change a function return from wxString to TranslatableString 2020-05-26 12:04:11 -04:00
Leland Lucius
5e8cfb0c5a Bug 2431 - Mac: Real-time effects - Enable checkbox has no effect 2020-05-25 18:27:46 -05:00
Paul Licameli
7fbfc2b292 Finish the job of 30dbdf4, deleting abandoned source files...
... And correcting #include paths, and removing mentions in read-me files, and
correcting CMakeLists.txt
2020-05-25 17:21:05 -04:00
Paul Licameli
95195a783f Enable optional context arguments for i18n in Lisp 2020-05-24 14:55:08 -04:00
Paul Licameli
67ce74d5ef Some example uses of XC and XPC...
... Really needed only for "White" but harmless in the other uses.  Also more
i18n-hint comments.

There may be need to disambiguate other strings.
2020-05-24 14:55:08 -04:00
Paul Licameli
6beeb86a6a Nyquist can still parse the older format for file controls 2020-05-24 12:22:40 -04:00
Paul Licameli
55c5a5f692 Allow continuations of Nyquist control lines either with $ or with ; 2020-05-24 12:20:46 -04:00
Leland Lucius
fadc024432 Initial changes to build against wx313 2020-05-23 13:08:21 -05:00
Paul Licameli
7cf9263889 Simplify Loudness effect UI with a notebook...
... so that we don't need to recreate the validators and change label texts
after constructing the dialog.

This eliminates 4 uses of macro _ .
2020-05-23 13:56:39 -04:00
Paul Licameli
63c49db0ce Don't internationalize logged strings; -29 macro _ calls 2020-05-23 08:07:24 -04:00
Paul Licameli
db690d94f7 Remove 27 various macro _ ...
... and supply a few missing translations in Dependencies.cpp

And substitute-don't-concatenate in a few places in Internat.cpp
2020-05-23 08:07:24 -04:00
Paul Licameli
7fb4652c88 Remove some unused functions and forward declarations 2020-05-23 05:16:59 -04:00
Paul Licameli
c941647db6 Replace last wxProgressDialog with ProgressDialog; remove all wx/progdlg.h 2020-05-22 20:44:08 -04:00
Paul Licameli
f1ae8109ee Internationalize file type choices for Nyquist as we do in C++ ...
... That is, present translators with msgids containing only the descriptions
of the file types.  No punctuation.

This eliminates the last wxFileDialog, replacing it with FileDialogWrapper.
2020-05-22 20:34:42 -04:00
Paul Licameli
3542eb4ca0 Replace wxFileDialog with FileDialogWrapper in two places 2020-05-22 20:19:02 -04:00
Paul Licameli
c44ae15a4d Remove inclusions of wx/filedlg.h 2020-05-22 20:18:51 -04:00
Paul Licameli
c63cbf01eb Be careful of static initialization of arrays of FileType 2020-05-22 20:14:02 -04:00
Paul Licameli
4d09705a73 Change XO to XXO in many more places, with no effects at all...
... because the two macros have the same expansion, and are both checked for
in the --keyword arguments passed to msgfmt by locale/update_po_files.sh.

This commit makes ONLY such changes, and comments in Internat.h.  It is big
but quite harmless.

The intention is to introduce a type distinction in a later release, by defining
XXO differently.  XXO is used where & characters in strings (for hotkeys of menu
items or control prompts) are permitted, XO where not.
2020-05-22 13:07:50 -04:00
Paul Licameli
5cef2cd3e4 Remove a few macro _ 2020-05-22 13:07:49 -04:00
Paul Licameli
d22b650e6a Fix two typos for translated strings, now that strings are unfrozen...
... See commit 97fba037a43ef57ecedc89ac24846a639caaca98.
2020-05-22 12:48:49 -04:00
Paul Licameli
f8a070dde7 Rename macro wxPLURAL as XP (brief, and eliminates mention of "wx") 2020-05-22 12:48:49 -04:00
SteveDaulton
29d1a7b7b1 Fix bug 2392
Commit 66fd95f3d6da21 reverted.
2020-04-20 11:26:57 +01:00
Paul Licameli
106119cb28 Make a scale factor in Compressor like all other scale factors...
... Multiply by it before putting value TO the slider.  Divide by it taking the
value FROM the slider.
2020-04-19 21:07:51 -04:00
Paul Licameli
ee797f59de Fix bug in effect presets dialog...
... introduced at 46e99bb038b7619970ff99578f656c5f6cc80996
2020-04-18 22:31:51 -04:00
Leland Lucius
e8f9f4a7e9 Bug 1336 - Tracks -> Mix Stereo to Mono ignores envelope 2020-04-17 14:52:31 -05:00
Leland Lucius
a6d0b3f902 Bug 2360 - Scripting: "Message:" command may crash when using Nyquist with Python 2020-04-16 22:14:45 -05:00