1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-18 17:10:05 +02:00

19 Commits

Author SHA1 Message Date
Daniel Winzen
428f5c8391 Fix 3 uninitialized variable uses 2015-04-30 09:06:37 +02:00
david avery
0319f6ea51 merging wx3 changes 2015-04-12 23:52:32 -06:00
james.k.crook@gmail.com
8a9987a0d9 From: martin@steghoefer.eu [PATCHES 02-15 of 15] Fix runtime problem with wxWidgets 3.0:
Correct string formatting for:
2/15  %d + enum => %d + int
3/15  %lld + int64_t => %lld + long long
4/15  %d + int64_t => %lld + long long
5/15  %d + double => %f + double
6/15  %d + int32_t => %d + int
7/15  %d + intptr_t => %p + void*
8/15  gint, guint
9/15  %d + long => %ld + long
10/15 %n + int => %d + int
11/15 %x + int => %x + unsigned int
12/15 %f + int => %d + int
13/15 %S + wxChar* => %s + wxChar*
14/15 %d + size_t => %d + int
15/15 %d + size_t => %lld + long long

"The functions wxString::Format, wxString::Printf (and others indirectly) have become stricter about parameter types that don't match (format specifier vs. function parameters). So the bugs (that were already present in audacity before) become visible in wx3.0 as error message dialogs. I've checked all occurrences of Printf, wxPrintf, PrintfV, Format, FormatV, wxLogDebug and wxLogError systematically and made the type match."

Note (9/15): In TrackPanel.cpp, ExportMP2.cpp and CompareAudioCommand.cpp this patch supersedes related change done in r13466 because the new solution requires fewer casts and therefore simplifies the code.

Note: Many .po files are affected, and we need to be very careful about this.  Incorrect "%d" and similar in translation files may lead to crashes in those languages (only).  This is something we should actually have been more careful about in the past.  We need to write a script to check that the "%d" and similar format specifiers match between English and translation.
2014-11-08 16:42:34 +00:00
v.audacity
d906d5c788 modified version of David Bailes's patch for Bug 710 - Keyboard Preferences: don't match single characters in modifiers in Key View search 2014-08-01 19:58:47 +00:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
v.audacity
fc6e4a4cba Fix some compiler warnings. 2013-12-13 01:24:47 +00:00
lllucius
be409578aa (Hopefully) Improve name and key views for NVDA and Window Eyes 2013-11-06 21:11:21 +00:00
lllucius
98db19cc89 Improve accessibility of KeyView. 2013-11-06 05:35:18 +00:00
lllucius
398b5153c7 Fix a few accessibility issues pointed out by David. 2013-10-30 20:44:22 +00:00
lllucius
61f8e16026 Make sure columns are full width for key and name views. 2013-10-06 07:37:26 +00:00
lllucius
7f8152ff49 Due to the last change (different filter behavior based on view type), KeyView
now needs to protect itself from residual line numbers and selection.
2013-10-06 06:25:34 +00:00
lllucius
83a12b3507 Can't set the brush before selecting the bitmap...DOH! 2013-10-05 02:38:12 +00:00
lllucius
1898cd6349 In tree view, search label and key.
In name view, search label.
In key view, search key.
2013-10-04 03:15:51 +00:00
lllucius
7e8d9b104a Change the value reported by accessibility to be view specific...DOH!!! 2013-10-03 15:04:07 +00:00
lllucius
98aa84e9f8 Have screen readers say full label, not just the menu item. 2013-10-02 17:42:51 +00:00
lllucius
3d0bbdf787 Fix off by one in accessibility.
Fix moving to next entry when pressing a key.
Fix hotkey edit box not accepting "RETURN" key
2013-10-02 16:36:53 +00:00
lllucius
856c51e6a6 Okay, let's try this again. Now there's only a type of external index...none of
this "use aline index here and a node index here" stupidity.
2013-10-02 08:17:16 +00:00
lllucius
39e7b3e08f Adds access keys
Saves view type
Defaults to fully expanded upon entry
Live search...may need to adjust the timer
Uses black on white for the icon (should? fix assertion on Linux hopefully)

(will do more a bit later)
2013-10-02 00:05:39 +00:00
lllucius
b0e65b57c2 Adding EXPERIMENTAL_KEY_VIEW that provides a new keyboard binding view. 2013-10-01 06:00:13 +00:00