- Dead code from experiments in SelectionBar removed.
- Many warnings about unused parameters fixed with WXUNUSED()
- Many warnings about signed / unsigned comparisons cleaned up.
- Several 'local variable declared but not used' warnings fixed.
... The keys are only ever used as internal identifiers in wxConfigFile
objects. So they are often space-less and camel-cased.
I have noticed a couple instances of translators confused by these.
"seconds" and "Output" are translated elsewhere, so just add _
New string _("%") will simply go through untranslated for now but can be in next
version's audacity.pot
... "Light" was used in two different meanings, but one place was the obsolete
Leveller effect, whose code is removed now. (I leave the files in place, to
make it easier for the curious to know it was once there, and find its history.)
i18n-hints added for the surviving use of "Light" to name a theme, and also for
some of the other themes.
... including titles of dialogs,
messages,
About sub-menu of the Manage button,
long-form names of Undo items (in history view),
message for why command is not allowed when there is no selection
Also one place in Effect Rack code but it's commented out
... Although "Nyquist" is a proper name, still, translators should have
discretion to transliterate it into another alphabet, and also make it
consistent with longer translated strings containing it.
Not so for debug messages mentioning actual keywords of Nyquist programming.
... but bringing back some naked calloc and free that weren't replaced quite
right, and I'll figure out why later.
This reverts commit e94fa1d65e5555b78cae164f7b9ca5a6f363d8b8.
This reverts commit 0c7e467a081fb998d183bdc169cd8ddd69648b25.
Previously this was hard coded to use the online alphamanual.
Some other help-on-errors paths were hardcoded to use the online manual, and did not use local help even if available, so these were changed too.
Also two naming changes in the code:
ShowHelpDialog() became ShowHelp() because it typically shows the help in your browser, only showing the help in a dialog under certain circumstances.
The helpURL parameter became helpPage since it is usually a page name that is then elaborated into a url.
The Link() function became InnerLink().
Some careful http -> https changes made too.
