Paul Licameli
4ff0a9d74e
Can build for windows without precompiled headers...
...
... Requires some more wx header inclusions, a renaming of CopyFile (to avoid
colliding with a certain macro changing it to CopyFileW), and an explicit
deletion of a copy constructor and assignment (to avoid generation of
std::vector members for an incomplete type)
2020-05-27 17:36:25 -04:00
Paul Licameli
eb3e5d8f6f
Factor EffectUIHost::Initialize
2020-01-23 19:06:23 -05:00
Paul Licameli
e5625bfb89
Move EffectDialog out of Effect.cpp
2020-01-23 15:23:43 -05:00
Paul Licameli
723c5256c0
Don't call GetActiveProject when constructing EffectUIHost...
...
... relying on guarantees in the previous commit
2020-01-06 11:30:47 -05:00
Paul Licameli
bb26b2f2c4
Require a ProjectWindow as ancestor of effect dialog...
...
... by passing parent as reference, not pointer, and testing in the dialog
factory function.
This is important so that we know the lifetime of an effect dialog, even when
it is non-modal, is bounded by the lifetime of the associated project.
2020-01-06 11:30:47 -05:00
Leland Lucius
2803bc30a6
Fix Windows build
...
2>c:\users\yam\documents\aud\audacity\src\effects\effectui.h(215): warning C4099: 'CommandContext': type name first seen using 'class' now seen using 'struct'
...
2>BatchCommands.obj : error LNK2019: unresolved external symbol "bool __cdecl EffectUI::DoEffect(class wxString const &,class CommandContext const &,unsigned int)" (?DoEffect@EffectUI@@YA_NABVwxString@@ABVCommandContext@@I@Z) referenced in function "public: bool __thiscall MacroCommands::ApplyEffectCommand(class wxString const &,class TranslatableString const &,class TaggedIdentifier<struct CommandIdTag,0> const &,class wxString const &,class CommandContext const &)" (?ApplyEffectCommand@MacroCommands@@QAE_NABVwxString@@ABVTranslatableString@@ABV?$TaggedIdentifier@UCommandIdTag@@$0A@@@0ABVCommandContext@@@Z)
2>PluginMenus.obj : error LNK2001: unresolved external symbol "bool __cdecl EffectUI::DoEffect(class wxString const &,class CommandContext const &,unsigned int)" (?DoEffect@EffectUI@@YA_NABVwxString@@ABVCommandContext@@I@Z)
2>TrackMenus.obj : error LNK2001: unresolved external symbol "bool __cdecl EffectUI::DoEffect(class wxString const &,class CommandContext const &,unsigned int)" (?DoEffect@EffectUI@@YA_NABVwxString@@ABVCommandContext@@I@Z)
2>C:\Users\Yam\Documents\aud\audacity\win\Debug\Audacity.exe : fatal error LNK1120: 1 unresolved externals
2020-01-06 00:00:14 -06:00
Paul Licameli
91c45dd32a
Move static EffectManager::DoEffect into new namespace
2020-01-05 16:11:55 -05:00
Paul Licameli
23a0206d2a
Remove CreateUI; pass dialog factory to effect client instead
2020-01-05 16:11:55 -05:00
Paul Licameli
8c4d8db133
Move classes EffectUIHost and EffectPanel to EffectUI.cpp
2020-01-05 16:11:54 -05:00
Paul Licameli
91536d734f
Rename EffectRack.* as EffectUI
2020-01-05 16:11:54 -05:00
