1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-20 17:41:13 +02:00
Commit Graph

7872 Commits

Author SHA1 Message Date
Max Maisel
d9608cddea Implement perceived loudness normalization in new Loudness effect. 2019-11-22 19:42:33 +01:00
Max Maisel
8555018bd4 Implement EBUR128 integrative loudness class. 2019-11-22 19:42:33 +01:00
Max Maisel
a94cda94ae Create empty EBUR128 class.
This class will contain all EBU-R128 related analysis code.
Add all new files to all build systems as well.
2019-11-22 19:42:33 +01:00
Max Maisel
d8424755d1 Add buffer handling and flow control code to new Loudness effect.
Currently, the effect still does nothing.
2019-11-22 19:42:33 +01:00
Max Maisel
c002165952 Add EBU R128 k-weighting filter implementation to Biquad. 2019-11-22 19:42:33 +01:00
Max Maisel
c3d25cfb44 Remove all Loudness related code from Normalize effect. 2019-11-22 19:42:33 +01:00
Max Maisel
e439e8f4c7 Consistently use double within Biquad filter coefficient calcultations.
This avoids catastrophic rounding errors which can even lead to filter
instability in some cases. This is a real problem in the coming IIR envelope
detector.
2019-11-22 19:42:33 +01:00
Max Maisel
86ae0460c9 More Biquad refactoring. 2019-11-22 19:42:32 +01:00
Max Maisel
064ddb5a54 Refactored filter calculation out of ScienFilter into Biquad.
This allows easy code reuse in other effects.
2019-11-22 19:42:32 +01:00
Max Maisel
6da48db127 Start work on new Loudness effect
This is based on my old loudness effect prototype which was included
in the Normalize effect.

Create all source files and add them to all build systems.
Currently, the effect only consists of a GUI mockup.
Create Octave+mod-script-pipe based dummy unit-test as well.
2019-11-22 19:42:32 +01:00
James Crook
008d8d8c8c Set BUILD_LEVEL 2, ready for release. 2019-11-15 11:14:55 +00:00
Paul Licameli
eb2161d3aa Fix (again) TAB key navigation to graphic EQ sliders on Mac...
... original fix was at c8d95e1

regression was at 3e98a10
2019-11-14 23:28:15 +00:00
David Bailes
185d555fc6 Bug2239: Windows, accessibility problem when TrackPanel regains focus
Problem:
When the TrackPanel regains focus, screen readers do not read the track name.
Introduced by the commit: acfd2b70

Fix:
Change TrackPanel::SetFocusedCell() so that it actually sets the focus, rather than just getting it :)

Note: this also fixes bug 2238
2019-11-13 16:49:02 +00:00
SteveDaulton
3c5906193b Fix bug 2233, First effect group incorrectly named 2019-11-12 19:46:55 +00:00
James Crook
eb00470042 Bug 2231 - Graphic Eq may create wrong effect 2019-11-08 20:12:13 +00:00
Paul Licameli
e96c213f4b Fix missing Spanish language choice on Linux...
... Don't modify a hash table (with operator []) while iterating it!
2019-10-24 15:31:24 -04:00
SteveDaulton
e9c8438d2d Fix for bug 2230 - Audacity crashes on selecting Resample
See https://bugzilla.audacityteam.org/show_bug.cgi?id=2230
2019-10-24 13:27:29 +01:00
Paul Licameli
cfbffe6d54 Bug 2228: crash closing, only Linux, gcc, opt, wxWidgets 3.0...
... Not the most satisfactory fix, but in fact no dangling pointers will
happen with the code we have now, because the relevant windows are all destroyed
only at the end of AudacityProject's lifetime, including the non-modal windows
(macros, history, lyrics, mixer board, plot spectrum, and contrast) which
are hidden and shown again, not destroyed and recreated, when dismissed and
reopened.

To do:  figure out how to make wxWeakRef work on that combination without
crashing.
2019-10-17 17:07:37 -04:00
ajkenny122
f5a6a02da0 Update audacity.desktop.in
Korean translation has been added.
(ko)
2019-10-07 10:39:48 +01:00
David Bailes
cff0011ee4 Bug 2225 - No error message when trying to delete with no selection
The problem only applies to the delete on the edit menu (ctrl+k), pressing delete or backspace work.

Fix: add a couple of missing flags.
2019-10-05 10:17:58 +01:00
James Crook
85a3e9880c Bug 2052 - Remove lock file, even if read only
The line breaks in the second message are also changed.
They are not changed in the first message, as that message is already translated.
2019-10-04 11:31:23 +01:00
James Crook
3bce6f1c21 Raise splashscreen at start up. 2019-10-03 20:24:06 +01:00
James Crook
98f495a485 Bug 2052 - Mac: Lock file prevents launching Audacity
This ameliorates the problem, by prompting the user telling them the lock file
location.  It does not fully solve it, but should allow us to reduce the bug to P2.
2019-10-03 17:19:32 +01:00
Leland Lucius
5955dbc752 Possible fix for bug #590
This change reduces the risk of LADSPA plugins referencing
Audacity symbols by using the RTLD_DEEPBIND flag when loading
the plugins.

It also addresses an issue specific to the "blop" plugins where
they load their own libraries (without RTLD_DEEPBIND).

A much better solution would be to change Audacity's default
symbol visibility to "hidden" which would expose ONLY symbols
specificially marked as visible.
2019-10-02 10:17:00 -05:00
David Bailes
9e51dba3db Bug 2215 - Cut does not work when in Pause mode
In bool MenuManager::TryToMakeActionAllowed(), there's the condition:
(MissingFlags & enabler.possibleFlags()) == MissingFlags

that is, the missing flags has to be a subset of the possible flags.
For cut in pause mode, this condition is not met for the enabler stopIfPaused, because MissingFlags also includes the CutCopyAvailableFlag, which is not one of the enabler's possible flags.
It is not sensible for the missing flags to have to be a subset of the possible flags, because for this to work, for each enabler the possible flags would have to include other flags that could need fixing by other enablers.

Fix:
1. Change the condition to the intersection of the missing flags and possible flags is non-empty.
2. In CutCopyAvailableFlag, remove the condition !AudioIOBusyPred(). If this is present, then due to the first change, paused audio could cause all audio to be selected even when there was a selection. The commands for which this flag is used are cut and copy, and they already have AudioIONotBusy flags, so this change should not affect previous behaviour.
2019-10-02 10:39:15 +01:00
David Bailes
b06af2330b Revert "Bug 2215 - Cut does not work when in Pause mode"
This reverts commit 458d92157a.

The fix caused another bug: when paused, with select all enabled, all audio was selected.
2019-10-01 15:19:11 +01:00
David Bailes
458d92157a Bug 2215 - Cut does not work when in Pause mode
In bool MenuManager::TryToMakeActionAllowed(), there's the condition:
(MissingFlags & enabler.possibleFlags()) == Missing

that is, the missing flags has to be a subset of the possible flags.
For cut in pause mode, this condition is not met for the enabler stopIfPaused, because MissingFlags also includes the CutCopyAvailableFlag, which is not one of the enabler's possible flags.
It is not sensible for the missing flags to have to be a subset of the possible flags, because for this to work, for each enabler the possible flags would have to include other flags that could need fixing by other enablers.

Fix: change the condition to the intersection of the missing flags and possible flags is non-empty.
2019-10-01 13:56:33 +01:00
David Bailes
6b2785b625 Revert "Bug 2215: Cut does not work when in pause mode"
This reverts commit 6a37cbae35.

This was reverted because it caused bug 2221.
2019-09-30 12:57:31 +01:00
David Bailes
6a37cbae35 Bug 2215: Cut does not work when in pause mode
Minor fix to logic required.
2019-09-23 12:31:05 +01:00
James Crook
cabe925ab7 Make exporting of Soloed Tracks WY(S/H)IWYG
Now the export (should) exactly match the (selected) non greyed out tracks.
i.e. what you see and hear is what you export - no matter which mode of
mute/solo you choose.

This is now applied not just to export but also to export multiple.
2019-09-08 14:22:40 +01:00
Jonatã Bolzan Loss
a77a3ab2ac Fix exporting soloed track 2019-09-05 17:57:57 -03:00
SteveDaulton
5d4c884764 Fix bug 1824
Generate effect preview fails when no selection
2019-09-05 21:01:46 +01:00
James Crook
76d52fdc99 Make Bevel2 widget antialiased
Hat tip to Jonatã Bolzan.
2019-09-05 13:02:31 +01:00
James Crook
fad541e818 Change wordings, (as requested by wiki page). 2019-09-04 20:12:26 +01:00
James Crook
a3eaf7d46e Fix Graphic EQ slider height tiny on Linux.
Thanks to Steve for alerting to the problem.
2019-09-04 20:07:26 +01:00
James Crook
72f36f8a82 Bug 1622 - Cryptic error message when existing project cannot be saved 2019-09-01 15:28:00 +01:00
James Crook
9a3bd94459 Bug 2185 - Import2: Incorrect error message if file not found 2019-09-01 15:11:22 +01:00
James Crook
844778797a Bug 46 - GSM 6.10 files cannot be exported - failure messages are unhelpful un-illuminating 2019-09-01 13:15:13 +01:00
James Crook
1a49d0a812 Bug 59 - Residual. MP2 exporting is broken. So disable it.
This fix also allows for reporting illegal combinations on OK.  However, we don't yet need to use that feature, as the dialog now prevents illegal combinations EVEN when you use 'Show all Codecs'
2019-09-01 13:13:20 +01:00
Paul Licameli
15fa593906 Remove a comment 2019-08-31 23:21:07 -04:00
David C. Manuelda
aab48c58f0 Ensure EXPERIMENTAL_MIDI_OUT is not defined if midi is disabled 2019-08-30 20:51:01 +01:00
James Crook
fe3a866117 Bug 2077 - Residual: Original code was correct for Windows
If new code is used on windows, we get an assert.
2019-08-30 19:00:37 +01:00
James Crook
9e69be9f6f Bug 2182 - Updating Audacity can cause messed up toolbar layout 2019-08-30 09:28:26 +01:00
Paul Licameli
7149d8fcf9 Bug2077: FFmpeg custom options sub-modal dialog should appear foremost 2019-08-28 11:54:17 -04:00
Paul Licameli
fcf4b635d3 Fix line continuation (don't leave a space after \) 2019-08-28 11:34:32 -04:00
James Crook
089a7ec166 Bug 59 - No error reported to user and crash when FFmpeg attempts invalid custom export of WAV with mp2 codec
If one selects fmt wav in FFmpeg options, only legal exports are now available.
2019-08-28 13:14:14 +01:00
Alexander Tsoy
7a91b6c5e9 Fix compilation without USE_MIDI 2019-08-28 00:17:39 +03:00
James Crook
45ddc8c413 Rename EQ effects and lose 'extra knobs'
Team agreed on new names, and to remove redundant controls that are (mostly) just confusing.  Also retired EQ effect.
2019-08-27 19:38:32 +01:00
James Crook
c32b92c377 Bug 2199 - crash after attempting to export as OGG at very high sample rate 2019-08-24 19:13:05 +01:00
James Crook
569028268d Bug 2207 - Filter Curve and Graphic EQ have no factory presets (available in 2.3.2 and earlier) 2019-08-24 13:55:54 +01:00