See original attempt at commit 7ec5fd79df65cd3e54d3d14c52df106d71d06c53
This eliminates the need for a resource file at run-time.
locale/LanguageNames.txt is intended as a "source file" that is infrequently
changed as the set of supported languages changes.
The intermediate step, of appropriately copying that file into the C++ source
code in src/Languages.cpp, was done by hand.
In XCode, I set locale/LanguagesNames.txt and src/Languages.cpp to be
interpreted as Western encoding, and then the copy-paste was easy in the
editor.
The resulting C++ source code file now has string literals that are not 7-bit
ASCII.
This allows us to directly include language name strings in unicode in the file.
The L in the strings ensures wchar_t use.
I've confirmed that this gives the same results visually on Windows,
and that we do get unicode on Linux.
... and similar wx "variadics," which all treat wxString smartly enough that
you don't need this.
Don't need c_str either to convert wxString to const wxChar * because
wxString has a conversion operator that does the same.
... Certain wrappers are put around direct usage of classes like
wxMessageDialog which did NOT localize by default.
Also consistently mention (translated) names of effects in titles of message
boxes that they display.
... I'm not sure how to make it work for AudioUnits, LV2, or Vamp, for which
the API for identifying a plug-in doesn't map straightforwardly to a file name.
This was to work around a bug in MSVC that reports a
bogus warning MSB8012, caused by using an upgraded project.
I also in the process fixed the release build, which was building as debug earlier.
Alerted to this buggy code by Darrell Walisser's comment:
"Whoops, the range on the 64-bit signed integer check is incorrect."
After these fixes, I saw that IsGoodInt was being used to test a dotted
version number, so I commented out that (bogus) test which was previously
always succeeding.
The IsGood{num} functions did no range checking if the numbers were shorter
than the max value. Then, if the number was similar in length, the first digit could
be an invalid character and the code also previously accepted all 9's followed by 1.
My new code would benefit from code review and unit tests.
