Paul Licameli
e7b4d935a5
Hide the use of new in factory functions for BlockFiles
2016-08-16 12:29:59 -04:00
Paul Licameli
2ede67be96
Use type alias for pointer to BlockFile, which is still a dumb pointer
2016-08-16 12:29:59 -04:00
Paul Licameli
46f38708ed
Dir manager uses std::shared_ptr
2016-08-13 12:23:05 -04:00
James Crook
763485b0dc
Add error check comments.
...
These are places where we don't properly handle error returns.
2016-07-10 21:40:48 +01:00
Gale Andrews
7848042339
More friendly warning about overlong Block File
...
Agreed several years ago on http://wiki.audacityteam.org/wiki/Wording .
2016-04-20 17:13:08 +01:00
Paul Licameli
3d102a3390
Access BlockFile::mFileName without copying, with proper multithreading cautions
2016-04-17 13:58:21 -04:00
Paul Licameli
daf92c43f8
Sequence::Copy is a factory returning smart pointer. WaveClip stores it.
2016-04-10 20:47:45 -04:00
Paul Licameli
dfc84d030c
Fix warnings for out-of-order initializers, with in-class member initializers
2016-02-26 14:56:30 -05:00
Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
9bf098c7d9
Sweep unnecessary wxString copies: rest
2016-02-23 02:15:56 -05:00
Paul Licameli
143e3b0ce1
Fix bug in Track > Resample
2016-02-18 08:23:15 -05:00
Paul Licameli
30f161f5c4
Fix bug when Split New with selection that extends past end of track...
...
... but I think there may be some other off-by-one bugs (that existed before my
changes) in treatment of the last sample of a selected range. Need to
look more closely.
2016-02-17 21:45:42 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Paul Licameli
c4657a7b0e
Use [] not at() -- avoid array bounds checking in release build!
2016-02-11 12:36:27 -05:00
Paul Licameli
dd3df60a83
Avoid repeated FindBlock call in Sequence::Get when we can
2016-02-04 09:31:39 -05:00
Paul Licameli
dc599116f7
Use SampleBuffer in Sequence, reuse so there are fewer allocations of buffers
2016-02-04 09:31:38 -05:00
Paul Licameli
ca56876aaf
Various minor fixes in Sequence
2016-02-04 01:06:51 -05:00
Paul Licameli
e6987284e3
Rewrote Sequence::FindBlock, without recursion, and with dictionary search
2016-02-04 00:53:55 -05:00
Paul Licameli
6c28276daf
Use RAII idiom for lock and locking mutex in Sequence
2016-02-04 00:53:54 -05:00
Paul Licameli
13f7d0a81b
Added consistency checks for Sequence, hoisted out of inner loops.
2016-02-04 00:53:27 -05:00
Paul Licameli
7be911b7fb
Simplify the use of Sequence::Blockify()
2016-02-03 22:17:10 -05:00
Paul Licameli
51fbc697cf
One less indirection accessing Sequence::mBlock
2016-02-03 22:17:08 -05:00
Paul Licameli
38ba19183d
One less indirection accessing SeqBlock
2016-02-03 22:17:07 -05:00
Paul Licameli
eaccd490ec
Bug1320: Correct contrast window miscalculations of RMS
2016-01-29 14:18:47 -05:00
Leland Lucius
445dd81b29
Fix format specifier
2015-08-15 17:37:00 -05:00
Paul-Licameli
bdc2839112
Preliminaries for bug 900
...
Create WaveTrackCache as a utility class but don't use it anywhere yet.
The possible minor performance problem with effects is fixed by changes
in WaveTrack::GetBestBlockSize().
2015-05-26 20:02:37 -04:00
James Crook
16fe9af314
Bug 938 - Audio longer than 2^31 sample is visually corrupted.
...
Seems to have been an overflow in GetWaveDisplay().
2015-05-10 20:17:30 +01:00
Paul-Licameli
8bcec00e65
Rewrite Sequence::GetWaveDisplay
...
That is the function that computes the heights of dark and pale blue lines in
the waveform display.
It's not simple but now the flow of control is less strange and it is better
commented.
This doesn't fix or enhance anything, but it might find use later, such as in
a project to adapt the resolution of the display in reponse to slow scrolling
updates.
2015-04-21 11:11:20 -04:00
Paul-Licameli
2b85d0edb4
Preliminary function argument list changes and comments, for scrubbing project
...
In particular, use an options structure for AudioIO::StartStream to simplify
calls
ControlToolBar::PlayPlayRegion also takes that structure as an argument, and a
SelectedRegion instead of two times
And other changes
2015-04-17 02:25:39 -04:00
james.k.crook@gmail.com
8305bfdb05
From: martin@steghoefer.eu [PATCH 01/15] Fix runtime problem with wxWidgets 3.0: Correct string formatting: wxLongLong -> %lld + long long
...
The functions wxString::Format, wxString::Printf (and others indirectly) have become stricter about parameter types that don't match (format specifier vs. function parameters). So the bugs (that were already present in audacity before) become visible in wx3.0 as error message dialogs. I've checked all occurrences of Printf, wxPrintf, PrintfV, Format, FormatV, wxLogDebug and wxLogError systematically and made the type match.
Note: In Shuttle.cpp this patch supersedes one related change done in r13466 because a wxLongLong_t can be bigger than an int and in a generic function like "TransferLongLong" this should be taken into account.
2014-11-08 16:06:28 +00:00
lllucius
bdcefb4850
Preliminary changes for wxWidgets 3.0.1
...
We can't go to 3.0.1 yet as there are still build issues on
Linux and OSX. You can get Windows to build, but there's
still some display issues.
These changes should work with wxWidgets 2.8.12 as well, so
we can take our time to get things working properly before
switching over.
2014-10-06 08:10:50 +00:00
benjamin.drung@gmail.com
277932dccb
Remove trailing spaces.
2014-06-03 20:30:19 +00:00
v.audacity
fc6e4a4cba
Fix some compiler warnings.
2013-12-13 01:24:47 +00:00
RichardAsh1981@gmail.com
0413de548b
fix the loading of projects with more than 2^31 samples in a waveclip, and possibly some other similar constraints on waveclips. This fixes a long-standing problem with long recordings being saved but unable to re-open them. Tested by Gale and Steve.
2013-11-03 15:49:12 +00:00
v.audacity
8408eaf52a
Get rid of some compiler warnings.
2013-10-31 22:28:21 +00:00
RichardAsh1981@gmail.com
991969cab8
Apply parts of a warning supression patch by Campbell Barton
2013-09-12 16:52:30 +00:00
v.audacity
cc876ce7be
just some cleanups on FIXMEs and unused method parameters
2013-08-31 05:57:48 +00:00
v.audacity
c7daafede2
In off-list discussion, Steve mentioned that kdevelop / kate highlighting recognizes "FIXME", but not "FIX-ME", which has been the Audacity convention. This commit changes Audacity code to use the "FIXME" convention (though I've never known it as convention and MSVC doesn't recognize it).
...
Also, minor change in WaveTrack.cpp in the effort on bug 641. Should have no functional difference.
2013-08-24 20:30:47 +00:00
v.audacity
51e0391b7d
Campbell Barton's patch for mem leaks, http://www.graphicall.org/ftp/ideasman42/audacity_mem_leak_fix_r12450.diff
2013-08-03 00:24:26 +00:00
v.audacity
c26b3c6b49
Campbell Barton's further patch to turn many, many tabs to our 3-space convenbtion
2013-02-23 04:33:20 +00:00
v.audacity
9d0daf8662
Campbell Barton's patch to turn many, many tabs to our 3-space convenbtion
2013-02-20 23:42:58 +00:00
v.audacity
f7841b4d8f
Add selection settings to Device Toolbar tooltips. Adjust some comments.
2012-08-07 04:16:13 +00:00
v.audacity
6f50a64050
comments, cleanup
2012-07-19 23:42:47 +00:00
martynshaw99
ffea5a2273
Addressing one of the problems reported with 'Normalise' if the offset is greater than the signal. Comments on other possible problems.
2012-04-23 23:39:36 +00:00
james.k.crook@gmail.com
dd97cae3d9
Removed some (hidden) Cleanspeech cruft that had been used to disable effects. Made some static text open to translation. Added more i18n hints (thanks Thomas Breinstrup).
2012-04-05 11:21:15 +00:00
mchinen
57694a2449
Sequence.cpp: Convert all blockfiles types including aliases in ConvertToSampleFormat
2012-03-01 04:18:32 +00:00
v.audacity
d3513320d6
fix for typo on prev commit
2012-03-01 02:56:41 +00:00
v.audacity
b45d4dd998
further fix for additional P1 "repeatable crash set format to 16-bit..." thread, Gale's msg of 2012-02-29
2012-03-01 02:11:09 +00:00
v.audacity
01aeba01c1
fix for additional P1 "repeatable crash set format to 16-bit..." thread, Gale's msg of 2012-02-29
2012-03-01 00:47:46 +00:00
