1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-02 08:59:28 +02:00

820 Commits

Author SHA1 Message Date
Paul Licameli
372393f49e Rewrite comments about exception safety guarantees with Doxygen...
... Defining a new macro, which generates a special paragraph with links to a
new page describing the principles.
2020-08-22 23:07:28 -04:00
Paul Licameli
4ca3e7096f
Track factory cleanup (#646)
* Don't need TrackFactory to make LabelTrack

* Don't need TrackFactory to make NoteTrack

* Don't need TrackFactory to make TimeTrack, or ZoomInfo in the factory

* Remove some forward declarations

* Rename TrackFactory as WaveTrackFactory, move it out of Track.cpp
2020-08-22 18:44:49 -05:00
Paul Licameli
a085057b66 Delay creation of tool docks and bars...
... after construction time for ToolManager, so that ToolManager can be
constructed earlier than ProjectWindow, and therefore the unspecified sequence
of invocation of factories of attached objects in the project won't lead to a
crash on any platform
2020-06-08 15:37:12 -04:00
yam
3b71d1fc1e Bug 2465 - Treble height Selection Toolbar 2020-06-07 01:15:39 -05:00
James Crook
9e3cb149f3 Reset selected tool when resetting configuration. 2020-06-03 13:16:21 +01:00
Leland Lucius
7f14e8d7ae Restrict combo size across the board
This fixes "too tall" toolbar problems on Windows with some
scaling settings and doesn't (seem to) hurt on the other
platforms.
2020-06-01 12:37:49 -05:00
Paul Licameli
223ac3b644 Move an #include ...
... obey the rule that each .cpp file includes the corresponding .h file before
any other except Audacity.h
2020-05-31 10:33:35 -04:00
James Crook
bc621158b8 Update OnResetConfig
Now it resets the toolbars, and fixes three common 'stuck-in-a-mode' issues.

Paul wrote: "I would move that function [OnResetToolBars(context)] into ToolManager.cpp so it can be called from ToolBarMenus.cpp and HelpMenus.cpp, with neither of those two dependent on the other."
2020-05-31 12:22:08 +01:00
Leland Lucius
b5e056575b Add missing include 2020-05-31 04:01:32 -05:00
Leland Lucius
c43c757bce Bug 2418 - Time toolbar displays incorrect time if project rate isn't 44100 2020-05-31 03:22:53 -05:00
Leland Lucius
7ac58ac4cc Bug 2419 - Time toolbar: Opening and closing preferences resets format to hh:mm:ss 2020-05-30 16:02:15 -05:00
Leland Lucius
7b9040c7e2 Rename TimerToolBar to TimeToolBar 2020-05-30 16:00:24 -05:00
Leland Lucius
a4b0635dd5 Bug 2410 - Mac: Cosmetic issues with undocked resizable toolbars in Dark and High Contrast themes 2020-05-29 18:31:35 -05:00
Leland Lucius
5cf8434b06 Bug 2410 - Mac: Cosmetic issues with undocked resizable toolbars in Dark and High Contrast themes 2020-05-28 23:10:48 -05:00
Leland Lucius
19e18ed665 Rework SpectralSelection toolbar for wx313 2020-05-23 13:08:21 -05:00
Leland Lucius
ea689f7d24 Rework Selection toolbar for wx313 2020-05-23 13:08:21 -05:00
Leland Lucius
11a527c1ec Rework Device toolbar for wx313 2020-05-23 13:08:21 -05:00
Paul Licameli
d373e27840 Remove some unused forward declarations and #include directives 2020-05-23 05:32:01 -04:00
Paul Licameli
93bcff99df Keep EXPERIMENTAL_VOICE_DETECTION compilable 2020-05-22 21:36:14 -04:00
Paul Licameli
37c0c15f12 Replace various calls to _ with XO 2020-05-22 20:45:07 -04:00
Paul Licameli
4d09705a73 Change XO to XXO in many more places, with no effects at all...
... because the two macros have the same expansion, and are both checked for
in the --keyword arguments passed to msgfmt by locale/update_po_files.sh.

This commit makes ONLY such changes, and comments in Internat.h.  It is big
but quite harmless.

The intention is to introduce a type distinction in a later release, by defining
XXO differently.  XXO is used where & characters in strings (for hotkeys of menu
items or control prompts) are permitted, XO where not.
2020-05-22 13:07:50 -04:00
Paul Licameli
5cef2cd3e4 Remove a few macro _ 2020-05-22 13:07:49 -04:00
David Bailes
ad680e1bbc Time Toolbar: Fixed ID for audio position
The Jaws screen reader script for audacity references the audio position control by its ID, so it's very helpful if this is fixed. It used to be fixed when the control was part of the Selection toolbar.
2020-05-22 09:19:26 +01:00
Leland Lucius
ffa4701247 Bug 2402 - Mac: Zoomed in, timeline still zoomed out. 2020-04-29 12:03:31 -05:00
Leland Lucius
2c9c7547cd Bug 2395 - Mac: Spectral Selection toolbar shows blank fields when first shown 2020-04-21 09:21:08 -05:00
Leland Lucius
0e2fd0ec35 Bug 2393 - Device toolbar cannot be resized smaller after a toolbars reset 2020-04-20 16:28:10 -05:00
Leland Lucius
80f95d407a Bug 2394 - Mac: length field in Selection toolbar is corrupted - blank dotted rectangle. 2020-04-20 09:05:21 -05:00
Leland Lucius
73719882bc Need to force call to during initialization
OnUpdate() will not be called if the saved format is that same
as the default.  But, it must be called to set the initial size
and to reset the controlling flag.
2020-04-13 23:47:51 -05:00
Leland Lucius
bacf6becdc Fix Time toolbar initial size setting 2020-04-13 16:26:10 -05:00
Leland Lucius
a5db7bbb2b Bug 2318 - Linux: Time Toolbar is needlessly resized too large when accommodating longer time format 2020-04-12 01:14:08 -05:00
Paul Licameli
8fad3651a0 More corrections in comments 2020-04-11 10:26:49 -04:00
Yuri Chornoivan
d1ada5f08c Fix minor typos 2020-04-11 10:06:24 +01:00
Paul Licameli
61abb87a77 Reviewed all i18n-hint comments...
... Moved many misplaced ones, which msgfmt would not have extracted into
audacity.pot.

Duplicated some of them, to appear with related but distinct msgids.

Added a few new comments.

Deleted one that was no longer needed in ProjectManager.cpp.
2020-04-05 09:00:00 -04:00
Leland Lucius
c690e03471 Bug 1366 - Using the sliders in Mixer Toolbar in a Project-2 alters levels in on-going recording (or playback) in Project-1
Should be okay now...
2020-03-19 23:36:17 -05:00
Leland Lucius
f6cfa0597e Bug 1366 - Using the sliders in Mixer Toolbar in a Project-2 alters levels in on-going recording (or playback) in Project-1 2020-03-19 22:04:09 -05:00
David Bailes
9210c2aa35 Time Toolbar: change "TimeToolBar" to "Time"
Change string or sub-string "TimeToolBar" to "Time" to conform with the naming convention of other toolbars.

(Change prompted by the narrator screen reader unexpectedly reading TimeToolBar rather than Time when tabbing to the toolbar.)
2020-03-07 11:07:47 +00:00
James Crook
60a113da26 Bug 2318 - Time Toolbar is needlessly resized too large when accommodating longer time formats
Tweaks to TimerToolbar.

- When docked, resizer will spring back to right edge when released.
- Now prefers a smaller font, unless bigger is forced.
2020-02-16 11:15:31 +00:00
Paul Licameli
5501ac0fc2 Move defs of menu items for changing tools, to be with the toolbar 2020-02-14 14:55:39 -05:00
Paul Licameli
d0a99d5ae5 Each toolbar registers its menu item 2020-02-14 14:51:11 -05:00
Paul Licameli
4bbf8bfb6a ToolDock does not depend directly on ToolManager 2020-02-14 12:55:12 -05:00
James Crook
de2459d98a Allow slightly smaller font to fix an edge case.
With the minimum size of 21, it was still possible to hide the drop-down.
2020-02-14 13:06:25 +00:00
James Crook
b837d49b6b Improve positioning of dock-drop indicator
The triangle showing where in the dock a toolbar will drop now takes into account that overly tall toolbars will be resized to 2 tbs once they are docked.
2020-02-14 12:46:43 +00:00
James Crook
9985b8a9b8 Fix Big Time TimerToolBar, Stage III
Fixed issue where format selector could disappear.
Fixed upgrade from 2.3.3.
Remembers time format.
2020-02-14 12:02:21 +00:00
James Crook
a09885e995 Fix Big Time TimerToolBar, Stage II
- Naming (Time Toolbar, not TimerToolBar Toolbar)
- Default time format hhmmss
- Lower dock
- Enabled by default
- Sensible min and max font size
- Sensible min and initial width
- Omit Audio Time from Selection Toolbar
2020-02-06 09:40:30 +00:00
James Crook
8168dce551 Fix Big Time TimerToolBar, Stage I
- Update on idle (new idiom from Paul)
- Dock at x1 or x2 size
- Smooth resizing
- Take some account of width when resizing
- Promote Resizable docking code to ToolBar class
2020-02-05 14:24:59 +00:00
Paul Licameli
c3bbdbc50f fix build 2020-02-01 11:44:38 -05:00
Paul Licameli
b7a9e55fa9 New toolbar id at the end of the enumeration, to be safe...
... in case toolbar ids persisted anywhere
2020-02-01 11:30:26 -05:00
James Crook
1176b61953 Wording changes, per wiki:
https://wiki.audacityteam.org/wiki/Wording
2020-01-10 17:02:31 +00:00
Loss
e787694f07 Implementation of Timer Toolbar
PRL:  Rebased onto recent master, fixed compilation and indentation, added new
files to the XCode project, added an EXPERIMENTAL flag
2019-12-31 17:42:54 -05:00
Paul Licameli
21e7b9f2de TranslatableString for prompts of choice controls 2019-12-23 15:39:49 -05:00