1
0
mirror of https://github.com/cookiengineer/audacity synced 2026-03-11 00:45:53 +01:00
Commit Graph

43 Commits

Author SHA1 Message Date
lllucius@gmail.com
42452cc1da Fixes silent failures for a few exporters
One example is if a user tries to export a file to an invalid file or
is not permitted to write to it.  For the FFmpeg, MP2, and OGG exporters
this error would not be flagged and to the user, it would look like the
file was exported.

These now throw up an error dialog to left the user know.
2014-12-06 12:06:48 +00:00
james.k.crook@gmail.com
8a9987a0d9 From: martin@steghoefer.eu [PATCHES 02-15 of 15] Fix runtime problem with wxWidgets 3.0:
Correct string formatting for:
2/15  %d + enum => %d + int
3/15  %lld + int64_t => %lld + long long
4/15  %d + int64_t => %lld + long long
5/15  %d + double => %f + double
6/15  %d + int32_t => %d + int
7/15  %d + intptr_t => %p + void*
8/15  gint, guint
9/15  %d + long => %ld + long
10/15 %n + int => %d + int
11/15 %x + int => %x + unsigned int
12/15 %f + int => %d + int
13/15 %S + wxChar* => %s + wxChar*
14/15 %d + size_t => %d + int
15/15 %d + size_t => %lld + long long

"The functions wxString::Format, wxString::Printf (and others indirectly) have become stricter about parameter types that don't match (format specifier vs. function parameters). So the bugs (that were already present in audacity before) become visible in wx3.0 as error message dialogs. I've checked all occurrences of Printf, wxPrintf, PrintfV, Format, FormatV, wxLogDebug and wxLogError systematically and made the type match."

Note (9/15): In TrackPanel.cpp, ExportMP2.cpp and CompareAudioCommand.cpp this patch supersedes related change done in r13466 because the new solution requires fewer casts and therefore simplifies the code.

Note: Many .po files are affected, and we need to be very careful about this.  Incorrect "%d" and similar in translation files may lead to crashes in those languages (only).  This is something we should actually have been more careful about in the past.  We need to write a script to check that the "%d" and similar format specifiers match between English and translation.
2014-11-08 16:42:34 +00:00
benjamin.drung@gmail.com
149fcafc1c Replace tabs by spaces. 2014-06-05 22:04:22 +00:00
benjamin.drung@gmail.com
32454b3e6e ExportFFmpeg.cpp: Define snprintf as _snprintf on Windows. 2014-05-31 14:41:59 +00:00
benjamin.drung@gmail.com
4d4580a042 FFmpeg: Replace long deprecated functions by current ones. 2014-05-31 14:01:57 +00:00
benjamin.drung@gmail.com
3416b2a8c1 Drop compatibility for FFmpeg < 1.2 and libav < 0.8.
Dropping support for unsupported upstream FFmpeg/libav versions makes our code
simpler by removing preprocessor conditionals.
2014-05-31 13:23:00 +00:00
benjamin.drung@gmail.com
b5fd9bc068 FFmpeg: Add support for libav 0.8.
Thanks to Michael Niedermayer for the tips.
2014-05-29 21:04:45 +00:00
benjamin.drung@gmail.com
feae3ffa98 FFmpeg: Rename all CODEC_ID_* to AV_CODEC_ID_*. 2014-05-29 16:02:46 +00:00
benjamin.drung@gmail.com
de982fba92 fix pcm u8, s24, s32
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-29 11:53:31 +00:00
benjamin.drung@gmail.com
f61b248156 fix sample_fmts end check
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-29 11:53:10 +00:00
benjamin.drung@gmail.com
b556d83c54 Fix indentation (to multiple of three) and remove trailing spaces. 2014-05-27 22:06:58 +00:00
benjamin.drung@gmail.com
cda7ade23a ExportFFmpeg: dont set global_quality to -99999
This confuses the native aac encoder at least.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:49:04 +00:00
benjamin.drung@gmail.com
4348c9e9c4 ExportFFmpeg: set strict_std_compliance = FF_COMPLIANCE_EXPERIMENTAL;
This allows using the native AAC encoder.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:48:36 +00:00
benjamin.drung@gmail.com
8149b34861 ExportFFmpeg: remove unused variable
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:47:54 +00:00
benjamin.drung@gmail.com
a4e0ff05fb ExportFFmpeg: also check for CODEC_CAP_VARIABLE_FRAME_SIZE
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:46:26 +00:00
benjamin.drung@gmail.com
9755771524 avoid using AVCodecContext->frame_size as the one and only frame size
It can be 0 in case of variable frame size support.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:45:52 +00:00
benjamin.drung@gmail.com
813f8450ea remove special case for flac, flac has smalllast frame cap set
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:40:22 +00:00
benjamin.drung@gmail.com
259e9361da remove unused argument to encode_audio()
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:39:54 +00:00
benjamin.drung@gmail.com
3a56978e17 fix frame_size=0 export case
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:37:15 +00:00
benjamin.drung@gmail.com
73295bbc02 FFmpeg: use Codec name instead if codec_id integer to identify codec
This allows selecting the intended codec when there are multiple with the same
codec_id

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-27 21:36:01 +00:00
benjamin.drung@gmail.com
0a1999130d Drop compatibility for libav/FFmpeg < 0.7. 2014-05-25 21:08:58 +00:00
benjamin.drung@gmail.com
463da8e816 Add support for libav 9. 2014-05-23 20:43:08 +00:00
benjamin.drung@gmail.com
89907256eb some saftey checks on buffer sizes
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:42:25 +00:00
benjamin.drung@gmail.com
fb9bbb3385 no timestamps are being input in the encoder, thus don't output any
this fixes muxing to libvorbis, and possibly others

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:41:14 +00:00
benjamin.drung@gmail.com
5ce748d0b1 dont try to mux a packet if the encoder didnt output one
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:40:34 +00:00
benjamin.drung@gmail.com
b603ed2b7f fix error check for muxer
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:39:08 +00:00
benjamin.drung@gmail.com
3aea9ad009 remove unneeded null check
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:38:45 +00:00
benjamin.drung@gmail.com
48240202ca planar s16&flt export support
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:37:27 +00:00
benjamin.drung@gmail.com
135e80b879 add back support for explicitly listed custom options
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:33:03 +00:00
benjamin.drung@gmail.com
60fe57463e remove urlprotocol use
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:31:34 +00:00
benjamin.drung@gmail.com
f8be1f9668 Make audacity build with ffmpeg HEAD
This still depends on internal API
And is missing planar Audio support, so not all formats work
also the fixed size audio buffer has to be removed

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Benjamin Drung <bdrung@debian.org>
2014-05-23 20:25:50 +00:00
james.k.crook@gmail.com
435f3751c3 Query in comment (a FIXME) answered. This code is looking at whether we can write an incompletely filled buffer. The missing comment is that additionally, if we're configured to be padding with silence, then yes it is OK. 2013-08-24 21:42:12 +00:00
v.audacity
c7daafede2 In off-list discussion, Steve mentioned that kdevelop / kate highlighting recognizes "FIXME", but not "FIX-ME", which has been the Audacity convention. This commit changes Audacity code to use the "FIXME" convention (though I've never known it as convention and MSVC doesn't recognize it).
Also, minor change in WaveTrack.cpp in the effort on bug 641. Should have no functional difference.
2013-08-24 20:30:47 +00:00
v.audacity
9107363b2b comment 2013-08-21 23:41:13 +00:00
v.audacity
414456fa06 bug 469 2013-08-21 23:19:19 +00:00
richardash1981
1fd52b3796 cleanup of exporters based on patch by Campbell Barton: Include headers into classes, remove tail comments, correct the factory method comments 2013-03-03 20:25:59 +00:00
mchinen
682759d965 Bug 467 (P3) fix - Audacity fails to build with latest FFmpeg/libav. Main patch by Leland Lucius with modification from Benjamin Drung. 2012-01-21 08:01:32 +00:00
lllucius
1ec0141909 Fix incorrect index usage which wasn't evident until a
library was used that didn't contain M4A support.
2011-04-04 22:08:53 +00:00
lllucius
f50be91900 Bug #176 - Support newer versions of FFmpeg.
Also includes Benjamin's ffmpeg-configure-v2.patch.
2011-04-02 02:10:50 +00:00
mchinen
a9a0d51454 Timetrack fixes and refactoring.
Possibly fixes:

Bug 206 - Time Tracks: Ruler warp goes in wrong direction
Bug 205 - Time Tracks that slow down the audio result in truncated exports
2010-10-07 23:01:49 +00:00
v.audacity
0ae919f656 Make better discrimination of wxLogMessage, wxLogDebug, and wxLogError usage so user doesn't see lots of irrelevant info in log window, only messages and errors they should need to see. For example, user doesn't need to see every step of loading FFmpeg in release build, only errors, if they occur.
Comment out in FreqWindow.cpp the wxLog* stuff that can just be done with breakpoints ("Starting FreqWindow::Plot()" et al).
2010-08-10 05:13:28 +00:00
businessmanprogrammersteve
4eb04322da Eliminate more warnings by moving static tables out
of ExportFFmpegDialogs.h; set up automatic duplication
of enumeration constants and string representations.
2010-02-13 01:39:38 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00