Steve Daulton
0303d281cc
Fix for bug 1650
...
Don't attempt to read plug-in file when spawned from Nyquist Prompt
because there isn't one.
2017-05-23 23:38:55 +01:00
Steve Daulton
04ba10a1c3
Add help button support for other Nyquist effects
2017-05-21 23:11:21 +01:00
Steve Daulton
e99b54e525
Add help button for Classic Filter
2017-05-21 12:04:15 +01:00
James Crook
d549dccefd
Bug 1649 - Freeze with Truncate Silence
2017-05-20 18:32:06 +01:00
Steve Daulton
d6a9011960
"Error opening sound device" as Error dialog
...
ShowErrorDialog could do with some polish, but it supports linking
a help button to the manual.
2017-05-20 17:11:02 +01:00
Steve Daulton
bba5a8fef1
Add help button for Nyquist Prompt
2017-05-20 14:49:07 +01:00
Steve Daulton
e7a9c37745
Add help buttons for normal built-in effects
2017-05-20 14:49:07 +01:00
Steve Daulton
fd3d41e82f
Add help pages for shipped Nyquist effects
2017-05-20 14:49:07 +01:00
Steve Daulton
1dd6b848c2
Enable Help button for Nyquist effects
2017-05-20 14:49:07 +01:00
Steve Daulton
469120cebd
Enable help button for effects
2017-05-20 14:49:07 +01:00
Steve Daulton
e16f6f9221
Add small help button to Prefs pages
2017-05-14 19:02:36 +01:00
Paul Licameli
e66028de0a
Eliminate "Average RMS" redundancy in messages from Contrast...
...
... also gathered various formatting into some routines. Should we regularize
the messages further? That is, consistently put "dB" before or after "RMS"
Also added more i18n-hint comments
2017-05-12 16:06:18 -04:00
James Crook
09607c278d
Fix position of wxASSERTs
...
Moved one ASSERT that was in the wrong place and added a new one. This might give a little more information in mac debug builds about Bug 1636 - (Mac) Equalization: Crash selecting the "RIAA" or "Telephone" curves. This is NOT a fix.
2017-05-07 19:22:44 +01:00
Paul Licameli
e36070e671
Small fix to envelope operations in Equalization user interface
2017-05-07 11:12:07 -04:00
Paul Licameli
9c683a4f19
Rename some member functions of Envelope
2017-05-07 11:00:55 -04:00
Paul Licameli
4be19128c0
Better constructors for Envelope
2017-05-07 11:00:55 -04:00
Steve Daulton
ae24cab8fe
Remove 'TODO's for completed documentation
2017-05-01 18:51:35 +01:00
James Crook
2a043c0b35
Add settable ruler colouring.
2017-04-26 22:32:09 +01:00
Paul Licameli
972f7471de
Fix progress bar in Normalize
2017-04-24 11:38:28 -04:00
James Crook
028ed19d90
Sync with DarkAudacity
2017-04-02 23:07:13 +01:00
Paul Licameli
0d7250578d
Other methods of WaveTrack return void, will throw on failure instead
2017-03-31 18:26:52 -04:00
Paul Licameli
e1473dfe76
void return, not boolean success, from some Track virtual functions...
...
... The return codes were mostly ignored anyway, and exceptions will be thrown
instead.
It seems there was also confusion whether the return values of Track::Paste
and Track::SyncLockAdjust were to indicate success or indicate whether there
was any change. No matter now.
2017-03-31 18:26:52 -04:00
Paul Licameli
6b84dc1c1d
Factory methods will return non-NULL or throw
2017-03-31 18:14:29 -04:00
Paul Licameli
d1cbac4181
more finally, more const, remove unused, fix warnings
2017-03-31 17:47:18 -04:00
Steve Daulton
a9879bddf0
Refactor clipfix.ny to fix multiple problems
...
Basically a rewrite based on the original algorithm.
2017-03-31 00:01:18 +01:00
Steve Daulton
260044bcb0
Ffix wx assert in debug build
2017-03-22 20:26:39 +00:00
Paul Licameli
70d9e4bdc7
GetMinMax, GetRMS functions take a mayThrow argument, return numbers
2017-03-21 14:19:02 -04:00
Paul Licameli
22a12c6852
Exception safety in: some effects and generators...
...
... Those that directly call WaveTrack functions in their Process() routines,
which might throw exceptions for disk space exhaustion.
2017-03-21 14:11:25 -04:00
Paul Licameli
1fad6292a2
Exception safety in: overrides of ShowInterface
2017-03-21 14:11:24 -04:00
Paul Licameli
79c3bef2ce
Exception safety in: general effect performing functions
2017-03-21 14:11:24 -04:00
Paul Licameli
464828d88f
Exception safety in: batch processing
2017-03-21 14:11:21 -04:00
Paul Licameli
82dd7545c9
Reviewed uses of release(); prefer Destroy_ptr to hold window objects
2017-03-21 14:11:18 -04:00
Paul Licameli
d38dde213e
Revert "Fix compilation of EXPERIMENTAL_EFFECTS_RACK"
...
This reverts commit 9842d0742f
2017-03-19 10:51:00 -04:00
Paul Licameli
9842d0742f
Fix compilation of EXPERIMENTAL_EFFECTS_RACK
2017-03-19 10:49:23 -04:00
James Crook
e94fa1d65e
Fix compilation on MSVC2013 Express.
...
MSVC2013 Express does not support some initialisation syntax for structs and instead gives error C2905.
This workaround to get us compiling again may need revisiting.
2017-03-18 16:07:15 +00:00
Paul Licameli
3bb04245c5
Strong exception safety in all uses of XMLFileWriter...
...
... Strong, meaning that the file at the specified path is created or modified
only if all write operations complete without exceptions, barring one very
unlikely possibility that a final file rename fails, but even in that case the
output is successfully written to some path.
This commit does not add throws, but changes the type thrown to a subclass of
AudacityException, so that GuardedCall will cause the user to see an error
dialog in all cases.
Duplicated logic for making temporary files and backups is now all in one
place, the class XMLWriter.
There may be more new GuardedCalls than necessary -- the catch-all for the
event loop, AudacityApp::OnExceptionInMainLoop, might be trusted instead in
some cases -- but they are sufficient.
2017-03-18 11:45:33 -04:00
Paul Licameli
b81cdee7e3
Comment where xml writing functions may throw
2017-03-18 11:45:05 -04:00
Paul Licameli
8e5975b10d
Report read exceptions met in SBSMS and Nyquist callbacks to user...
...
... without letting them propagate through the libraries.
2017-03-17 17:53:03 -04:00
Paul Licameli
6525bb18cf
Translate exceptions to error codes in callback functions...
...
... That is what the library protocols allow, and libraries may be written
in C and might corrupt their state if C++ exceptions pass through them.
2017-03-17 17:53:01 -04:00
Paul Licameli
576d3e3013
Don't let the catch-all block in Effect intercept the new exception
2017-03-17 17:53:01 -04:00
Paul Licameli
cab99f7234
Remove naked malloc (or similar) and free in: other effects
2017-03-17 17:52:53 -04:00
Paul Licameli
0c7e467a08
Remove naked malloc (or similar) and free in: reverb
2017-03-17 17:52:53 -04:00
Paul Licameli
03809532ca
Remove naked malloc (or similar) and free in: Equalization48x
2017-03-17 17:52:53 -04:00
Paul Licameli
58574f2f78
Redo type HFFT as a smart pointer, remove malloc and free
2017-03-17 17:52:51 -04:00
Paul Licameli
6ca89c28ff
Remove naked new[] in: builtin effects
2017-03-17 17:52:49 -04:00
Paul Licameli
cb05476c45
Remove naked new[] in: effects plug-ins
2017-03-17 17:52:48 -04:00
Paul Licameli
a4c7d37d3e
Remove naked new[] in: effects framework
2017-03-17 17:52:48 -04:00
Paul Licameli
aebaaf46a0
require unsigned arguments for Array(s)Of::reinit
2017-03-17 17:52:43 -04:00
Paul Licameli
38236a807c
More new -> NEW, delete -> DELETE in comments
2017-03-17 17:52:41 -04:00
Paul Licameli
ec0297ec28
more safenew
2017-03-17 17:52:41 -04:00
