The override keyword is available since C++11 and the project already
required C++17, so there's no reason to go through wxOVERRIDE to support
non-C++11 compilers. wxOVERRIDE is new since wx3.1.0
Signed-off-by: Mart Raudsepp <leio@gentoo.org>
What I tried to do here, as well as the alternative fixes I considered,
is way too large to explain. Long story short, I wanted to initially check
whether Tenacity.Project OR Audacity.Project was defined, but a typo as I was
formatting the change led to a logic error.
However, even if I did what I wanted to do, that would mean that we'd "lose"
our opportunity to ask the user whether they want to use Tenacity instead of
other programs. The Audacity developers basically already fixed the problem
that I was trying to fix, and the solution was right in front of us.
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
This fixes a link error with MSVC and sccache:
wxbase31u.lib(wxbase315u_vc_custom.dll) : error LNK2005: "public: __cdecl wxEventFilter::wxEventFilter(void)" (??0wxEventFilter@@QEAA@XZ) already defined in ToolManager.cpp.obj
wxbase31u.lib(wxbase315u_vc_custom.dll) : error LNK2005: "public: virtual __cdecl wxEventFilter::~wxEventFilter(void)" (??1wxEventFilter@@UEAA@XZ) already defined in ToolManager.cpp.obj
Signed-off-by: Be <be@mixxx.org>
Also, necessarily coupled with this:
* add CMakeLists.txt for vendored libnyquist
* fix SoundTouch header include paths
* move nyq_reformat_aud_do_response function
* handle portSMF headers installed to portsmf or portSMF
Signed-off-by: Be <be@mixxx.org>
The conditions that were affected by this change were also split across
multiple lines to improve formatting.
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Reference-to: 4408d96ff505d9d75de997ed5ca483a5ea393da5
Reference-to: https://github.com/tenacityteam/tenacity/pull/482
* Update minimum MacOS version to 10.12 Sierra
* Replace `std::uncaught_exception` with `std::uncaught_exceptions`
Signed-off-by: Sol Fisher Romanoff <sol@solfisher.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/481
- Remove `src/import/ImportGStreamer.cpp`
- Remove CMake definition from `src/audacity_config.h.in`
- Remove credit in About Dialog, since we don't even bundle that anymore
- Remove GStreamer mention from comment
- Remove USE_GSTREAMER macro
The feature itself is a leftover that is more than a decade old. Upstream
Audacity and downstream packagers don't enable that either.
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
- Replaced Commit Id by Version from GIT_DESCRIBE output
- Injected GIT_DESCRIBE macro at Version.cmake
- Removed timestamping from version description and cleaned its code
Resolve: #460
Signed-off-by: Humberto Rocha <humrochagf@gmail.com>
... Everywhere else, GetLeftOffset() not GetLabelWidth() is used as the origin
in PositionToTime and TimeToPosition.
This only affects two commands in TransportMenus.cpp. Starting time of
playback may change slightly (by the duration that corresponds to one pixel).
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
... and in 3.0.0 started crashing instead. Just disallow it again, no
functionality lost.
Signed-off-by: Sol Fisher Romanoff <sol@solfisher.com>
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Fixes a number of small theme coloring mistakes.
Changes GraphLines color in light theme to black.
Adds modifier key to temporarily override sync-lock
Improves the workflow when using synced tracks
Changes Background of synced tracks
Makes locked background tile without gaps and offsets
Signed-off-by: akleja <storspov@gmail.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/404
* Add `void*` cast to indicate we are sure that the byte string is valid.
* Make `ProjectSerializer.cpp` use `static_cast` to preserve pointer addresses.
* Replace incorrect usage of `int` where `size_t` was appropriate
Signed-off-by: Emily Mabrey <emabrey@tenacityaudio.org>
Reference-to: https://github.com/tenacityteam/tenacity/pull/417
Makes item snap to selection start and end points.
Also makes items snap to edit cursor, which follows
selection start point.
Signed-off-by: akleja <storspov@gmail.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/387
Adds modifier key to temporarily override sync-lock
Improves the workflow when using synced tracks
Changes Background of synced tracks
Makes locked background tile without gaps and offsets
Signed-off-by: akleja <storspov@gmail.com>
The affordances made parts of the 1px black border between v-ruler and
track controls not draw properly. This resulted in graphical glitches
where the border should be.
Signed-off-by: akleja <storspov@gmail.com>
* Make CMake builds better parallelized
* Update CI Build script parallelization
* Make `repeat_hdiutil.sh` take longer between repeats
* Make sure that bash is the latest version on CI builds.
Signed-off-by: Emily Mabrey <emabrey@tenacityaudio.org>
Reference-to: https://github.com/tenacityteam/tenacity/pull/391
* Add custom draw tool cursor
* Replace most old mouse cursors
* Increase consistency with toolbar icons
* Replace zoom icons in FreqWindow
* Increase consistency across themes
* Add custom selection adjustment cursor
(The Windows ones looked like they originated from the DOS era.)
Co-authored-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Signed-off-by: akleja <storspov@gmail.com>
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
