1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-17 00:57:40 +02:00

51 Commits

Author SHA1 Message Date
Paul Licameli
af276ac4f9 Now implement scrubbing default to unpinned, see commit ac1017e...
... This was motivated by punch and roll recording:  it appears most convenient
to pin the head for recording purposes, and drag it near the right, but when
stopping and finding the splice point for the correction, it is better to
scrub unpinned.
2018-08-31 10:46:08 -04:00
Paul Licameli
3051e9ce7e Stop button works during punch and roll recording 2018-06-09 15:43:17 -04:00
Paul Licameli
ed660bdca2 More apt argument name 2018-06-09 15:25:59 -04:00
Paul Licameli
35a97e09e7 Group arguments to StartStream, and a bit less of #ifdef for MIDI play...
... And pull choice of tracks and options out of DoRecord
2018-05-29 00:22:12 -04:00
Paul Licameli
0635f8802b Fix build 2018-05-28 16:48:04 -04:00
Paul Licameli
49899a561d fix build 2018-05-28 16:30:12 -04:00
Paul Licameli
f52b53fc50 Factor ControlToolBar::OnRecord...
... pulling out the function that chooses existing tracks for append-record,
and a function that does the recording once tracks are chosen.
2018-05-28 15:59:20 -04:00
James Crook
fa49d94530 Script work
Add Envelope script
Add Clips and Boundaries Scripts.
Add docimages_oddments.py for the weirder cases.
Add make html script.
Add more spectral images
Add Dark versions of spectrograms (paul's comment)
Clean up oddments script.

- This commit also adds an option NOT to bring Audacity to the top when screenshotting.
-- That's because QuickPlay will disappear if you do -because you lose mouse capture.
- Also allow negative window IDs in the drag command.

- Registration names of align commands sorted.  They had &, : and / in them.
- Fixed bug in SetTrackInfo where bFocused was being ignored
- Fixed bug where command manager ignored multi-commands.
- Commit docimages_oddments.py again, to fix line endings.
2018-02-24 14:20:29 -05:00
Paul Licameli
aa72cae61b Follow wxWidgets argument conventions for other window factories 2018-02-21 19:21:05 -05:00
Paul Licameli
c0f2782695 Fix interaction of recording and undo...
... in case you also do things, concurrent with the recording, that affect the
undo stack, either by pushing it (such as by changing the gain on one of the
playing tracks, or making a label) or by "Modifying state" without a new undo
item (such as when you change its size or mute or solo).
2018-02-21 19:21:00 -05:00
Paul Licameli
950898dcb9 Revert "Bug 1823: Better interaction of undo and record..."
This reverts commit 1e8aba968da56374d74fb5589caa56caf5fe1283, reversing
changes made to 6e75ae58ac56d9c94af5a4ce97951f627808473a.
2018-01-14 21:27:41 -05:00
Paul Licameli
91f5446eb1 Fix interaction of recording and undo...
... in case you also do things, concurrent with the recording, that affect the
undo stack, either by pushing it (such as by changing the gain on one of the
playing tracks, or making a label) or by "Modifying state" without a new undo
item (such as when you change its size or mute or solo).
2018-01-14 19:33:39 -05:00
Paul Licameli
31231a54d2 use override 2017-11-05 21:01:52 -05:00
Paul Licameli
8bf3791edf TrackList constructed only by factory function, to avoid more trouble 2017-07-14 21:55:32 -04:00
Paul Licameli
5d5edecca5 Remove unnecessary semicolons 2016-09-18 10:36:53 -04:00
Paul Licameli
52d12c6913 Remove some naked new amd delete in: toolbars 2016-08-08 07:51:25 -04:00
Paul Licameli
e844b07a46 All Toolbars define RegenerateTooltips; invoke during project init...
... and UpdatePrefs
2016-06-12 00:00:04 -04:00
Paul Licameli
bbb93a7400 One more alternate play button image, for seeking 2016-06-02 15:55:16 -04:00
Paul Licameli
e39da0c42b New preference for pinned play head, also in Transport menu 2016-06-01 13:25:01 -04:00
Paul Licameli
fecc6f53e4 Consolidate the code that starts and stops play/rec head scrolling 2016-06-01 13:25:01 -04:00
Paul Licameli
737e24e24e Allow pausing and unpausing of scrub. Just treat it differently internally. 2016-05-11 19:59:11 -04:00
Paul Licameli
6147705199 Vary status string (leftmost in the status bar) for the four kinds of scrub. 2016-04-24 16:13:07 -04:00
Paul Licameli
01001fdea9 New alternative appearance for the transport toolbar play button, for scrubbing 2016-04-19 17:34:38 -04:00
Paul Licameli
4fc4f529a0 Bug1053: Meaningful status bar messages for scrubbing 2016-04-18 19:28:56 -04:00
Paul Licameli
d5915491b3 Bug1342: Loop-play (and other things) before scrub (and other things)...
... should not disable auto-scrolling of the window during playback.
2016-04-18 17:50:17 -04:00
Steve Daulton
484f23dcc7 Fix for bug 814 2016-03-28 21:07:25 +01:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Leland Lucius
133c0ec61d Fix for bug #1159 2015-08-26 00:13:14 -05:00
David Bailes
a25a8f8f26 state field of status bar. Previous commit failed to build on linux (again). Added forward declaration of class wxStatusBar to ControlBar.h. 2015-06-02 16:21:51 +01:00
David Bailes
391bd1691c status bar state field. When you move to the menubar, the state field is no longer cleared. This was achieved by introducing a dummy field of width 0. When you first open a new audacity project, the state is stopped - previously the state only appeared after the first play/pause/etc command. 2015-06-02 15:18:46 +01:00
David Bailes
5c67bc38b3 Add a field to the status bar to show the state of Audacity, eg play/record/play pause. This is useful so that screen readers can easily read audacitys state. 2015-05-29 17:47:43 +01:00
Steve Daulton
702d9d75e5 Timeline Quick Play bug fixes and enhancements 2015-04-17 17:52:13 +01:00
Paul-Licameli
2b85d0edb4 Preliminary function argument list changes and comments, for scrubbing project
In particular, use an options structure for AudioIO::StartStream to simplify
calls

ControlToolBar::PlayPlayRegion also takes that structure as an argument, and a
SelectedRegion instead of two times

And other changes
2015-04-17 02:25:39 -04:00
lllucius
622b609f91 Allow button state to persist across toolbar reset 2015-01-01 11:46:52 +00:00
lllucius
fe42e881a5 First stab at taming the meter toolbars
This should correct at least a couple of the reported
issues.  And it also has some fixes in for multiple
project support.
2014-12-17 19:16:08 +00:00
james.k.crook@gmail.com
c71397beae Changes to seeking and scrubbing from Paul Licameli.
These are mostly under an EXPERIMENTAL_ #ifdef.  Also has a change for the prompt string for preferences so the displayed keybinding is adjusted when in multitool mode.
2014-11-29 22:09:57 +00:00
james.k.crook@gmail.com
7324997db6 Fix for http://bugzilla.audacityteam.org/show_bug.cgi?id=643 "Residual consistency issues with SHIFT showing Loop Play button icon" by Paul Licameli.
* Loop play-at-speed and cut preview play-at-speed implemented.
* Shift or ctrl down now affect all relevant buttons, loop or cut preview, normal or at speed, and append-record.
2014-11-29 17:22:05 +00:00
james.k.crook@gmail.com
0ff4403911 Modified version of Paul L's patch to correct play button state up/down looped/unlooped. 2014-08-17 10:23:31 +00:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
v.audacity
24442a210f Remove Batch button cruft, never implemented since 2006. 2013-08-05 02:12:46 +00:00
v.audacity
ac6eaeeb70 attempt at fixing compile error on Linux 2013-07-30 22:43:45 +00:00
v.audacity
522205b056 Move check for ControlToolBar shift key-up from TrackPanel::OnTimer() to new ControlToolBar::OnTimer(). 2013-07-30 01:11:36 +00:00
v.audacity
c52f2d3b12 Fixes for ControlToolBar tooltips with keyboard shortcuts not working correctly in some languages, and for tooltips being updated without having to exit and restart. 2013-07-30 00:36:57 +00:00
v.audacity
b8128af0c5 Gale suggested showing current key shortcuts for toolbar controls tooltips. This implements it for ControlToolBar (aka Transport toolbar).
One tricky aspect was that until GetActiveProject() is ready to return non-NULL,  ControlToolBar::RegenerateToolsTooltips() cannot get the project's CommandManager, so cannot get the shortcuts. Changed ControlToolBar::RegenerateToolsTooltips() to be public and now call it late in wAudacityProject(). When called before the project is completely instantiated, in the rewritten ControlToolBar::RegenerateToolsTooltips(), it just sets the tooltips to the names without the keys, pretty much as now -- but I don't think users will ever see that because of the subsequent call. 

Anyway, did it in a more programmatic way than the previous code, which reduces string literals duplication.

Btw, I changed the start value for the ID_PLAY_BUTTON because the former value of 0 causes FindWindow() to return the toolbar rather than the button -- wxWidgets bug. 

Also got rid of some cruft and applied a few WXUNUSED.
2013-07-23 22:07:56 +00:00
martynshaw99
1af35d4168 Removal of all the stuff marked as 'Experimental CLEANSPEECH' about a year ago. 2013-04-29 23:23:14 +00:00
martynshaw99
758a8f65e6 Inserting CLEANSPEECH ifdef's around anything CleanSpeech so that CleanSpeech can be removed easily in the (not to distant) future. The idea is never to turn CLEANSPEECH on, but fix any (unexpected) differences this may make. 2012-04-26 22:57:04 +00:00
james.k.crook@gmail.com
860e19ae47 Fix Bug 432: Cleanspeech mode will now not activate, even if it was enabled in a previous version (and even if it has been deliberately added to audacity.cfg). 2012-03-25 20:22:10 +00:00
v.audacity
93485f5c50 ControlToolBar now appears in GUI as "Transport Toolbar" instead of "Control Toolbar", to better relate it to the Transport menu. 2010-11-16 01:18:39 +00:00
BusinessmanProgrammerSteve
2499082baa Update Sync-Lock icons on toolbar, TrackInfo; add the ability to have
a different foreground icon when a toolbar button is pressed (which
will likely be used soon for the Sync-Lock icon).
2010-10-27 04:36:26 +00:00