1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-29 15:09:30 +02:00

1794 Commits

Author SHA1 Message Date
Paul Licameli
c63cbf01eb Be careful of static initialization of arrays of FileType 2020-05-22 20:14:02 -04:00
Paul Licameli
4d09705a73 Change XO to XXO in many more places, with no effects at all...
... because the two macros have the same expansion, and are both checked for
in the --keyword arguments passed to msgfmt by locale/update_po_files.sh.

This commit makes ONLY such changes, and comments in Internat.h.  It is big
but quite harmless.

The intention is to introduce a type distinction in a later release, by defining
XXO differently.  XXO is used where & characters in strings (for hotkeys of menu
items or control prompts) are permitted, XO where not.
2020-05-22 13:07:50 -04:00
Paul Licameli
5cef2cd3e4 Remove a few macro _ 2020-05-22 13:07:49 -04:00
Paul Licameli
d22b650e6a Fix two typos for translated strings, now that strings are unfrozen...
... See commit 97fba037a43ef57ecedc89ac24846a639caaca98.
2020-05-22 12:48:49 -04:00
Paul Licameli
f8a070dde7 Rename macro wxPLURAL as XP (brief, and eliminates mention of "wx") 2020-05-22 12:48:49 -04:00
SteveDaulton
29d1a7b7b1 Fix bug 2392
Commit 66fd95f3d6da21 reverted.
2020-04-20 11:26:57 +01:00
Paul Licameli
106119cb28 Make a scale factor in Compressor like all other scale factors...
... Multiply by it before putting value TO the slider.  Divide by it taking the
value FROM the slider.
2020-04-19 21:07:51 -04:00
Paul Licameli
ee797f59de Fix bug in effect presets dialog...
... introduced at 46e99bb038b7619970ff99578f656c5f6cc80996
2020-04-18 22:31:51 -04:00
Leland Lucius
e8f9f4a7e9 Bug 1336 - Tracks -> Mix Stereo to Mono ignores envelope 2020-04-17 14:52:31 -05:00
Leland Lucius
a6d0b3f902 Bug 2360 - Scripting: "Message:" command may crash when using Nyquist with Python 2020-04-16 22:14:45 -05:00
Leland Lucius
9827d4a753 Bug 2360 - Scripting: "Message:" command may crash when using Nyquist with Python 2020-04-15 10:10:00 -05:00
Leland Lucius
9f5177056d Bug 2365 - Show Log text is invisible on W10- set to "High Contrast" 2020-04-14 16:42:00 -05:00
Leland Lucius
3653f5f3bf Bug 1807 - NyquistPrompt Scripting command is not functional
Try #3, but I'm pretty sure this is the one.  :-)
2020-04-14 11:37:57 -05:00
James Crook
97fba037a4 Two typo fixes for translated strings.
The extra logic causes the new string to be used, if the old one is untranslated.
2020-04-14 15:49:46 +01:00
Leland Lucius
bbbe58719f Bug 2036 - Mac: Some AU plug-in effects can be enabled but fail to register 2020-04-12 14:02:10 -05:00
Paul Licameli
8fad3651a0 More corrections in comments 2020-04-11 10:26:49 -04:00
Yuri Chornoivan
d1ada5f08c Fix minor typos 2020-04-11 10:06:24 +01:00
Leland Lucius
ead26dd2aa Bug 1807 - NyquistPrompt Scripting command is not functional
2nd attempt... :-(
2020-04-05 14:54:11 -05:00
Paul Licameli
61abb87a77 Reviewed all i18n-hint comments...
... Moved many misplaced ones, which msgfmt would not have extracted into
audacity.pot.

Duplicated some of them, to appear with related but distinct msgids.

Added a few new comments.

Deleted one that was no longer needed in ProjectManager.cpp.
2020-04-05 09:00:00 -04:00
Leland Lucius
0523e292a3 Bug 1807 - NyquistPrompt Scripting command is not functiona 2020-04-04 16:11:11 -05:00
Leland Lucius
c840133dd8 Bug 2384 - Filter Curve EQ error in non-English locale 2020-04-04 02:54:55 -05:00
SteveDaulton
8e57ce451a Add spectral delete effect 2020-04-02 22:41:06 +01:00
Leland Lucius
8ae9a708fe Fix disabled OK button in effects when monitoring 2020-03-31 13:54:02 -05:00
Leland Lucius
4b76af5314 Bug 2376 - Crash when attempting to use AudioUnit in Basic mode 2020-03-30 00:39:07 -05:00
David Bailes
203d801293 Built-in Generate and Analyse dialogs: add missing access keys 2020-03-27 14:40:26 +00:00
David Bailes
eeeb4f3e1f Built-in effect dialogs: add access keys where necessary
Several of the dialog were missing acccess keys.
Note: access keys not added to Distortion effect as yet, due to complexity of control names changing when the Distortion type is changed.
2020-03-27 10:51:34 +00:00
Paul Licameli
9f076b5179 Make changes to Change Tempo dialog during preview work as intended...
... See commits b22f6b59d22d8a5b93fc775ac25d85d391f6d459 and
19fa6d2833273d8997a3c9609d8a6ee312bd092b
2020-03-26 11:13:43 -04:00
Paul Licameli
85c34132f4 fix sync-lock adjustment in effects, see commit a93c447 2020-03-26 11:08:22 -04:00
Paul Licameli
491b1d40a3 Remove unused member of Effect 2020-03-26 11:02:53 -04:00
Paul Licameli
8570ab7402 Fix incorrect type shuttling Loudness parameters 2020-03-22 22:08:31 -04:00
Paul Licameli
210fc28863 Bug 2368: Effects with clip boundaries differing across channels...
... Wrong results could happen in effects that don't compute the channels
independently, such as the built-in Reverb.

To fix it, always fetch same position of left & right channels when
computing effects.
2020-03-22 07:56:40 -04:00
Paul Licameli
8eee265c38 Fix error in generator code...
... see commit 5378b0a9517bea6b6d22d2493c385f4df474d0b8

complete the change that was intended there, for both channels
2020-03-22 07:56:40 -04:00
James Crook
d809745a55 Bug 2367 - Residual: Change Speed effect may create spurious clip at end
Also the fix for Change Pitch was not complete as it only worked for mono tracks.
2020-03-22 11:49:39 +00:00
Paul Licameli
37c8a6ef23 Remove unused member variable 2020-03-21 16:19:13 -04:00
Paul Licameli
7ae5c65580 Remove test in Loudness effect for same clip boundaries in channels...
... it was not correctly written, and anyway WaveTrack::Get doesn't really
report sufficient information to test as intended.
2020-03-21 15:48:58 -04:00
James Crook
0fe483f0e2 Bug 2367 - Change Pitch effect may create spurious clip at end 2020-03-21 19:40:56 +00:00
Paul Licameli
b683ed8c07 Remove vestiges of unification of Normalize with Loudness 2020-03-21 11:14:13 -04:00
Paul Licameli
7224671628 Fix a comment 2020-03-19 15:47:55 -04:00
Paul Licameli
76a896845c Use safenew (appropriately!) in two places 2020-03-19 14:34:16 -04:00
Leland Lucius
9cf80a41ee Bug 2334 - Mac: AU effects cannot Export or Import the effect's settings
This removes the ability to import/export multiple presets at
once and add the standard method used by the other plug-ings.

It also adds a workaround for the AU view not updating after
setting a new preset.  I will continue to look for the true
cause of this, but the workaround does correct the display
issue.
2020-03-14 18:58:55 -05:00
Paul Licameli
76c3008759 Remove unused variable 2020-03-14 14:52:47 -04:00
Leland Lucius
12c940cdf6 Suppress deprecation warning 2020-03-11 23:47:55 -05:00
Paul Licameli
c2feee6cea Bug2346: Complete fix...
... without making undesirable dependency cycles.

Eliminate calls to NewWaveTrack in effects, but in Edit>Copy too, which was
not mentioned in the bug report.  (Copying a track, deselecting all, and pasting
preserved CLIP colors, but not the TRACK color setting which applies to newly
generated clips.)

Instead, always use the new function WaveTrack::EmptyCopy from the track to be
later replaced, getting color information.

NewWaveTrack is still used in benchmark test, import, the Track menu
commands that make new tracks, recording to new tracks, and generators without
a selection, where there is no track to copy from.

Also when deserializing tracks from the .aup file, in which case the saved
color is later retrieved from the file.

Also, in mix-and-render, where other logic decides whether to copy colors
afterward.

See commit a9658e6ef7f7eaefce4dc37a93d389cca7705f41
2020-03-10 22:32:23 -04:00
Paul Licameli
046ee21e72 Move GetEditClipsCanMove to global function in TracksBehaviorsPrefs.cpp 2020-03-09 11:23:08 -04:00
Paul Licameli
37d730edfe Break dependency cycle of Effect and EffectManager 2020-03-08 16:21:28 -04:00
Leland Lucius
ced4c21700 Bug 2334 - Mac: AU effects cannot Export or Import the effect's settings
Nearly all of the entire preset handling was broken.  It was based
on the parameter names only and for various reasons, that was very
inadequate.

So, it now uses the recommended approach.
2020-03-07 02:06:15 -06:00
Leland Lucius
35fa6cf399 Bug 2036 - Mac: Some AU plug-in effects can be enabled but fail to register
None of the effects listed in the bug expose any parameters.
2020-03-07 01:39:11 -06:00
Leland Lucius
d15308b7e7 Bug 1602 - Mac: AUPeakLimiter plug-in visual corruption makes it hard to use the effect
And fix for #3 listed here:

https://forum.audacityteam.org/viewtopic.php?f=47&t=109165&p=387698#p387698
2020-03-06 23:20:23 -06:00
Paul Licameli
a9658e6ef7 Alternative fix for Bug2346 without dependency cycles 2020-03-06 17:32:24 -05:00
James Crook
f1b6843b9a Bug 2321 - Crash on editing ChangePitch parameters in a Macro
EffectChangePitch:: Don't use the inputTracks() when building the GUI
in Batch mode.

Repeat and NyquistEffect had the same problem as they could call
FindProject() which used inputTracks() on a closed project.  Fixed by a change in Effect::GetSelectionFormat().
2020-03-06 19:14:31 +00:00