1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-23 09:01:15 +01:00
Commit Graph

654 Commits

Author SHA1 Message Date
Paul Licameli
127b2a6acf Fix more narrowings of sampleCount 2016-08-26 12:42:22 -04:00
Paul Licameli
79c79f9cd3 Remove many mentions of sampleCount with auto and decltype...
... This makes much code agnostic about how other things (functions and
arguments) are typed.

Many of these neeed to become size_t instead of sampleCount.
2016-08-24 14:50:45 -04:00
Paul Licameli
1281f1b14b Common function limits buffer size to sampleCount known to be small 2016-08-23 12:46:10 -04:00
James Crook
be66873fca Restored bevels on TrackInfo.
Aesthetic choice, currently disabled in run up to 2.1.3.
Lowest edge of bevels now hidden correctly on smaller panels (if bevels enabled).
2016-08-21 18:17:51 +01:00
Paul Licameli
5761972dfa BHug1488: Don't crash exiting from command-line benchmark test...
Problem was that cfd7648fce fixed a memory leak
but created a dangling pointer bug, which does not happen during usual run
of Audacity because AudacityProject::OnCloseWindow is reached then before
destroying AudacityProject.

Fixed it by using a std::shared_pointer for the TrackList that both
AudacityProject and TrackPanel must use.
2016-08-20 13:58:56 -04:00
Paul Licameli
cb48ca2b91 Use arrays of smart pointers to WaveClip 2016-08-12 20:53:38 -04:00
Paul Licameli
b548e641ae Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ...
... also add some const qualifiers
2016-08-12 20:53:37 -04:00
Paul Licameli
cb7872f980 use std::vector to hold TrackClip; move ctor and dtor out of line 2016-08-12 20:53:37 -04:00
James Crook
5939fe66e8 Bug 1053 - [Scrub Phase I] Status Bar messages incomplete for scrub started with menu or shortcut. 2016-08-10 21:57:29 +01:00
Steve Daulton
256a8aaedd Consistent vert/horizontal waveform zoom/scroll
Shift+Wheel -> scroll
Ctrl+Wheel -> zoom
Ctrl+Shift+Wheel -> Waveform dB end range adjust (when visible).
2016-08-09 17:01:05 +01:00
Paul Licameli
15004b1ade More uses of std::make_unique 2016-08-08 10:07:37 -04:00
Paul Licameli
a52f7f8410 new -> NEW in comments, so text search for naked new excludes them 2016-08-08 10:07:37 -04:00
Paul Licameli
60260520dc Remove some naked new amd delete in: TrackPanel 2016-08-08 07:38:30 -04:00
Paul Licameli
3b6dcfcc32 Remove some naked new amd delete in: TrackPanel::mAx 2016-08-08 07:38:30 -04:00
Paul Licameli
84c0337aba Fix TAB key navigation on Mac for all dialogs (not only for panels) 2016-07-10 17:12:27 -04:00
James Crook
763485b0dc Add error check comments.
These are places where we don't properly handle error returns.
2016-07-10 21:40:48 +01:00
Paul Licameli
15bb2f0434 Lower a piece of text box dragging logic out of TrackPanel...
... This might cause more redrawing of label tracks for left click without
Shift, but who cares.
2016-07-10 03:21:05 -04:00
Paul Licameli
06fd481815 Don't need to delay certain state changes of LabelTrack until drawing 2016-07-10 03:21:05 -04:00
Paul Licameli
7a7379c6fc Label text coordinate calculations don't need a window 2016-07-10 03:21:05 -04:00
Paul Licameli
f01fc64a2d More safenew, const functions, remove unnecessary members 2016-07-10 03:21:05 -04:00
Steve Daulton
70e0317daa Time Track scale choice as radio buttons 2016-07-07 11:49:52 +01:00
Paul Licameli
cc5d1036fa Pinch and spread gestures on Mac touchpad, if EVT_MAGNIFY is defined 2016-07-03 12:14:08 -04:00
Paul Licameli
550d96b1a2 Fix misbehavior after right click in label text 2016-06-30 00:46:54 -04:00
Paul Licameli
625584d99a Bug1431: Undocked toolbars should hide when project window minimizes 2016-06-29 15:13:38 -04:00
Paul Licameli
056a578f08 Fix commit dd786984db 2016-06-28 13:12:56 -04:00
Paul Licameli
ed2432e02d Bug1406: Don't make spurious undo entries in Envelope tool 2016-06-27 14:15:27 -04:00
Paul Licameli
28c31903e9 Update mixer board selection state correctly for undo/redo 2016-06-26 13:31:00 -04:00
Paul Licameli
4823244050 Bug1426: Better selection for key-modified clicks in TCP, Mixer board 2016-06-26 12:03:45 -04:00
Paul Licameli
ee7b3b2b89 Bug1426: Update mixer board for change of set of selected tracks 2016-06-26 11:24:11 -04:00
Paul Licameli
21431d1982 No longer need silly extra indirection to void a VS compiler warning 2016-06-26 10:45:57 -04:00
Paul Licameli
dd786984db Bug320: Better change of selection when Shift+Click in a track...
... But Shift+Click in the track control panel is still different:  se bug 1425
2016-06-26 10:39:29 -04:00
Paul Licameli
39063fba94 Guarantee default selection shows in Label Track's Font listbox...
On my Macintosh, with no audacity.cfg, selection is Lucida Grande when the
dialog opens.

Formerly, I saw no selection.
2016-06-23 13:45:22 -04:00
Paul Licameli
04377f71c6 Bug1249: Drag to rearrange tracks: don't halt at panel top or bottom 2016-06-21 17:03:25 -04:00
Paul Licameli
013bcf9635 Bug122: Dragging selected point label should update cursor 2016-06-20 23:13:35 -04:00
Taiki Kim
51557c8959 Record state modification when changing a track's spectrogram settings
Fixes Bug 1277.
2016-06-18 13:39:58 -07:00
Paul Licameli
bb7dba2b67 Shortcut keys can appear as intended in Track Control Panel menus...
... Delayed construction of the menus was needed.

So far this only affects the four menu items that move tracks up and down.
2016-06-12 00:00:04 -04:00
Paul Licameli
e4fadf4aaf Improve scrubbing speed control (2 finger swipe) on Mac 2016-05-28 11:59:22 -04:00
Paul Licameli
af7a92c2ab Improve scrub responsiveness: a secondary thread polls the mouse 2016-05-28 11:59:22 -04:00
Steve Daulton
0377a24f90 Comment out unused TrackPanel::BuildVRulerMenuItems function
The function builds pop up menus that are never displayed and
creates runtime debug warnings. It is left over from PRL's experiment
in 2.1.2 with a context menu for the vertical ruler.
2016-05-27 10:45:01 +01:00
Paul Licameli
4f9810cd1f Two-fingered horizontal swipe on mac touchpad scrolls the wave 2016-05-25 12:31:30 -04:00
Paul Licameli
ba883cbcf4 Improve responsiveness of drag seek during click-scrub...
.. by refreshing the TrackPanel window less often.
2016-05-23 18:37:42 -04:00
Paul Licameli
7e0de9a9bc Fix incidentals to Bug 1331, though not the bug itself...
... See comments #1 and #2 at
http://bugzilla.audacityteam.org/show_bug.cgi?id=1331

Don't make strange undo history if, e.g., R to record (or other keystroke
with undoable effects) interrupts a drag with undoable effects (like time
shift).  Ensure that by first simulating a mouse button up event to stop the
drag, before dispatching the keystroke.

Don't crash if certain other drags, that do not have undoable effects, such
as selection or vertical ruler drag -- are interrupted by a keystroke
command (Ctrl+C in particular could cause crash).  However, in these cases,
the drag is still allowed to continue.
2016-05-21 23:19:09 -04:00
Paul Licameli
6acb0f99b3 Fix minor error in some position to time calculations 2016-05-18 14:55:03 -04:00
Paul Licameli
80e19f2130 Ruler is in the ctrl+f6 cycle instead of reachable by arrows; experimental...
... flag for turning off navigability of the ruler.
2016-05-10 15:16:12 -04:00
Paul Licameli
5944391e24 Let's commit to EXPERIMENTAL_SCRUBBING_SMOOTH_SCROLL 2016-05-09 23:21:56 -04:00
Paul Licameli
3466e91ed1 Insert calls to DrawOverlays() on the ruler, though they do nothing yet 2016-05-09 11:37:32 -04:00
Paul Licameli
7c2a531486 New base classes of TrackPanel just for the bitmap backing and overlay system...
... to make it reusable by other classes.

Also, don't create a second DC when repainting TrackPanel.
2016-05-09 11:37:32 -04:00
Henric Jungheim
3c83eab4d7 Fix uninitialized pointer in TrackPanel.cpp 2016-05-06 22:17:16 -07:00
Paul Licameli
c616d433c2 Make key navigation to ruler work on Windows 2016-05-06 18:13:24 -04:00
Paul Licameli
519a2020ff Navigation to and from the ruler using up and down arrow keys...
... This affects those keys (and NUMPAD arrows), also (shift-)ctrl-f6,
ctrl-home, ctrl-end (which are command-left and right on mac)

Those should be tested to ensure correct restoration of the yellow rectangle,
appropriately in the tracks or the ruler.

This should also be tested with and without the Tracks preference for cyclic
movement of the focus.
2016-05-06 16:50:24 -04:00