1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-22 07:28:03 +02:00

334 Commits

Author SHA1 Message Date
Gale Andrews
195296f22f Add access key for new warning 2016-04-16 02:15:57 +01:00
Steve Daulton
5b968e8250 Fix bug 1374 2016-04-12 21:58:44 +01:00
Paul Licameli
2d7e21536e Sweep for filename copying: prefs and effects 2016-04-10 22:25:49 -04:00
Paul Licameli
70bd46b8ad travis 2016-04-09 22:55:15 -04:00
Paul Licameli
b28ec2957a Make EXPERIMENTAL_MIDI_OUT compilable, but it doesn't link 2016-04-09 15:10:05 -04:00
Steve Daulton
f536354330 Fix by Matěj Fiala for bug 1168
Thanks to Matěj Fiala for this fix.
2016-03-24 10:02:20 +00:00
Paul Licameli
dfc84d030c Fix warnings for out-of-order initializers, with in-class member initializers 2016-02-26 14:56:30 -05:00
Paul Licameli
60bcd7aea2 Fix warnings for unused variables and functions 2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
0ce4fe0b83 Sweep unnecessary wxString copies: prefs 2016-02-22 21:30:42 -05:00
Gale Andrews
af16636fe2 More accurate label for track name display
Feel free to tweak, but it was messing up docs to suggest it did not display in Spectrograms,
2016-02-19 23:52:25 +00:00
Paul Licameli
97a69e9ccc A few more safenew 2016-02-18 07:17:26 -05:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc Use macro safenew for many allocations of wxWindow subclasses 2016-02-14 20:20:19 -05:00
Paul Licameli
6052b5f9be Throw by value, catch by reference: don't use pointers...
... that's what the better books on C++ recommend.
2016-02-14 19:36:17 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Steve Daulton
d6b8080a5d Fix for bug 1313 2016-01-29 22:12:41 +00:00
Paul Licameli
1083c4a049 Bug1169 again: correct shuttling of spectrogram scale values with dialog on Apply 2016-01-26 23:57:32 -05:00
Paul Licameli
907c950a0e Bug1288: Don't crash when changing language to "Simplified"...
... but give a warning message about the unknown language.
2016-01-26 20:09:54 -05:00
Steve Daulton
8a6edf3623 Add custom track name defaults to preferences 2016-01-21 02:42:25 +00:00
Steve Daulton
159f0263f3 Update solo button defaults
As agreed by QA, the 'simple' behavior becomes the out-of-the-box
default, and 'standard' renamed as 'multi-track'.
2016-01-21 01:52:42 +00:00
James Crook
0d4b58ba1c Merge remote-tracking branch 'leland/master' 2015-12-26 14:57:24 +00:00
James Crook
94afd8265b Bug 1271 - Move the Audacity temp dir to a location not scanned by cleanup apps (Residual)
The residual issue here was that an old cfg could go on using the unsafe path.  So we check for the unsafe path at init and silently substitute the good path.  If the user attempts to re-instate the unsafe path we tell them no, with an informative message.  This change was made more complex by windows allowing different strings for the same path, specifically C:\Users\JAMESC~1\AppData\Local\Temp\audacity_temp contains the shortening '~' so in the function that tests 'IsTempDirectoryNameOK' we use GetLongPath() to always compare the expanded names.

I also changed directory prefs to add SessionData rather than audacity_temp on the new directory name, on windows when choosing a new temp directory.
2015-12-26 14:56:47 +00:00
Leland Lucius
9dd79c9f80 Remove flushing of preferences in ShuttlePrefs and only
flush when all settings have been written.
2015-12-21 20:07:24 -06:00
Paul Licameli
8d5841331b Bug1213: "Spectrogram" not "Spectrum" in tracks prefs.
This is a string change, however that string should be replicated elsewhere in\
the translation files.
2015-09-23 09:13:42 -04:00
Paul Licameli
6a1f830022 Bug1187: validate before Applying changes of spectrogram preferences 2015-09-08 10:28:34 -04:00
Paul Licameli
b84c1b322e Bug1169: end the separate treatment of lin vs. log display bounds for spectrum...
... also make WaveTrack responsible for storing and validating the bounds
... also let the bounds vary per-track even though other settings are default
... also change some code names to mention "period" not "undertone"
2015-09-06 21:47:14 -04:00
James Crook
fa5d9301f3 ERBS -> ERB
Accepted argument that ERB was technically more correct.  Searching graphs on the internet, you don't see 'ERBS'
2015-09-03 19:41:04 +01:00
Paul Licameli
9c483e2e86 Add (redundant) #include "Experimental.h" in all .cpp files using the symbols 2015-08-31 17:56:10 -04:00
Paul Licameli
1278b9644a Uniform naming of symbols in Experimental.h 2015-08-31 17:55:56 -04:00
Paul Licameli
d18553a3f0 Put Experimental.h (redundantly) in headers that rely on it 2015-08-31 17:53:12 -04:00
Paul Licameli
4dc4932efb Rename 1 / f scale to "Period" 2015-08-31 13:16:23 -04:00
David Bailes
1b6b354fc6 Remove the setting of the maximum size from the Preferences dialog.
The maximum size setting could introduce a horizontal scroll bar in the
keyboard preferences, making it awkward to read them.

The maximum size has been removed, but the initial, and minimum size
remain unchanged.
2015-08-27 15:35:07 +01:00
Leland Lucius
6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli
49ff3ae78f Be sure OK button of preferences dialog is default 2015-08-21 06:25:00 -04:00
Paul Licameli
b3f4050627 Group Spectrograms Preferences page under Tracks, again 2015-08-20 13:32:41 -04:00
Paul Licameli
1eef41607e Recode the Apply button of Spectrogram Preferences so it is next to OK/Cancel 2015-08-20 13:24:55 -04:00
Paul Licameli
8c58e0ea71 Update vertical ruler width correctly when applying view settings changes 2015-08-20 12:18:36 -04:00
Paul Licameli
b11f57a643 Fix bugs in retraction of Waveforms preferences page 2015-08-19 11:52:31 -04:00
Paul Licameli
4a704af03f Restore Waveform (dB) to Tracks preferences for default view mode 2015-08-19 10:21:09 -04:00
Paul Licameli
112d2a903b Rename View Settings... to Spectrogram Settings... and enable it only for...
... spectrogram views, and don't show the Waveforms page.
2015-08-19 10:21:04 -04:00
Paul Licameli
0a41a1eba2 Remove Waveforms page from Preferences, put Spectrograms back in old place 2015-08-19 10:21:02 -04:00
Paul Licameli
28d552c39b Prefs dialog, when constructed with a single page, does not show the tree 2015-08-19 10:20:59 -04:00
Paul Licameli
b9db3bd83d Define and use TranslatableStringArray. This lets you define "listeners"...
... for language changes, without inserting extra code to send the
notifications.
2015-08-17 12:04:21 -04:00
Paul Licameli
84ee685ee9 reassignment, internals, implementing time correction, but -- ...
... it does not yet interact correctly with caching, so results may be
slightly wrong if you scroll the view by less than a screen.
2015-08-17 09:17:46 -04:00
Paul Licameli
7113d533fb reassignment, internals, implementing frequency correction only 2015-08-17 09:17:45 -04:00
Paul Licameli
1f94d99c43 reassignment added to list of algorithms in settings and preferences 2015-08-17 09:17:42 -04:00
Paul Licameli
2855186408 fix a memory leak 2015-08-17 08:39:28 -04:00
Paul Licameli
5d2ccbc207 Don't use a "magic number" 2015-08-17 08:37:59 -04:00