Fixed by being more tolerant of window being (slightly) off screen. Windows 10 appears to mis-report the window size by 6 pixels. This fix allows the user to restore a window that is (slightly) off screen. That's OK and helps those users who position and size the window very precisely.
It turns out that having fixed the behaviour of Shift-Click on the Track Control Panel, I'd also fixed the behaviour of Shift-Click on the wave. But then I blew it by over riding the Shift-Click behaviour on wave to use the version that does NOT horizontally extend. This change comments out the 'bShift' and so gives us the original Shift-Click behaviour on wave, without undoing the other fixes.
Thanks to Walter Gladwin.
The comment said "Is this correct??" the answer is no. However the problem only showed when other fixes were made elsewhere, and Add Label at Playback Positions then stopped working when in Pause.
I first of all added a warning message if trying to configure while playing.
Then decided that it is more in keeping with current style to grey out the Spectrogram Settings menu item.
So the new warning message should actually never be reached.
Comment more cases of bad sampleCount truncation, and even worse...
Fix progress indicator again: must do a floating-point division...
A little more type agnosticism
Remove more unnecessary casts to sampleCount
Fix more narrowings of sampleCount
I had a microphone logo instead of Audacity headphones, but (a) it did not work so well in small sizes and (b) it lost some of the connection with Audacity, so I re-instated a more Audacity like headphones logo. The microphone can still be seen on the splash screen of the installer. I decided not to give the logo a white surround. The result is that on a dark windows toolbar it can almost disappear into the background, but becomes visible when you hover.
Caused by optimisation of NumericTextCtrl::ValueToControls(). It now only updates on a change, and because mValueStr was being updated without calling value to controls, the string was not being identified as having changed.
* sampleCount:
Remove unnecessary casts to sampleCount
Type agnosticism for some other variables that were not sampleCount...
Remove many mentions of sampleCount with auto and decltype...
Use sf_count_t not sampleCount
some uses of size_t
Use long long for argument passed to wxString::ToLongLong
More cautions in SBSMSEffect.cpp...
... This makes much code agnostic about how other things (functions and
arguments) are typed.
Many of these neeed to become size_t instead of sampleCount.
Also emphasise 'Audacity Manual' in the help menu.
With this change I'm being careful to make sure it's clear that the manual is for Audacity rather than for DarkAudacity. For the time being DarkAudacity is for people who know Audacity already and want to try the dark theme. Because of that, it is enough to highlight the differences between Audacity and DarkAudacity and link to the existing Audacity manual. If the differences continue to grow over time wit future editions, then I will need the promised 'Video Tutorials'. So I link to the page for them now. That page will have their up to date status information.
