1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-09 14:16:28 +01:00
Commit Graph

308 Commits

Author SHA1 Message Date
Paul Licameli
bbb93a7400 One more alternate play button image, for seeking 2016-06-02 15:55:16 -04:00
Paul Licameli
eafc416d55 Remove double-click and scrolling menu items for scrub/seek...
... Use the toggle button on the ruler instead
2016-06-01 13:30:01 -04:00
Paul Licameli
ff95bf1490 Remove double-click handling for scrolling play/record 2016-06-01 13:25:01 -04:00
Paul Licameli
e39da0c42b New preference for pinned play head, also in Transport menu 2016-06-01 13:25:01 -04:00
Paul Licameli
fecc6f53e4 Consolidate the code that starts and stops play/rec head scrolling 2016-06-01 13:25:01 -04:00
Paul Licameli
fbf09d2130 Make ToolBar button setup functions public and static 2016-06-01 11:50:34 -04:00
Paul Licameli
7d265dc3d4 Oops, revert unready work
Revert "new button images for time ruler"

This reverts commit 26ec0100a2.

Revert "add button"

This reverts commit af5163025a.

Revert "ToolBar::MakeButton is public and static"

This reverts commit 668714942b.
2016-05-29 12:13:24 -04:00
Paul Licameli
668714942b ToolBar::MakeButton is public and static 2016-05-28 22:55:15 -04:00
Paul Licameli
36e5b4fbbc AudioIOStartStreamOptions includes the sample rate 2016-05-22 15:27:35 -04:00
Paul Licameli
de13e27cdd Correction: commit 465b743fd3 fixes bug 1391 2016-05-18 11:11:23 -04:00
Paul Licameli
da8973570b Don't pop record up if you click it twice; also may fix moonphase...
... reported by Peter:  sometimes stop button gets disabled during record
2016-05-18 10:59:38 -04:00
Paul Licameli
e1f4ab6af6 Double-click record with overdub pins record head center not right 2016-05-17 13:21:39 -04:00
Paul Licameli
c66262d790 Double click on Record button pins record head right, not center 2016-05-17 12:25:39 -04:00
Paul Licameli
95ccc417d8 Scrolling display for (append-) record, if you double click 2016-05-17 01:47:52 -04:00
Paul Licameli
737e24e24e Allow pausing and unpausing of scrub. Just treat it differently internally. 2016-05-11 19:59:11 -04:00
Paul Licameli
c9b5f6bc37 Fix some display problems in scrolling play: mitigate scrollbar flashing, and...
... modified click on the transcription toolbar button leaves the button with
the correct appearance.
2016-05-03 23:37:59 -04:00
Paul Licameli
ad2b4c3446 Enable scrolling play by double-click on either play button or QP area of ruler 2016-05-03 22:46:10 -04:00
Paul Licameli
039aaa13a0 Play buttons can detect double clicks (but don't do anything special yet) 2016-05-03 21:28:39 -04:00
Paul Licameli
9ab0e42f29 Control scrub with motion, click, drag, wheel almost anywhere in main window...
... if the event is not handled and skipped by sub-windows first, such as for
toolbar button clicks.

(But track panel clicks are skipped even after doing something, so they may
also cause seeking besides other responses.  So click can seek AND set cursor.)

This is meant to make drag to seek and wheel for change of speed easier,
without needing to keep the mouse in the narrow time ruler.

Also lets you click in the ruler, then move in any direction, and not miss the
motion event that should start the scrub playback.

The event handling is a bit of a hack, using propagation.  It does not use
capture.
2016-04-26 12:12:06 -04:00
Paul Licameli
cd57e0a26c Scrubbing phase 2. Scrub starts with click on the indicator in the ruler...
... and works in any of the six tools.

Click and drag in select tool during scrub works just as when not scrubbing.

Seeks now only if you left-click or drag in the ruler, but this may change.

Mouse motion anywhere on the screen controls scrub as before.

No mouse clicks in TrackPanel are used by scrubbing.

The Ctrl-Click in TrackPanel is now unused.  Should 2.1.0 behavior be restored?
That was click to quick play, redundant with click in the (lower part of) the
ruler.
2016-04-26 12:12:06 -04:00
Paul Licameli
0071db6f53 Hide quick play indicator when other playback starts...
... but it can reappear when mouse moves.  You may still select a quick play
region during play, to jump playback.
2016-04-25 12:00:58 -04:00
Paul Licameli
d34715d6ad Various other drags could crash Mac debug build if you option-W. Fixed too...
... And I think this fix is now exhaustive.
2016-04-25 01:49:54 -04:00
Paul Licameli
6147705199 Vary status string (leftmost in the status bar) for the four kinds of scrub. 2016-04-24 16:13:07 -04:00
Paul Licameli
1fe0bbf7dc Uncheck scrubbing menu items whenever scrub stops (ESC key, Stop button, other) 2016-04-24 11:59:01 -04:00
Paul Licameli
42bdc274dd Resizing of meter toolbars (docked or undocked) responds to ESC key 2016-04-24 01:01:44 -04:00
Paul Licameli
fad249a603 ESC key can abort the rearranging of toolbars. 2016-04-23 22:10:02 -04:00
Paul Licameli
01001fdea9 New alternative appearance for the transport toolbar play button, for scrubbing 2016-04-19 17:34:38 -04:00
Paul Licameli
ce95bce85a Bug991: Pause button and command should be disabled during scrubbing...
... and they will be as soon as ctrl-mouse down.
2016-04-18 21:49:27 -04:00
Paul Licameli
4fc4f529a0 Bug1053: Meaningful status bar messages for scrubbing 2016-04-18 19:28:56 -04:00
Paul Licameli
d5915491b3 Bug1342: Loop-play (and other things) before scrub (and other things)...
... should not disable auto-scrolling of the window during playback.
2016-04-18 17:50:17 -04:00
Paul Licameli
8b7ae748a3 Scrub speed as overlay; scrub event handling details out of TrackPanel.cpp 2016-04-18 14:31:36 -04:00
Paul Licameli
b0c55e4386 Bug1358: On Mac, undocked toolbars and screenshot window should not vanish...
... when switching from Audacity to another application.
2016-04-11 06:44:38 -04:00
Paul Licameli
b28ec2957a Make EXPERIMENTAL_MIDI_OUT compilable, but it doesn't link 2016-04-09 15:10:05 -04:00
Paul Licameli
c78e91f6c1 Image manipulation functions return smart pointers 2016-04-06 16:06:34 -04:00
Steve Daulton
484f23dcc7 Fix for bug 814 2016-03-28 21:07:25 +01:00
Paul Licameli
a6ca36cdab TrackList holds smart pointers to tracks, Add() only takes rvalue refs to such 2016-03-26 15:41:31 -04:00
Paul Licameli
c5a70126eb TrackList always deletes tracks on destruction or when cleared 2016-03-26 15:41:29 -04:00
Paul Licameli
bc5519a0e2 TrackList::Remove and TrackListIterator::RemoveCurrent always delete the track 2016-03-26 15:41:26 -04:00
Paul Licameli
5ef4dd46a5 TrackFactory functions return std::unique_ptr, although some callers...
... release() them for now.
2016-03-26 11:50:12 -04:00
Paul Licameli
f42a953752 Track duplication methods return unique_ptr, although some callers...
... simply release() them for now.
2016-03-26 11:50:10 -04:00
Paul Licameli
aee12f5755 Define and use copy and move for TrackList, simplifying recording code 2016-03-07 06:43:42 -05:00
Leland Lucius
9dc9348127 Fixes bug #1344 (mac build)
In addition, the Xcode project can now build against the 10.6
or 10.7 SDKs.  All that is needed is to change the SDK version
and the other settings will change automatically.
2016-03-07 00:29:26 -06:00
Paul Licameli
eead25872e Simplify append-record code using TrackList copy and move 2016-03-06 10:41:09 -05:00
Paul Licameli
43790cfa56 std::vector for wave track pointers; remove deprecated TrackList function; ...
... and some more uses of const
2016-03-01 20:54:48 -05:00
Paul Licameli
0c9deb398c Fix mac build. No standard headers in Audacity.h. 2016-03-01 12:22:37 -05:00
Paul Licameli
60bcd7aea2 Fix warnings for unused variables and functions 2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
1c07741d57 Sizers are owned by wxWindow objects when added, so use safenew, or...
... use unique_ptr in the interim between building them and adding.

This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli
4d78e353c3 Revert "sizers"
This reverts commit 84c0a0b666.
2016-02-18 14:50:52 -05:00