Paul Licameli
b7fe62d170
Remove redundant #include-s from .h files...
...
Redundant, because transitively implied. But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:15:05 -04:00
Paul Licameli
f6adeed47b
Remove some unnecessary #include directives
2019-05-15 14:14:18 -04:00
James Crook
2366075fd4
Bug 2098 - Transport toolbar - no hovertext tooltip for the Pause button
2019-04-25 16:34:04 +01:00
Paul Licameli
2b32884596
Remove some unnecessary toolbar related declarations, fix comments
2019-04-23 17:02:04 -04:00
Paul Licameli
2e1fe80601
Remove or comment wxPanelWrapper.h in headers
2019-04-04 10:13:23 -04:00
Paul Licameli
4714d72b3f
Can't remove remaining wx headers from other headers, comment that
2019-03-31 01:41:16 -04:00
Paul Licameli
2e05d2d884
Remove wx/{radiobut,ownerdrw,menuitem,menu,listbox}.h from *.h
2019-03-30 12:15:53 -04:00
Paul Licameli
c982cf6a41
Remove wx/intl.h, wx/brush.h, wx/bitmap.h from headers
2019-03-30 11:45:20 -04:00
Paul Licameli
870c08ac06
Remove wx/{log.h, image.h, listctrl.h, utils.h} from headers
2019-03-30 11:21:51 -04:00
Paul Licameli
08c16b6eb7
Remove wx/{html/htmlwin,fileconf,dragimag,debug,dcclient}.h from *.h
2019-03-30 10:53:22 -04:00
Paul Licameli
ec2f26e48c
Remove wx/pen.h, wx/thread.h from headers
2019-03-30 10:17:18 -04:00
Paul Licameli
de60edc62f
Remove wx/{app,statbmp,spinctrl,scrolbar,dynlib,dcmemory}.h from *.h
2019-03-30 07:57:37 -04:00
Paul Licameli
d71a54b4e9
Remove wx/checkbox.h from headers
2019-03-28 12:55:34 -04:00
Paul Licameli
bcc2e0d13b
Remove wx/frame.h, wx/sizer.h, wx/access.h from headers
2019-03-28 11:21:15 -04:00
Paul Licameli
803d8b9559
Remove wx/filename.h, wx/choice.h, wxFileNameWrapper.h from headers
2019-03-28 03:12:42 -04:00
Paul Licameli
b8aea73c91
Remove wx/stattext.h from headers
2019-03-27 14:33:46 -04:00
Paul Licameli
4018b191b4
Remove Get/Set functions for selection bounds from AudacityProject
2019-03-27 13:32:53 -04:00
Paul Licameli
a915a510bd
include <wx/setup.h> in all files where wxUSE* macros are used...
...
... even if it's redundant; improving on what was done at b47e2f9
2019-03-23 14:56:02 -04:00
Paul Licameli
875f38cfa5
Correct mistake in DECLARE_CLASS macro...
...
... though it didn't really matter: the macro argument is in fact unused
2019-03-23 02:52:59 -04:00
Paul Licameli
577b70ddb6
correct a comment
2019-03-23 02:48:48 -04:00
Paul Licameli
f45300f032
This is only comments, in files where USE_ macros are tested...
...
... following the comment convention used in the preceding commit.
2019-03-22 12:38:30 -04:00
Paul Licameli
d261ea2558
Define and use utility template ValueIterator...
...
... generalizing the fix of commit 7591891 to other cases, making the iterators
safe for adaptation with std::reverse_iterator should the need ever arise
2019-03-18 08:44:40 -04:00
Paul Licameli
5e7d41ec07
Each .cpp/.mm file includes corresponding header before any other...
...
... except Audacity.h
This forces us to make each header contain all forward declarations or nested
headers that it requires, rather than depend on context.
2019-03-17 22:54:52 -04:00
Paul Licameli
906e55f047
Experimental.h in all .h or .cpp files that directly use EXPERIMENTALs...
...
... except Audacity.h; and in no others.
Do so even if Experimental.h gets multiply included, as in both the .h and
.cpp files.
This makes it easier to do a text scan to be sure there are no unintended quiet
changes of meaning because of omission of Experimental.h when the flag is
an enabled one.
Also move inclusions of Experimental.h earlier.
Also don't require Experimental.h to be preceded by Audacity.h to define
EXPERIMENTAL_MIDI_OUT correctly.
2019-03-17 22:54:00 -04:00
Paul Licameli
173a300427
Include nothing before Audacity.h, as comments say we should...
...
... and remove some duplicated inclusions
2019-03-17 21:41:39 -04:00
Paul Licameli
41175e94cd
Simplify by removing many std::move of shared_ptr to tracks...
...
... Don't need them, as we did with std::unique_ptr
2019-03-16 13:11:33 -04:00
Paul Licameli
a0aa69a248
All tracks allocated with make_shared, no more make_unique...
...
... so that we can use Track::SharedPointer without undefined behavior even on
tracks that don't yet belong to any TrackList.
Also fix the return type of function template TrackList::Add and remove some
casts.
2019-03-16 13:11:33 -04:00
Paul Licameli
6f89c48873
Reimplement Track::Pointer using std::enable_shared_from_this...
...
... now the Track need not be owned yet by a TrackList
2019-03-16 13:11:32 -04:00
Paul Licameli
dd86346156
ShuttlegGUI: const wxArrayStringEx & arguments, not wxArrayString *...
...
... for choice, combo, and listbox; reference allows passing temporaries,
eliminating need for some variables to hold the string arrays.
2019-03-16 07:17:21 -04:00
Paul Licameli
dcd82b8ef5
ShuttleGui::AddChoice takes int to specify selection, with a default...
...
... This makes things brief and where non-default avoids some repetition of
literal strings
2019-03-15 23:35:13 -04:00
Paul Licameli
5fd6965925
Use type aliases CommandID, CommandIDs...
...
... for identifiers of menu commands and macros, and for vectors thereof
2019-03-15 15:18:11 -04:00
Paul Licameli
dfeb7e18aa
Type aliases for some uses of ComponentInterfaceSymbol...
...
... to be replaced later with distinct types
Also changing FamilyId => Family in function names
Also NumericFormatId => NumericFormatSymbol
2019-03-14 17:26:20 -04:00
Paul Licameli
50074f2cfe
Replace comparisons against "" with empty()
2019-03-14 13:23:41 -04:00
Paul Licameli
da33daf197
Some replacements of wxArrayString with auto
2019-03-10 14:47:12 -04:00
Paul Licameli
dd8eb9e3d9
Less use of wxArrayString::Index() ...
...
... instead use the utility make_iterator_range and its index() or contains()
method. This generic utility works with any container defining begin() and
end().
This further lessens dependency on wxWidgets container idioms.
2019-03-10 14:45:06 -04:00
Paul Licameli
c68e336247
More use of std:: style members of wxString...
...
... replacing:
Length => length
Len => length
2019-03-10 14:44:54 -04:00
Paul Licameli
2db49dc1f0
Use standard library style members of wxArrayString (and wxString) ...
...
... which will make it easier to change the types of those containers to
std::vectors of other string-like classes
for wxString,
IsEmpty => empty
Clear => clear
Alloc => reserve
for wxArrayString,
Count => size
GetCount => size
IsEmpty => empty
Add => push_back
Clear => clear
Empty => clear
Sort => std::sort (only with default comparator)
SetCount => resize
Last => back
Item => operator []
Alloc => reserve
2019-03-10 14:43:57 -04:00
James Crook
b5d4a828d1
More doxygen
2018-11-04 14:21:00 +00:00
James Crook
466e9c179e
Create ComponentInterface
...
It combines the old IdentInterface with the ParamsInterface, providing an identifier and parameters (if needed).
The main purpose of the change is to make the class hierarchy (as viewed via doxygen) much easier to follow.
2018-11-02 17:04:43 +00:00
Paul Licameli
303553ae4e
Take class AdornedRulerPanel out of src/widgets...
...
... It's not a utility widget like RulerPanel. It has a lot of application
specific logic in it.
2018-10-24 15:04:41 -04:00
Paul Licameli
16ab48079b
Don't include CommandManager.h in other headers
2018-10-18 09:25:14 -04:00
Paul Licameli
399e2d099d
Fix spelling in an enum constant name
2018-10-17 12:53:25 -04:00
Paul Licameli
a7df004a88
Don't include Project.h or ODTask.h needlessly in other header files
2018-10-16 17:36:38 -04:00
Paul Licameli
ce9f2e2538
Include Menus.h directly, only where needed, not via Project.h
2018-10-16 16:45:26 -04:00
Paul Licameli
fc6570646d
MenuCommandHandler is not a base class of MenuManager...
...
... This forces a better placement of state variables in the appropriate
classes.
In future perhaps, MenuManager should be splintered into several classes, one
for each of the main toolbar menus.
2018-10-16 13:01:22 +01:00
scootergrisen
b4f7946e9b
Remove some double space
2018-10-14 10:42:01 +01:00
James Crook
7e5a716e65
Fix C4458 Warnings
...
C4458 is 'Declaration hides class member'
2018-10-10 19:46:25 +01:00
James Crook
657159d542
Fix C4189 and C4100 Warnings
...
C4189 is 'Local variable initialised but not used'
C4100 is 'Unreferenced parameter'
Fixed some other warnings, e.g. about empty if, too.
2018-10-10 19:46:24 +01:00
Paul Licameli
beebe648fb
Remove more uses of Track::SetLinked() and Track::SetChannel()
2018-10-01 13:42:36 -04:00
Paul Licameli
fee0f284fe
Rewrite many iterations over tracks and channels in src/toolbars
2018-10-01 11:25:07 -04:00