1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-03 17:19:43 +02:00

166 Commits

Author SHA1 Message Date
Paul Licameli
adc2695688 i18n-hints about the name "Nyquist" ...
... Although "Nyquist" is a proper name, still, translators should have
discretion to transliterate it into another alphabet, and also make it
consistent with longer translated strings containing it.

Not so for debug messages mentioning actual keywords of Nyquist programming.
2017-09-10 19:15:46 -04:00
Steve Daulton
da3f28118b Fix: Nyquist PEAK property when NIL & Stereo
Fixes failure of Nyquist Generate effects when stereo track
selected and no time selection.
2017-08-08 11:55:47 +01:00
Paul Licameli
f0de38dec1 Scanned for bad naked new; found none; changed comments, used safenew 2017-07-23 09:35:01 -04:00
Steve Daulton
3aab1939f0 Fix Nyquist message logging
Incorrect use of wxLogMessage can cause crash on Windows
if '%' present in debug string.
2017-07-07 14:12:26 +01:00
Steve Daulton
cbe554e10a Ensure Nyquist Prompt initialises mName 2017-07-02 12:33:08 +01:00
Steve Daulton
a0eba9fb95 Set Nyquist default latency to 100 ms
The default for Standalone Nyquist is a very conservative
300 ms, but that's too long when using ALSA (see bug 570),
so use 100 ms default (same as Audacity).
2017-06-22 11:11:17 +01:00
Steve Daulton
1123ca293c More tweaks to Nyquist debug output 2017-06-13 18:30:07 +01:00
Steve Daulton
b92866be71 Nyquist debug handling tweaks 2017-06-13 01:06:19 +01:00
Steve Daulton
9816cc8c7b Reinstate FileNames::PlugInDir() for Linux
Reverting its removal in commit 1dd6b848c28.
Path added to Nyquist *SYSTEM-DIR* PLUG-IN property.
2017-06-04 18:01:49 +01:00
Steve Daulton
b6a1ca916b Fix for bug 376
Documentation required.
2017-05-30 20:43:50 +01:00
Steve Daulton
73d2478d0b Rename Nyquist plug-in debug button header 2017-05-30 20:43:50 +01:00
Steve Daulton
eea55f78ce Make Nyquist debug window resizable
and name window to match the effect.
2017-05-25 23:16:41 +01:00
Steve Daulton
0303d281cc Fix for bug 1650
Don't attempt to read plug-in file when spawned from Nyquist Prompt
because there isn't one.
2017-05-23 23:38:55 +01:00
Steve Daulton
04ba10a1c3 Add help button support for other Nyquist effects 2017-05-21 23:11:21 +01:00
Steve Daulton
bba5a8fef1 Add help button for Nyquist Prompt 2017-05-20 14:49:07 +01:00
Steve Daulton
1dd6b848c2 Enable Help button for Nyquist effects 2017-05-20 14:49:07 +01:00
Steve Daulton
469120cebd Enable help button for effects 2017-05-20 14:49:07 +01:00
Steve Daulton
ae24cab8fe Remove 'TODO's for completed documentation 2017-05-01 18:51:35 +01:00
Paul Licameli
0d7250578d Other methods of WaveTrack return void, will throw on failure instead 2017-03-31 18:26:52 -04:00
Steve Daulton
a9879bddf0 Refactor clipfix.ny to fix multiple problems
Basically a rewrite based on the original algorithm.
2017-03-31 00:01:18 +01:00
Steve Daulton
260044bcb0 Ffix wx assert in debug build 2017-03-22 20:26:39 +00:00
Paul Licameli
70d9e4bdc7 GetMinMax, GetRMS functions take a mayThrow argument, return numbers 2017-03-21 14:19:02 -04:00
Paul Licameli
22a12c6852 Exception safety in: some effects and generators...
... Those that directly call WaveTrack functions in their Process() routines,
which might throw exceptions for disk space exhaustion.
2017-03-21 14:11:25 -04:00
Paul Licameli
8e5975b10d Report read exceptions met in SBSMS and Nyquist callbacks to user...
... without letting them propagate through the libraries.
2017-03-17 17:53:03 -04:00
Paul Licameli
6525bb18cf Translate exceptions to error codes in callback functions...
... That is what the library protocols allow, and libraries may be written
in C and might corrupt their state if C++ exceptions pass through them.
2017-03-17 17:53:01 -04:00
Paul Licameli
ac246d0468 Fix bug 1566 differently (signed/unsigned comparison) 2017-03-17 17:52:37 -04:00
Paul Licameli
004df48438 Make Effect::mTracks private 2017-03-17 17:52:25 -04:00
Steve Daulton
b66675d71c Restore legacy Nyquist plug-in PEAK-LEVEL property 2017-03-01 18:14:30 +00:00
Steve Daulton
f19b79f5c3 Consistency: 'plug-in' not 'plugin'
but retain deprecated / legacy form in code for compatibility.
2017-03-01 18:14:30 +00:00
Steve Daulton
67810d35bf Bug 1573 - Multi-line SAL scripts fail in Nyquist Prompt 2017-02-24 18:51:17 +00:00
Steve Daulton
81dd23bd16 Bug 1566 - Incorrect error message if Nyquist returns mono sound as an array
and quieten a load of compiler warnings.
2017-02-24 18:50:30 +00:00
Steve Daulton
1a5a025b70 Update Nyquist v4 property lists and comments
Comments added where documentation is required.
2017-02-24 18:50:28 +00:00
Paul Licameli
b17a14ccc2 Nested loop should use a different index variable...
... but there was not a bug here, because of the return.
2016-09-20 06:32:45 -04:00
Paul Licameli
078ff056e2 Make many conversions sampleCount->size_t are explicit and checked...
... with run-time assertions.

I examined each place and reasoned that the narrowing was safe, and commented
why so.

Again, there are places where the sampleCount variable will later be changed
to have a different type, and they are not changed here.
2016-09-15 21:02:32 -04:00
Paul Licameli
78be459fa1 Convert sampleCount <-> floating or -> long long explicitly ...
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.

Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.

Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
2016-09-15 21:02:31 -04:00
Paul Licameli
67cec5ad83 Make many counts of tracks and channels unsigned...
... And in some places where a library uses signed types, assert that
the reported number is not negative.

What led me to this, is that there are many places where a size_t value for
an allocation is the product of a number of channels and some other number.
2016-09-07 10:11:41 -04:00
Paul Licameli
79c79f9cd3 Remove many mentions of sampleCount with auto and decltype...
... This makes much code agnostic about how other things (functions and
arguments) are typed.

Many of these neeed to become size_t instead of sampleCount.
2016-08-24 14:50:45 -04:00
Paul Licameli
1281f1b14b Common function limits buffer size to sampleCount known to be small 2016-08-23 12:46:10 -04:00
Paul Licameli
a6de680cdb use std::min and std::max 2016-08-22 21:45:54 -04:00
Paul Licameli
1189cfd62a Identify the few unsafe narrowing conversions from sampleCount...
... I believe this list of four places is exhaustive.

There are many, many more safe narrowings that I examined.

This resulted from changing the definition of sampleCount in my builds so that
narrowing conversions failed to compile without some fixes, and I examined and
fixed every place.

The rest of that work is not yet shared.
2016-08-21 15:28:32 -04:00
James Crook
b1526fbdc8 Change strings for clarity/consistency.
Changes suggested by (translator) scootergrisen
2016-08-19 19:30:21 +01:00
Paul Licameli
e599cfa6fa Effect::mOutputTracks is managed by smart pointer 2016-08-13 10:37:51 -04:00
Paul Licameli
a400a7408c Distinguish whether clip ptr arrays own; vector; const-correctness 2016-08-12 20:53:38 -04:00
Paul Licameli
84c0337aba Fix TAB key navigation on Mac for all dialogs (not only for panels) 2016-07-10 17:12:27 -04:00
Benjamin Drung
9e78a41faf Use std::isinf() instead of isinf()
Audacity fails to build on Ubuntu 16.04 with g++ 5.3.1 (using C++11),
because isinf() is not defined. Thus use std::isinf() instead.
2016-05-15 09:04:35 +02:00
Paul Licameli
2d7e21536e Sweep for filename copying: prefs and effects 2016-04-10 22:25:49 -04:00
Paul Licameli
2696da89cb One more use of smart pointer object SampleBuffer, in Nyquist.h...
...Leaving no "naked" DeleteSamples.  Only SampleBuffer::Free now calls it
directly, and SampleBuffer calls Free in its destructor.
2016-04-10 00:07:21 -04:00
Paul Licameli
a6ca36cdab TrackList holds smart pointers to tracks, Add() only takes rvalue refs to such 2016-03-26 15:41:31 -04:00
Paul Licameli
5ef4dd46a5 TrackFactory functions return std::unique_ptr, although some callers...
... release() them for now.
2016-03-26 11:50:12 -04:00
Steve Daulton
919712e3f7 Fix default EffectTypeProcess for Nyquist Prompt
Nyquist Prompt did not default to process type if a previous script
in the current session set a different type.
2016-03-14 09:22:25 +00:00