... also restore the intended meaning of "allowDup" (for debugging checks only),
which had never been properly implemented because the label, not the
accelerator, was scanned for it; see commit f2f7568
... and recompute popup menu tables that depend on preferences.
The code for labels in the rulers was unsatisfactory because
(1) rescanning and editing the post-translation strings is a hack to avoid, and
(2) separating the hints like "Shift-Left-Click" with a tab character made them
invisible on Mac. So instead, append strings like " (Shift-Left-Click)"
... because the two macros have the same expansion, and are both checked for
in the --keyword arguments passed to msgfmt by locale/update_po_files.sh.
This commit makes ONLY such changes, and comments in Internat.h. It is big
but quite harmless.
The intention is to introduce a type distinction in a later release, by defining
XXO differently. XXO is used where & characters in strings (for hotkeys of menu
items or control prompts) are permitted, XO where not.
Shift+Drag of a point could convert the point to a micro range label.
That's fixed now. Shift+Drag on an existing micro label will now preserve
that label's length, without coalescing the spots. That's intended, and
is needed for advanced users who use shift-drag to preserve length.
... Moved many misplaced ones, which msgfmt would not have extracted into
audacity.pot.
Duplicated some of them, to appear with related but distinct msgids.
Added a few new comments.
Deleted one that was no longer needed in ProjectManager.cpp.
Fix was provided by Hans Petter Selasky with the following comment:
This is a regression issue after:
Move the scrub mouse event handler into ScrubUI...
Where:
if (mWindow)
mWindow->PushEventHandler(&mForwarder);
was removed from the Scrubber() constructor function and
not from the ~Scrubber().
- The TCP cursor is indicating both selection and dragability, so we use the arrow (as UI for tabs does, which are selectable and draggable).
- When actually dragging, we use the clenched fist icon, not the new clenched fist with the fingers cut off icon (aka snowball icon).
Currently AudioIoCallback::ScrubState::Get(), inserts a period of silence the first time it's called because at this time Scrubber::ContinueScrubbingPoll() has not been called, and so message.end has not been set to an appropriate value.
In the case of keyboard scrubbing and play-at-speed, the initial speed is already known, so message.end can be set to this value, removing the need for an initial silence.
The start of keyboard scrubbing and play-at-speed are now faster (the latter very much faster).
... Now they are treated more alike:
Each is shown or hidden (not enabled or disabled) as the corresponding sub-view
of the wave track is shown or not.
Each has separator lines above and below.
They are shown (one or the other or both) after the choices for sub-views, and
not near the bottom of the menu.
This makes the TCP menu one item shorter in the default case that you view only
waveform.
