1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-13 08:06:32 +01:00
Commit Graph

13 Commits

Author SHA1 Message Date
Paul Licameli
a9e7a7e5d5 movable_ptr(_with_deleter) -> std::unique_ptr 2018-05-10 00:56:37 -04:00
Paul Licameli
473e955da3 Remove some naked new amd delete in: ondemand 2016-08-08 07:53:28 -04:00
Paul Licameli
7c0073dd77 Unreported bug: memory and file handle leak when importing custom mpeg...
I could see this on windows:

Import a file such as .aiff format, while "Files of type:"
reads "FFmpeg-compatible files".
Leave Audacity running.
Attempt to delete the file in Windows Exploerer.
Get a message from Windows that the file is in use by Audacity and cannot be
deleted.
2016-04-09 00:21:38 -04:00
Paul Licameli
c9d50dc20b ODTask cloners return smart pointers 2016-04-06 16:06:36 -04:00
Paul Licameli
cbd561be7d Make EXPERIMENTAL_OD_FFMPEG compilable, and change some memory management 2016-04-02 00:02:52 -04:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
richardash1981
393129d9b9 fix the line endings on this file, and set svn:eol-style to native so they stay fixed 2013-01-01 15:54:53 +00:00
v.audacity
24af4febea Bug 539 (P2) - Audacity does not build if configured --without-ffmpeg
Revert to quick fix of r 11867. Steve reports Debian build error with r11868. Left that code in, because this should override it.
2012-07-25 06:20:17 +00:00
v.audacity
d90e6c5285 Bug 539 (P2) - Audacity does not build if configured --without-ffmpeg
more pinpointed fix that should close this
2012-07-25 02:00:48 +00:00
mchinen
5a5957b422 Add seek support to OD-based FFmpeg import.
Also some minor refactoring.
This feature works with mp3 right now - may work on other formats, but that will be a seperate commit.
It is not enabled so most of the changes won't even be compiled, and those that do won't be run.
To enable it uncommment the EXPERIMENTAL_ODFFMPEG def in Experimental.h
2010-07-05 14:38:47 +00:00
mchinen
b07f23d6de added on-demand support for non-seeking loading of FFmpeg files. This feature is not on, controlled by ifdefs via the #define EXPERIMENTAL_OD_FFMPEG in Experimental.h 2010-03-19 14:57:10 +00:00