Paul Licameli
0c9deb398c
Fix mac build. No standard headers in Audacity.h.
2016-03-01 12:22:37 -05:00
Paul Licameli
70c1d57591
More const qualifications, and mutables, for functions that draw tracks...
...
... The display related members that had to become mutable are probably
ones that don't belong in the track classes, ultimately.
2016-02-27 12:35:17 -05:00
Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
74121c1494
Comment a questionable function
2016-02-26 12:35:31 -05:00
Paul Licameli
6a3d99a8e6
travis
2016-02-24 21:14:19 -05:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
09b4dfc5a2
travis
2016-02-24 13:52:21 -05:00
Paul Licameli
2efa24bc10
Sweep unnecessary wxString copies: widgets
2016-02-22 21:30:04 -05:00
Paul Licameli
1c07741d57
Sizers are owned by wxWindow objects when added, so use safenew, or...
...
... use unique_ptr in the interim between building them and adding.
This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli
4d78e353c3
Revert "sizers"
...
This reverts commit 84c0a0b666
2016-02-18 14:50:52 -05:00
Paul Licameli
84c0a0b666
sizers
2016-02-18 02:54:50 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464
More uses of safenew for classes we derive from wxWindow classes...
...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc
Use macro safenew for many allocations of wxWindow subclasses
2016-02-14 20:20:19 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Paul Licameli
daa7617e88
auto_ptr (deprecated) -> unique_ptr (preferred in C++11)
2016-02-13 12:00:28 -05:00
Paul Licameli
488ccf143e
Fix small memory leak in Ruler.cpp
2016-02-02 11:47:58 -05:00
Paul Licameli
17c9369286
Bug1239: Correct time rulers after importing files (with File>Open) ...
...
... The fisheye stuff was to blame.
2016-01-26 18:09:29 -05:00
Paul Licameli
ad586b3e69
Bug36, partial: Redraw mixer board when meter range preference changes
2016-01-21 10:22:24 -05:00
Steve Daulton
57d1f5583d
Fix for bug 661
...
Introduce *DECIMAL-SEPARATOR* global for Nyquist.
Improvements to numeric validation error messages.
Fix *TRACK* START-TIME and END-TIME properties for tracks with different
length channels.
Update Adjustable Fade, Regular Interval Labels and Vocal Removal
to use numeric text inputs.
This does NOT fix bug 1020.
2016-01-21 01:29:56 +00:00
David Bailes
13f13490e6
Fix for Bug 1267 - Accessibility: some panels used for graphics are included in tab traversal
...
Bug due to update and wxWidgets bug 1267.
Fix is to add the override of AcceptsFocusFromKeyboard().
2015-11-26 15:21:48 +00:00
Leland Lucius
48c5c47214
Fix for bug #1219
2015-10-05 23:43:00 +01:00
James Crook
39cc1fbc23
Bug 1204 - Crash when pressing both mouse buttons over toolbar buttons
...
Looks a very safe fix. Post 2.1.2 should review ALL uses of CaptureMouse().
2015-09-21 23:11:55 +01:00
Leland Lucius
93aeca9a48
Fix for bug #1203
2015-09-16 13:08:03 -05:00
Leland Lucius
2f9c7d1567
Fix for bug #1190
2015-09-16 13:04:26 -05:00
Leland Lucius
2d88ad63e0
Fix for bug #1191
2015-09-08 11:24:59 -05:00
Leland Lucius
33cce4eba9
Added reference to bug in comments
2015-09-03 02:38:49 -05:00
Leland Lucius
6cfce50a60
Fix for bug #1173
...
Basically, just restored a bit of code to the ProgressDialog
that I'd removed during the conversion now that it's understood
what is actually happening.
2015-09-03 02:33:41 -05:00
Paul Licameli
1278b9644a
Uniform naming of symbols in Experimental.h
2015-08-31 17:55:56 -04:00
Paul Licameli
d18553a3f0
Put Experimental.h (redundantly) in headers that rely on it
2015-08-31 17:53:12 -04:00
Leland Lucius
ab5eb8a558
Fix for bug #1102
2015-08-27 02:30:46 -05:00
Leland Lucius
3dec7153a3
Fix missing QP indicator on wxGTK/GTK3 combo.
2015-08-25 16:07:59 -05:00
Leland Lucius
6a9dae20f5
Appearance on OSX is now back to normal or better
...
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli
1b8f44d053
ViewInfo does not redundantly (or inconsistently!) store the screen width
2015-08-21 22:39:18 -04:00
Paul Licameli
a9ab31dedb
Allow NULL arguments in TrackPanel::GetTracksUsableArea()
2015-08-21 12:02:48 -04:00
Leland Lucius
1f6ba9160c
Fix ghost image on track panel for real this time
2015-08-19 15:37:52 -05:00
Leland Lucius
a80c20c9b2
Revert "Fix ghost image on track panel"
...
This reverts commit b19ed258e9
2015-08-19 15:37:27 -05:00
Leland Lucius
b19ed258e9
Fix ghost image on track panel
...
Thanks to David for tracking down the cause, the ghost has
been banished.
2015-08-19 15:29:54 -05:00
Leland Lucius
a4802f48b1
Fix wx3 related crash and remove wx2 ifdef'd code
2015-08-19 00:37:03 -05:00
Leland Lucius
0fe7b22103
Revert to appmodel progresss dialogs only
2015-08-17 21:49:45 -05:00
Leland Lucius
a36e51b4c2
Fix bug #1143
2015-08-16 14:03:46 -05:00
Leland Lucius
13c7484458
Fixes some focus issues under wxGTK and bug #1116
2015-08-14 16:15:28 -05:00
Steve Daulton
2cb32c763f
Fix for bug 558
2015-08-13 13:06:12 +01:00
Leland Lucius
ebc801f864
Revert "Disable autocreation of Xcode schemes"
...
This reverts commit c15ca44eff
2015-08-10 02:18:29 -05:00
Leland Lucius
c15ca44eff
Disable autocreation of Xcode schemes
2015-08-10 02:02:50 -05:00
Leland Lucius
7d88a693f4
No need to redisplay if already on screen...prevents flashing
2015-08-09 06:15:08 -05:00
Leland Lucius
3064f1715f
Better tooltip for ASlider
...
This fixes the problem on GTK where the text was unreadable when
using a "dark" theme.
And fixes the double display of the real tooltip and the tip panel
being displayed at the same time on GTK and OSX. It seems that
the "disabling/reenabling" of tooltips doesn't take affect right
away anymore...maybe it never did.
2015-08-09 06:03:42 -05:00
Paul Licameli
cfdbc35990
Bug 1132: Time shift should not snap to starting positions of moving labels
2015-08-08 16:10:33 -04:00
