This reverts commit 048c1b8c5a92e68ca9de67d25098400ab32ab68c.
I observed that it was not all right if you switch between Audacity versions, as
some cautious upgraders might do:
Delete audacity.cfg.
Open 2.2.0 and quit.
Open 2.1.3 -- and observe that the scrubbing and combined meter toolbars appear,
one over the other, at top left. Combined and separate meter toolbars are not
meant to appear at the same time.
Quit 2.1.3 and open 2.2.0. Now those two toolbars appear at some other random
seeming positions.
Summary of fix:
1. In ToolManger::WriteConfig, for a docked toolbar which is hidden, the dock number is not set to the dock number rather than 0 (undocked)
2. In ToolManger::ReadConfig, for a hidden docked toolbar in the config, the toolbar is docked, but is not included in the dock's configuration.
... This does not address all the ones they recently noted, but only such
changes as I thought not too sweeping for this late stage.
More may be addressed in the next release.
... "Light" was used in two different meanings, but one place was the obsolete
Leveller effect, whose code is removed now. (I leave the files in place, to
make it easier for the curious to know it was once there, and find its history.)
i18n-hints added for the surviving use of "Light" to name a theme, and also for
some of the other themes.
... including titles of dialogs,
messages,
About sub-menu of the Manage button,
long-form names of Undo items (in history view),
message for why command is not allowed when there is no selection
Also one place in Effect Rack code but it's commented out
... Although "Nyquist" is a proper name, still, translators should have
discretion to transliterate it into another alphabet, and also make it
consistent with longer translated strings containing it.
Not so for debug messages mentioning actual keywords of Nyquist programming.
... but bringing back some naked calloc and free that weren't replaced quite
right, and I'll figure out why later.
This reverts commit e94fa1d65e5555b78cae164f7b9ca5a6f363d8b8.
This reverts commit 0c7e467a081fb998d183bdc169cd8ddd69648b25.
... There are two in AboutDialog.cpp, but these strings aren't actually used.
There are two in InconsistencyException.cpp, which ought never to be seen by
users, but should be treated as high priority bugs if they are.
There is a very old one in Sequence.cpp, which was never internationalized and
was only written to the log and likewise ought to be eliminated from happening
in pre-release testing.
Therefore, though this is a minor breach of string freeze, it's only the second
one above that users might ever see, and then only if a serious bug escaped.
... I am not sure that this will solve all problems of jittery play, but I do
think this will solve the problem of a rush of slightly late notes at start of
play.
... and hoping it is positively helpful for Linux.
In AudioIO::MidiTime(), compute one of the terms by different means.
Use PaStreamInfo::outputLatency.
Do not use the difference of PaStreamCallbackTimeInfo::outputBufferDacTime
and PaStreamCallbackTimeInfo::currentTime.
Which debugging shows is very nearly the same value for Windows and Mac.
But we suspect the PaStreamCallbackTimeInfo fields are not correctly reported
on Linux.
... though they do have a messy interaction with Undo if recording that should
be fixe.
You may get an undo history item that not only restores the gain and pan, but
removes a part of the recording.
