1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-11 22:51:06 +02:00

7681 Commits

Author SHA1 Message Date
Pokechu22
19b11c09fe Fix cut preview with note tracks 2017-07-16 11:07:29 -04:00
Pokechu22
8a02687b5f Fix velocity offset edge case
If the velocity of a note was, for instance, 30, and the velocity slider was at -30, then you'd get a data2 of 0, which wouldn't be clamped (and would produce a note off).  However, if the note were 29 or 31, you'd get a velocity of 1.  This makes it so that note ons always have a velocity of at least 1, even in that edge case.
2017-07-16 11:07:28 -04:00
Pokechu22
896d5d682b Fix drawing MIDI channels with IDs greater than 16
PRL mentioned a while ago that it was possible to get channels greater
than 16 via allegro files.  This makes those channels correctly work with
the CHANNEL_BIT macro (which was supposed to handle them this way before).
2017-07-16 11:07:28 -04:00
Pokechu22
62ebb2f95d Remove unused and unneeded MIDI methods and variables
The fields in AudioIO are simply unneeded (commented out, declared but never implemented, or otherwise unused).

mLastMidiPosition (in NoteTrack) looks like the vestiges of a far older attempt at MIDI playback; the field itself is completely unused though so it is safe to remove it.
2017-07-16 11:07:28 -04:00
Pokechu22
437de15098 Add more method and field documentation
Mostly for MIDI-specific areas, and general AudioIO fields.
2017-07-16 11:07:28 -04:00
Pokechu22
bd294ea4ed Midi diag mentions conditional compilation flags, but only in ALPHA 2017-07-16 11:06:13 -04:00
Pokechu22
681161f60b Add MIDI device diagnostics
* MIDI Device Info menu item, like Audio Device Info

 * MIDI device info in crash reports

 * Only enabled with EXPERIMENTAL_MIDI_OUT, but tracks info related to the (unimplemented) EXPERIMENTAL_MIDI_IN
2017-07-16 10:58:53 -04:00
Paul Licameli
053b0b583d Fix highlight of TCP menu button after command 2017-07-16 00:55:16 -04:00
Paul Licameli
ca83b06e84 fix i18n-hint 2017-07-15 21:11:44 -04:00
Paul Licameli
5644bed8bd No TrackPanel tooltips for now, may later reenable selected ones...
... perhaps for the TCP buttons, to make their behavior consistent with toolbar
buttons.
2017-07-15 20:50:34 -04:00
Paul Licameli
e55393af69 Fix assertion when cancelling from selection drag 2017-07-15 20:50:00 -04:00
Paul Licameli
7a038c9e51 Remove tab key target cycling and snap escape; reimplement for Esc 2017-07-15 20:37:39 -04:00
Paul Licameli
d3572ebe10 Same tolerance for hitting clip boundaries as for selection snap 2017-07-15 14:12:32 -04:00
Paul Licameli
89c8e8ac39 null checks 2017-07-15 14:05:03 -04:00
Paul Licameli
38fd97b8e2 Fix "C" linkage of PaUtil_GetTime (TOUCHES lib-src !) 2017-07-15 13:32:42 -04:00
Paul Licameli
e81df8314f more use of final 2017-07-15 12:05:47 -04:00
Paul Licameli
c5fc8eef03 Revert "Split lines now only show over middle third of track height."
This was the fix for Bug 800 now considered unsatisfactory.

This reverts commit dc1193a0af83f1d43de5a30aea6b6b09087eea58.

(Some merge resolution was needed)
2017-07-14 23:09:41 -04:00
Paul Licameli
7b93a3afe2 Whoops, we lost the non-multi draw tool! Fix that. 2017-07-14 23:05:44 -04:00
Paul Licameli
812f3649de Bug 1685: garbage status bar messages and tooltips, scrub in Windows 2017-07-14 23:02:32 -04:00
Paul Licameli
558efda20c A null check 2017-07-14 23:02:20 -04:00
Paul Licameli
52d8dc1525 Bug1682, maybe: More careful treatment of some Envelope corner cases 2017-07-14 22:49:46 -04:00
Paul Licameli
8fae9802dc Prohibit use of inherited TrackList::clear() 2017-07-14 22:30:02 -04:00
Paul Licameli
8bf3791edf TrackList constructed only by factory function, to avoid more trouble 2017-07-14 21:55:32 -04:00
Paul Licameli
84a6bad8a0 In a user visible message: TAB > Tab 2017-07-14 20:56:49 -04:00
Paul Licameli
903cebafe1 Bug1669: Close and Menu buttons should never disappear...
... As they did with Ctrl+Shift+F, with a certain minimimum number of wave
tracks that depends on screen resolution.  On my Macbook, that was 13 tracks.

This bug was a consequence of James' TCP layout changes making buttons a little
taller plus my changes to hide any top controls for which there is not
sufficient height.

The fix makes the height of tracks after Ctrl+Shift+F a bit more (44 pixels
not 40) than in 2.1.3.

This fix also replaces some more "magic numbers" with calculation from
tabled data about TCP layout.
2017-07-14 12:03:16 -04:00
David Bailes
2185b42d84 Selection bar drop down list box: Fix name read by Jaws screen reader
Problem: If the accessibility name of a control is empty, Jaws may use nearly text for the name - in this case Audio position.

Fix: Set the accessibility name to "\a".
2017-07-14 16:35:37 +01:00
Paul Licameli
4a500c77dd Bug1636: fix Crash on OK selecting RIAA or Telephone Eq curve...
... Really two crashes, one in case Linear frequency scale is selected, the
other if Logarithmic.

Problem was introduced at commit 7d5e54e364fcccd630274f2658703543d8c596eb
2017-07-14 11:18:29 -04:00
Paul Licameli
54af4f1ff7 More precautions about the back-pointers of tracks to their lists 2017-07-14 10:03:11 -04:00
Paul Licameli
e9cb5056f1 More guards against recursive event dispatches causing surprises...
...like the problem fixed at commit f9865f39efe46224a1a77c742a789b2cc70f0c54
2017-07-14 09:59:47 -04:00
Paul Licameli
9ad15dabe1 Bug1683: crashes applying Nyquist effects to stereo tracks 2017-07-14 09:22:22 -04:00
David Bailes
a4f1c2cb9f Keyboard commands for clip boundaries: change to screen reader message
Change to message when clips are next to each other.
2017-07-14 11:19:42 +01:00
Paul Licameli
aaed921fd3 Track panel tooltips, including TAB key hint...
... and distinguish snapping or not in Select tool.
2017-07-13 22:46:28 -04:00
Paul Licameli
9072628b4c Preview selection snap lines before click; toggle them with TAB...
... also stop making the finger cursor at merge lines, because this prevew
supersedes that visual aid.

Toggling of snap lines can apply both to start and end of selection.
2017-07-13 12:30:34 -04:00
Paul Licameli
0ba91ea9a5 Don't make the finger cursor when hovering over the split line...
... which was implemented at commit aa8be0c413d107e3fd03e0b85bdf097b2ed37de9

Preview snap lines should make that unnecessary.
2017-07-13 12:29:54 -04:00
Paul Licameli
2150bde578 Implement selection snap lines before click, and TAB to cancel them 2017-07-13 12:29:51 -04:00
Paul Licameli
b7ae012ece A single UIHandle can define multiple rotation states 2017-07-13 12:11:25 -04:00
Paul Licameli
4eece4b0b1 Extras like snap guidelines can be drawn for targets not yet clicked 2017-07-13 12:11:13 -04:00
Paul Licameli
33c6a77f8c SelectHandle gets snap information in hit test 2017-07-13 12:11:13 -04:00
Paul Licameli
49b04208b3 ChooseBoundary takes separate x and y arguments 2017-07-13 12:11:13 -04:00
Paul Licameli
7903e20143 Rewrite SelectHandle snapping; selection really matches snapped start 2017-07-13 12:11:13 -04:00
Paul Licameli
67282cbb61 SnapManager::Snap returns its results in a struct 2017-07-13 12:11:13 -04:00
Paul Licameli
ac10dc13d5 Construct SnapManager with const TrackList 2017-07-13 12:11:12 -04:00
David Bailes
5f49892d61 Keyboard commands for moving clips: minor fix
Problem: the commands did not take into account that for a stereo track, the clip boundaries in the two channels can be different.

Fixed.
2017-07-13 16:32:55 +01:00
Paul Licameli
f24a704a5b Fix TAB key cycle with cutline in Select tool 2017-07-13 10:52:37 -04:00
Paul Licameli
4d1ce201e4 Make TAB key act as before, when a Label track has focus. 2017-07-13 08:09:39 -04:00
Paul Licameli
5e4f453a81 Fix crashes when ESCaping a drag 2017-07-13 07:03:30 -04:00
Paul Licameli
6c0b3bb1bf Shift+TAB cycles hit test targets backwards 2017-07-12 16:39:14 -04:00
Henric Jungheim
8d13bf1d83 Update _MSC_VER #if block for VS2015+ 2017-07-12 21:06:30 +01:00
Henric Jungheim
f1213e453e Use the _DEBUG flag instead of __wxDEBUG__ for selecting the link libraries.
The include directories are determined by the configuration, which
is indicated by _DEBUG.  Using __wxDEBUG__ means that the
debug libraries might get used with the release includes (or the
reverse).
2017-07-12 21:04:41 +01:00
Henric Jungheim
3b39bdeca5 EffectDialog can't have a default constructor.
The base class does not have one.
2017-07-12 21:03:43 +01:00