Paul Licameli
55439247ad
All the catches are in place for BlockFile and other errors, now throw.
2017-04-03 23:32:40 -04:00
Paul Licameli
987b038fd8
Exception safety in overrides of WriteSummary
2017-03-21 17:23:35 -04:00
Paul Licameli
98d1468a01
BlockFile::ReadData overrides: on failure, pad with 0s or throw...
...
... as the mayThrow argument directs.
2017-03-21 14:19:03 -04:00
Paul Licameli
70d9e4bdc7
GetMinMax, GetRMS functions take a mayThrow argument, return numbers
2017-03-21 14:19:02 -04:00
Paul Licameli
f5fe9281e4
Strong safety guarantee for removing file dependencies
2017-03-21 14:11:26 -04:00
Paul Licameli
2677796b0c
Zero and return false for all failures to read block file summary...
...
... Though in the only place where these summaries are used, which is
Sequence::GetWaveDisplay, we ignore the correctly reported error code anyway.
Also RAII in management of relevant memory buffers and mutexes.
2017-03-20 17:49:03 -04:00
Paul Licameli
e6db1a57a3
Remove naked new[] in: blockfile and commands
2017-03-17 17:52:46 -04:00
Paul Licameli
aebaaf46a0
require unsigned arguments for Array(s)Of::reinit
2017-03-17 17:52:43 -04:00
Paul Licameli
a4a9df5c03
One function for the common parts of BlockFile::ReadData overrides
2017-03-17 17:52:27 -04:00
Paul Licameli
ad04187a41
Change sampleCount arguments, variables, return values to size_t...
...
... whenever they really describe the size of a buffer that fits in memory, or
of a block file (which is never now more than a megabyte and so could be fit in
memory all at once), or a part thereof.
2016-09-15 21:03:17 -04:00
James Crook
e39cdce0fc
Merge remote-tracking branch 'walisser/upstream'
2016-09-12 12:22:36 +01:00
Paul Licameli
2a2013cb4b
More decltype and auto, mostly for loop index variables
2016-09-06 20:46:25 -04:00
Paul Licameli
919d77d176
More uses of min and max
2016-09-06 20:46:25 -04:00
Paul Licameli
c9bff2f0f4
BlockFile::GetSpaceUsage() returns an unsigned value
2016-09-06 12:39:57 -04:00
Darrell Walisser
5f8c48d520
use std::isnan since c++11 provides it and wxIsNan is broken in c++11
2016-09-04 17:00:12 -04:00
Paul Licameli
79c79f9cd3
Remove many mentions of sampleCount with auto and decltype...
...
... This makes much code agnostic about how other things (functions and
arguments) are typed.
Many of these neeed to become size_t instead of sampleCount.
2016-08-24 14:50:45 -04:00
Paul Licameli
367ed1dfce
Uniform init in blockfile ctors (prevents implicit narrowings)
2016-08-22 21:45:54 -04:00
Paul Licameli
8b72bd2f92
Manage block files with std::shared_ptr, BlockHash stores weak_ptr
2016-08-16 12:29:59 -04:00
Paul Licameli
84ccdca5c3
Gather balance info hashes into one struct guarded by an accessor...
...
Doing BalanceInfoDel in this delayed fashion will be needed when the other
call to it is eliminated, as shared_ptr simplifies the management of BlockFile
and makes the many calls to Ref and Deref disappear.
2016-08-16 12:29:59 -04:00
James Crook
763485b0dc
Add error check comments.
...
These are places where we don't properly handle error returns.
2016-07-10 21:40:48 +01:00
Paul Licameli
b81efbb816
Remove duplicated, inaccurate RMS calculations
2016-06-22 10:12:24 -04:00
Paul Licameli
80f7902976
More exact last RMS value in BlockFile's 64K-sample summaries
2016-06-22 10:11:57 -04:00
Steve Daulton
03915b4438
Fixes to Analyze Contrast
...
Now supports stereo tracks. Several tweaks to error messages,
validation logic, and accuracy improvements.
Includes a fix for summary64K (incorrect rms drawn on zoomed
out waveform).
2016-06-21 22:07:50 +01:00
Paul Licameli
3d102a3390
Access BlockFile::mFileName without copying, with proper multithreading cautions
2016-04-17 13:58:21 -04:00
Paul Licameli
b6fdffbab2
Don't copy wxFileName often, it's not lightweight! Use wxFileNameWrapper...
...
... which is a new class that defines moves.
2016-04-16 11:57:39 -04:00
Paul Licameli
f94b3b3afa
Add some const qualifiers to BlockFile methods
2016-04-10 21:05:20 -04:00
Paul Licameli
70bd46b8ad
travis
2016-04-09 22:55:15 -04:00
Paul Licameli
1108c1376c
Fix possible memory leak in use of overrides of BlockFile::CalcSummary
2016-04-05 23:30:33 -04:00
Paul Licameli
0c9deb398c
Fix mac build. No standard headers in Audacity.h.
2016-03-01 12:22:37 -05:00
Paul Licameli
a8652c5e74
uses
2016-02-25 20:18:31 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Paul Licameli
321d5259a2
More uses of SampleBuffer, eliminating explicit DeleteSamples calls
2016-02-01 10:16:00 -05:00
Paul Licameli
d39eaa4e65
Remove WaveTrack.h from other headers
2015-07-28 10:02:05 -04:00
benjamin.drung@gmail.com
277932dccb
Remove trailing spaces.
2014-06-03 20:30:19 +00:00
RichardAsh1981@gmail.com
6758caa5e1
Make a large number of global variables static so they only have file scope when that is all they need. Part of a patch by Campbell Barton
2013-09-21 19:11:41 +00:00
martynshaw99
2268f6f1e9
Fix summary values for edge cases when overall signal does not straddle zero line.
2012-05-05 20:57:50 +00:00
v.audacity
a6cb3debe9
(bug 113)
...
Comments about what's wrong with the DirManager::ProjectFSCK "Missing Aliased Files" dialog actions and what to do about it. (More to follow!)
Changed PushState for project repair from "Repair" to "Project Repair" to distinguish from Repair effect.
renames for clarity
2010-08-01 00:04:23 +00:00
v.audacity
8f8504b5a6
some progress on bug 113, including rewordings DependencyDialog based on some suggested by Gale
...
code cleanup
naming improvements for clarity (e.g., aliasedFileName instead of aliasedFile for an instance of wxFileName -- it's not an instance of AliasedFile)
parens, not square brackets, for parenthetic phrases
2010-07-28 23:06:10 +00:00
BusinessmanProgrammerSteve
47e5a2b80a
Update documentation and add checks surrounding block files
...
(since we now have silent block files with no disk file)
2010-05-08 00:58:23 +00:00
ra
e74978ba77
Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches
2010-01-23 19:44:49 +00:00