Paul Licameli
3015a9c8d9
Track cut and copy functions return a unique_ptr argument...
...
... Because they are factory functions.
2016-03-26 11:50:13 -04:00
Paul Licameli
5ef4dd46a5
TrackFactory functions return std::unique_ptr, although some callers...
...
... release() them for now.
2016-03-26 11:50:12 -04:00
Paul Licameli
5162ab5c5b
Use TrackFactory in more places...
...
... There should now be no direct allocation of Track subclasses with new,
except in those classes' own methods
2016-03-26 11:50:09 -04:00
Paul Licameli
7ed4c050cb
Fix unused argument warning
2016-03-15 00:09:36 -04:00
Paul Licameli
4cf9e0e6d6
Bug1354: Importing MIDI via Import Audio... and list-of-files should undo...
...
... also fixes a possible memory leak in direct Import MIDI... along the
failure path.
2016-03-14 11:02:09 -04:00
Paul Licameli
48a5f55179
More const qualifiers, for copying of tracks, and replacing in lists of tracks
...
... (the tracks may be const, not the list, when replacing)
2016-02-27 17:30:30 -05:00
Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
88eeebcb8b
Undoing and redoing of Tags...
...
Use reference counting (in std::shared_ptr) to avoid replicating Tags with each
Undo state.
2016-02-24 19:25:39 -05:00
Paul Licameli
e12a060751
Define UndoState
2016-02-24 19:10:40 -05:00
Paul Licameli
73ced7b93f
Remove UndoManager.h from other headers
2016-02-24 19:10:34 -05:00
Paul Licameli
0c182c3c0b
Shrink the command functor objects by using more subclasses...
...
... Let virtual function dispatch do the work, don't write our own dispatch!
2016-02-24 15:17:06 -05:00
Paul Licameli
cf3daebff6
Reviewed allocations of wxMenuBar items.
2016-02-20 20:23:54 -05:00
Paul Licameli
e0c88b1e53
Remove needless indirection for more little structures, in CommandManager...
...
... Also use std::shared_ptr for functors to simplify resource management
2016-02-18 20:19:27 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464
More uses of safenew for classes we derive from wxWindow classes...
...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Steve Daulton
76403ba5f9
Fix residual issue for bug 1313
2016-01-30 15:45:35 +00:00
Steve Daulton
d6b8080a5d
Fix for bug 1313
2016-01-29 22:12:41 +00:00
Paul Licameli
074d0daf3d
Revert "Bug1299: Shouldn't lose track focus after applying a chain."
...
This reverts commit a44ff801a6deb8fa259c073057e35b736c1c3272.
2016-01-27 14:55:49 -05:00
Paul Licameli
a44ff801a6
Bug1299: Shouldn't lose track focus after applying a chain.
2016-01-26 20:49:59 -05:00
Paul Licameli
2550a59c0e
Bug1282: Hide "Stereo to Mono" from menu when disabled by plugin manager...
...
... so you can't crash by selecting it!
2016-01-26 19:38:04 -05:00
Paul Licameli
17c9369286
Bug1239: Correct time rulers after importing files (with File>Open) ...
...
... The fisheye stuff was to blame.
2016-01-26 18:09:29 -05:00
Paul Licameli
4d2f4bbd69
Buig1307: Misbehavior posting mono into stereo
2016-01-23 18:27:43 -05:00
Paul Licameli
39399d6d8c
Bug30: Safer fix avoids crashes!
2016-01-23 11:35:37 -05:00
Paul Licameli
116ea61d11
Bug30: During playback, after CTRL+M, chars, ENTER -- restore track focus.
2016-01-21 10:18:41 -05:00
Steve Daulton
34f141e956
Align clips from Split New to sample times
2016-01-21 03:10:26 +00:00
Steve Daulton
1d6d08c47d
Don't push effects that can't be undone onto the Undo Stack
2016-01-21 02:07:28 +00:00
James Crook
eece31e1d4
Manage... -> Add / Remove Plug-ins...
...
Wording change requested and discussed in http://bugzilla.audacityteam.org/show_bug.cgi?id=1018
2015-09-05 11:24:14 +01:00
Paul Licameli
1278b9644a
Uniform naming of symbols in Experimental.h
2015-08-31 17:55:56 -04:00
Paul Licameli
01fe404a02
Move track permuting details out of TrackPanel.cpp
2015-08-29 13:46:35 -04:00
Paul Licameli
f49dbae9e2
Move minimize and close details out of TrackPanel.cpp
2015-08-29 13:46:26 -04:00
Paul Licameli
45e91f165a
Move gain and pan details out of TrackPanel.cpp
2015-08-29 13:46:16 -04:00
Paul Licameli
6bfd3ee54a
Move Mute and solo details out of TrackPanel.cpp
2015-08-29 13:45:51 -04:00
Leland Lucius
ce07211424
Fix layout of Resample dialog
2015-08-28 11:36:52 -05:00
Paul Licameli
e7482c74bd
Move cursor moving functions out of TrackPanel
2015-08-27 21:22:41 -04:00
Paul Licameli
6c6fc360ca
Put the scroll-beyond-zero flag in just one place, ViewInfo
2015-08-26 23:17:20 -04:00
Paul Licameli
bf41739222
a comment pointing to commits that might have fixed a mysterious problem
2015-08-21 22:54:35 -04:00
Paul Licameli
1b8f44d053
ViewInfo does not redundantly (or inconsistently!) store the screen width
2015-08-21 22:39:18 -04:00
Paul Licameli
a9ab31dedb
Allow NULL arguments in TrackPanel::GetTracksUsableArea()
2015-08-21 12:02:48 -04:00
Leland Lucius
ef95285af2
Add missing Transport EndMenu()
2015-08-16 06:28:12 -05:00
Leland Lucius
e119ffcd78
Do NOT generate keyup, use the system one
...
David has been trying to beat it into my thick skull that the
command manager should use the system created key up event rather
than generating it, but I just wasn't getting it.
Actually, the documentation for the OSX method I needed to use
to get at the key event before the menus did said that a key up
event couldn't be captured on 10.6 (the oldest we support). But,
testing showed that it can be, so I was able to do what David was
suggesting.
2015-08-12 18:05:50 -05:00
Leland Lucius
04d026e5bc
Further fixes for keyboard handling
...
I'm pretty sure this gets all of the currently known issues, including
the SHIFT+M not working, the Play buttons responding to SHIFT and CTRL,
the ESC key canceling drags, and I'm pretty sure it even fixes
but #784 .
2015-08-10 13:15:15 -05:00
Leland Lucius
4cd7757cf4
Batting 1000 tonight...make sure navigation works on Windows.
2015-08-04 22:41:52 -05:00
Leland Lucius
e4bb5082bc
Fix Shift+M shortcut
...
Related to an old bug/workaround where I couldn't figure out the
reason it act as it did on Winodw. Finally figured out it was the
KEY_UP event passing the "M" on to the menu, thus selecting the
Mono item.
2015-07-30 16:04:38 -05:00
Leland Lucius
37168ebbf6
Merge remote-tracking branch 'upstream/master' into wx3
2015-07-28 15:06:25 -05:00
Leland Lucius
5bdfcff97d
Menu shortcut hiding has been removed
...
It had been causing problems in Unity for a while now and they
were missing on OSX as well in wx3. So, the old menu Open/Close
method of hiding has been removed and replaced with an event
filter/monitor which looks for wxEVT_CHAR_HOOK events to pass
key events to the handler that has the keyboard captured.
2015-07-28 14:35:09 -05:00
Paul Licameli
d39eaa4e65
Remove WaveTrack.h from other headers
2015-07-28 10:02:05 -04:00
