1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-10 09:01:13 +02:00

57 Commits

Author SHA1 Message Date
Paul Licameli
8be1e8fdad Remove wxArray(Int|Long|Double) except where wxWidgets fns need it 2018-02-21 19:33:31 -05:00
Paul Licameli
080dd34e61 Get rid of wx object arrays, use std::vector 2018-02-21 19:33:27 -05:00
Paul Licameli
2b3be3208e Fix repaint of Mixer board after change of track name...
... Problem was introduced in 2.2.0 at commit dc05b94

Also, in MixerBoard, change name whenever changing the label, which might
matter to screen readers.
2018-02-07 05:16:29 -05:00
Paul Licameli
7fd78183d2 Remove needless uses of wxString::c_str() in wxString::Format...
... and similar wx "variadics," which all treat wxString smartly enough that
you don't need this.

Don't need c_str either to convert wxString to const wxChar * because
wxString has a conversion operator that does the same.
2018-01-01 20:34:33 -05:00
Paul Licameli
ccb4bbac33 Translate "Message" as default title of message box...
... This required a sweeping change of all calls to wxMessageBox!  But it seems
safe to me, despite the great number of touched files.
2018-01-01 17:50:02 -05:00
James Crook
f463eda36c Clean up some dead code and MSVC warnings.
- Dead code from experiments in SelectionBar removed.
- Many warnings about unused parameters fixed with WXUNUSED()
- Many warnings about signed / unsigned comparisons cleaned up.
- Several 'local variable declared but not used' warnings fixed.
2017-12-08 15:20:39 +00:00
James Crook
a49f14ad02 doxygen. Class list completed for letter 'A'. 2017-11-09 18:32:29 +00:00
Paul Licameli
70b5076b0b Fix some untranslated prompts and messages...
... Even if some commented out.  Such don't enlarge the .pot file, but make
them right in case they are ever un-commented.
2017-09-10 19:24:41 -04:00
James Crook
dd02a02c25 Mask for XPM RegisterImage()
Per conversation on http://forum.audacityteam.org/viewtopic.php?f=50&t=96765
I'm not convinced, but the function is unused, so it is a net plus to add this code with a comment.
2017-08-16 20:49:32 +01:00
James Crook
cd0ac7d7ef Bug 1715 - Theme change in the case of multiple open windows is only complete in the foreground window. 2017-08-14 15:36:16 +01:00
James Crook
dc05b94fd1 Bug 1701 - Mac: Text descriptors in Selection Toolbar become invisible after Open command
Problem was that on mac enable/disable clears the colour back to black.
The easiest workaround was to create a new class auStaticText that does all that we
need for wxStaticText.
2017-08-13 23:04:13 +01:00
James Crook
00f6ee2fc3 Const 'fix' no longer needed, thanks to Paul's fix.
Paul's change to DYLD_LIBRARY_PATH initialisation fixes the const issue.
2017-07-28 14:49:56 +01:00
James Crook
00f865860e LightTheme fix, but without the const.
To narrow down the Mac 'wrong library invoked' bug.
2017-07-26 15:37:31 +01:00
James Crook
188886f4da Revert 'Possible fix for Mac library issue.'.
The ',' on the end of the data was not creating a rogue zero entry.
So adding ImageSize-- was incorrect.
2017-07-25 21:17:46 +01:00
James Crook
6513fcf2ca Possible fix for Mac library issue.
Fix off by one error in size.

Git-bisect indicated a problem (on Mac only) caused by a change in an image file.
It's possible that this is an error in code that we have 'got away with' until now.
We always have an extra zero on the end of the image data and included it in the count of the
size of stream to unpack.  For a particular image this may have triggered a memory corruption
problem.
2017-07-25 20:53:42 +01:00
Paul Licameli
f0de38dec1 Scanned for bad naked new; found none; changed comments, used safenew 2017-07-23 09:35:01 -04:00
James Crook
60405eb7fe Theme Tweaks
- Highlighting of Buttons in TCP and Sliders
- No crinkly Help Icon anymore
- Invisible numbers in NoteTrack fixed
- Better visibility of label track dragger elements
- Theme rearranged more logically, and dead images culled
2017-07-19 15:27:00 +01:00
Henric Jungheim
48edd2298a Put the theme data in .rdata/.rodata 2017-07-12 20:47:12 +01:00
James Crook
11f9a8bb00 "Hi Contrast" -> "High Contrast" 2017-07-02 09:39:44 +01:00
James Crook
64a28861a0 Make light theme default.
Or as our RM said, 'Let it be Light'.
2017-06-09 19:40:29 +01:00
Paul Licameli
0d899b0163 compiler warning fixed 2017-06-09 13:14:41 -04:00
James Crook
62f75eb159 (Hi-DPI) No longer upscale ImageCache
I found a couple of problems working with upscaled image caches.

Firstly in GIMP a 'size 4 square pencil' is not 4x4, which makes editing an upscaled image very fiddly.
Secondly the wxIMAGE_QUALITY_NEAREST algorithm is not as dumb as I need it to be, and it is doing some blending when rescaling.  This leads to loss of image quality in some cases.

So when we do switch to Hi-DPI support, we need to be 'all in' and only be downscaling in Audacity, not upscaling too.
2017-05-22 13:46:05 +01:00
James Crook
978f09ba13 Lose unused images from theme. 2017-05-13 18:38:16 +01:00
James Crook
c0f835b67b Add border around theme Images. Do fixups.
Adding an orange border around the images in a theme makes it much easier to cut and paste in the correct position.  I've also expanded the internal images and fixed up a few image details - the pins/bobbins on darker themes, and the light blue rather than dark blue for negative times.
2017-05-04 21:41:18 +01:00
James Crook
e7f95e2be0 A small step towards HiDPI
The image cache that users work with should now have 'pixels' that are 4x4.   This will in time allow us to have large or small versions of all buttons, and also means we have hi resolution images for HiDPI screens.  The actual cost of the extra size should be small, as compression will see lots of repetition.

The main point of doing this now is so that new contributed themes can be HiDPI from the start.
2017-05-04 16:56:32 +01:00
James Crook
9d501f69d6 Add preference for Record being to new track. 2017-05-01 12:04:27 +01:00
James Crook
6102c774ee Bug 1630 - Accessibility of the length/end radio buttons
For Light and Classic themes that use black text, we'll use the length/end buttons because Windows uses black for text.
For Dark and HiContrast themes that use a light colour for text, we'll use the length/end buttons IF the OS is set to use the exact same colour for text.
That for example happens if we use Microsoft's HiContrast2 and our HiContrast theme.

If the OS and theme text colour differ, then if we set blend theme colours option, which is the default, we might still use the OS colour for text in Audacity.  That will happen if the OS colour has decent contrast to our theme's background colour.   Decent is defined as more than 250 difference in RGB values.  If we use the OS colour for text, then we get the proper length/end buttons.

Note that this adds a new feature to the theme blending, in that the text colour will often adapt.  Useful when using custom text colours with HiContrast2.  When the text colour adapts, we will continue to get proper length/end buttons.

Advice to users is to match OS and Audacity themes, and use the blend option.  When themes don't match, it may be desirable to disable blending.
2017-04-28 15:49:02 +01:00
James Crook
e08ceaf099 Add background to numbers on meter, IF meter bar and number colour is too similar.
This happens in Hi-Contrast theme.
2017-04-26 16:28:41 +01:00
James Crook
6bcbe417e9 Make SelectionBar end/length radio buttons behave normally
They had lost the focus/voice-over functionality because I added code to draw them in the
theme colour.  Now I disable that code, IF recolouring is both set and active.  This will happen
for example, if Hi-Contrast is used with the Hi-Contrast system theme.
2017-04-26 15:58:50 +01:00
James Crook
d0bafebfdf Fix posterisation. Add blend themes option.
Posterisation was caused by having a bright theme cache and using a darker theme (in linux) so the light colours 'got stretched' and showed up the relatively few distinct values there.  So the Classic theme is now darker, and we expect (on Windows) that it will be recoloured to windows lighter colours.
2017-04-24 18:33:46 +01:00
James Crook
a868d0c118 Add Hi-Contrast Theme 2017-04-10 12:09:38 +01:00
James Crook
06816684df Recolour light theme if system theme clashes.
On some Linux the default theme has dark grey drop downs, which can't be recoloured (limitation in wxWidgets) and that looks bad with the built in light themes (Classic and Light).  So in these cases the theme's light colour and light buttons get recoloured.

Custom themes and dark theme don't get recoloured.
2017-04-10 08:51:45 +01:00
James Crook
c44e5a281a Add missing include. 2017-04-08 16:26:03 +01:00
James Crook
f508439a42 Recolour Classic theme to wxSYS_COLOUR_3DFACE
This is mainly for Linux which can have a much darker main bar in Classic theme.
2017-04-08 14:49:10 +01:00
James Crook
fefc856901 Update slider in tracks on theme change. 2017-04-05 20:16:12 +01:00
James Crook
c17a7f535e Improve repainting after a theme change.
Now most things repaint properly after a theme change.  The sliders on the tracks don't yet.
2017-04-04 14:43:47 +01:00
James Crook
028ed19d90 Sync with DarkAudacity 2017-04-02 23:07:13 +01:00
Paul Licameli
1126925438 Remove naked malloc (or similar) and free in: various 2017-03-17 17:52:54 -04:00
James Crook
545d741eb2 Make Audacity source more like DarkAudacity source. 2016-09-11 13:03:37 +01:00
Paul Licameli
efc0e67934 Theme Preferences, Save Files overwrites all components after asking 2016-05-30 16:30:39 -04:00
Paul Licameli
8d8c7b7f00 Calls to time ruler button creation/update, but it does nothing yet 2016-05-29 12:14:17 -04:00
Paul Licameli
f9da767cbd Remove a friend declaration from Project, privatize a pointer member...
... and make implementation of that pointer a smart one.
2016-04-11 14:42:57 -04:00
Paul Licameli
f00144e9a5 Sweep for filename copying: various 2016-04-10 22:26:28 -04:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
James Crook
3f4a9191ec __WXMAC__ -> __APPLE__ in Theme.cpp #ifdef
This change helps macports and is (apparently) neutral for the platforms we build for.  See:
https://trac.macports.org/ticket/47189#comment:35
2016-02-08 21:47:59 +00:00
Paul Licameli
d703a5b054 travis 2015-07-28 10:21:41 -04:00
james.k.crook@gmail.com
7324997db6 Fix for http://bugzilla.audacityteam.org/show_bug.cgi?id=643 "Residual consistency issues with SHIFT showing Loop Play button icon" by Paul Licameli.
* Loop play-at-speed and cut preview play-at-speed implemented.
* Shift or ctrl down now affect all relevant buttons, loop or cut preview, normal or at speed, and append-record.
2014-11-29 17:22:05 +00:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00