Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d
Replace virtual with override wherever possible; eliminate needless virtual...
...
... for functions in final classes.
override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.
There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030
Harmlessly qualify classes as final (or explicitly comment not)...
...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls. Mostly useful as documentation of design intent.
Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
99f161c36c
Sweep unnecessary wxString copies: effects
2016-02-22 22:31:47 -05:00
Paul Licameli
1c07741d57
Sizers are owned by wxWindow objects when added, so use safenew, or...
...
... use unique_ptr in the interim between building them and adding.
This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli
4d78e353c3
Revert "sizers"
...
This reverts commit 84c0a0b6663a1210be502a76ab9c48dd330b3919.
2016-02-18 14:50:52 -05:00
Paul Licameli
84c0a0b666
sizers
2016-02-18 02:54:50 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464
More uses of safenew for classes we derive from wxWindow classes...
...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc
Use macro safenew for many allocations of wxWindow subclasses
2016-02-14 20:20:19 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Paul Licameli
97e8fe3864
include <algorithm> to fix Windows build
2016-01-21 10:41:03 -05:00
Steve Daulton
46055cde25
Fix effect preview issues
...
Fixes bug 1274 and unblocks bug 995.
2016-01-20 18:19:11 +00:00
David Bailes
13f13490e6
Fix for Bug 1267 - Accessibility: some panels used for graphics are included in tab traversal
...
Bug due to update and wxWidgets bug 1267.
Fix is to add the override of AcceptsFocusFromKeyboard().
2015-11-26 15:21:48 +00:00
Paul Licameli
9c483e2e86
Add (redundant) #include "Experimental.h" in all .cpp files using the symbols
2015-08-31 17:56:10 -04:00
Leland Lucius
6a9dae20f5
Appearance on OSX is now back to normal or better
...
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Leland Lucius
b31aad8323
Fix for bug #1117
...
Previous fix didn't produce the same results as 2.0.6, this one
should.
2015-08-16 00:15:55 -05:00
Steve Daulton
2cb32c763f
Fix for bug 558
2015-08-13 13:06:12 +01:00
Leland Lucius
f3ef8a27c7
Experimental RTP for Phaser and Wahwah
...
This can be disabled by undefining EXPERIMENTAL_REALTIME_AUDACITY_EFFECTS
in Experimental.cpp
2015-08-01 07:03:02 -05:00
Leland Lucius
1e195ecea6
Fix many wx3.1.0 assertions now to prevent double testing
2015-07-30 02:05:23 -05:00
Leland Lucius
37168ebbf6
Merge remote-tracking branch 'upstream/master' into wx3
2015-07-28 15:06:25 -05:00
Paul Licameli
d39eaa4e65
Remove WaveTrack.h from other headers
2015-07-28 10:02:05 -04:00
Leland Lucius
3fe146f306
Merge remote-tracking branch 'upstream/master' into wx3
2015-07-19 18:00:02 -05:00
Paul Licameli
e70f91c64e
Removed ShuttleGui.h from other headers
2015-07-19 12:31:03 -04:00
Steve Daulton
78d0347be2
More complete fix for bug 1060 issues
2015-07-18 18:31:36 +01:00
Leland Lucius
47f8d10de3
Round 9 of wx3 changes
...
VST GUI handling greatly simplied on OSX
2015-07-17 23:18:55 -05:00
Leland Lucius
b8872a4a02
Round 2 of wx3 changes on OSX
...
Main change is that VST GUI support is now integrate with new Cocoa
views. Direct support for VST Cocoa views (via Cockos extensions:
http://www.reaper.fm/sdk/vst/vst_ext.php ) has been added.
2015-07-11 19:33:04 -05:00
Leland Lucius
d1f66d768f
Updates for wx3
...
A long way to go yet, but many OSX issues fixed including
conversion of Audio Unit effects.
2015-06-30 11:25:32 -05:00
Leland Lucius
60f4ae1941
Fixing some i18n issues with the plugin settings file
2015-06-05 18:56:24 -05:00
Leland Lucius
d76ed7e837
Fix for bug #1006
2015-06-03 14:55:52 -05:00
Leland Lucius
0ef7ccb1d1
Fix permissions...not sure why this was happening though
2015-05-29 19:49:28 -05:00
Steve Daulton
5378b0a951
Update to non-real-time preview.
...
Fixes and updates on top of some code clean-up from Leland.
2015-05-29 22:08:16 +01:00
Leland Lucius
19acf89d2a
Fix for bug #869
2015-05-27 08:50:00 -05:00
Leland Lucius
0d62be7776
Use a common method for the duration format in generators
2015-05-27 08:42:15 -05:00
Leland Lucius
22cb98d411
Position Manage menu properly
2015-05-24 04:47:24 -05:00
Steve Daulton
e41425634a
Get preview playback right for linear effects and special case
...
for generate effects derived from Nyquist Prompt.
2015-05-22 19:09:37 +01:00
Steve Daulton
d0634be6bf
Fix non-linear preview time.
2015-05-20 20:38:29 +01:00
Leland Lucius
b08fc3ca68
Change order of menu items in effect Manage menu
2015-05-19 21:25:44 -05:00
Leland Lucius
5817fec5c7
Make sure to layout the button swap on Windows
2015-05-17 11:10:16 -05:00
yam
6df443bd37
Fix background (behind button bar) drawing on GTK
2015-05-17 10:25:47 -05:00
Leland Lucius
913cfe23b4
Fix for bug #879
2015-05-17 01:02:52 -05:00
Leland Lucius
b88646616a
Prompt to replace existing preset and don't allow blank name.
2015-05-17 00:19:35 -05:00
Leland Lucius
19e10ec81a
Merge pull request #44 from daavery/master
...
update for wx3
2015-05-16 16:22:33 -05:00
david avery
72385c7faf
wx3
2015-05-16 14:40:29 -06:00
spider-mario
6868a318d9
Prevent stereo->mono effects from causing a crash.
2015-05-16 17:53:04 +02:00
Leland Lucius
6cc7bcf384
Fix unitialized variable and remove duplicate
2015-05-16 03:00:47 -05:00
Leland Lucius
71000f6cb2
Make sure the current dialogs buttons are found...
...
...FindWindowById() looks at parents too
2015-05-15 18:52:09 -05:00
Steve Daulton
fbaab8702e
Small optimization - non-linear preview copies only selected tracks by default.
2015-05-15 16:57:29 +01:00
Steve Daulton
d9f3c432d4
Fix for bugs 943, 942, 941, 843 and 775.
...
Non-linear effects now process tracks before mixing.
This will be slower when multiple tracks are selected
but the preview should now match the applied effect.
SetLinearEffectFlag(true) allows linear effects to
preview more quickly when multiple tracks selected, by
pre-mixing selected tracks.
Simple generators like Tone and Noise may be marked as
'linear' so that they only preview a few seconds.
Generators that vary over time (such as Chirp) must use
the full duration that is set. As this currently
requires calculating the full duration, preview for
'non-linear' generators are not limited to the preview
length.
2015-05-15 12:51:51 +01:00
