Steve Daulton
85af1b981a
Fix for bug 2030 - Manage dialog
...
Windows: Manage dialog in effects has reduced vertical height
OK and Cancel buttons.
Bug also affected Linux.
2018-11-19 01:48:14 +00:00
Steve Daulton
e65e1d39d8
Fix for bug 2013
...
Bug 2013 - Extended ASCII characters in Nyquist plug-ins freeze Audacity
We previously assumed that plug-ins would always be valid UTF8, but
if it isn't then the conversion to wxTextInputStream fails, causing
pgm.ReadLine() to perpetually return a zero length line.
2018-11-18 21:37:15 +00:00
Paul Licameli
7d0b4c582a
Make VSTControlOSX.mm compilable with _LP64
2018-11-15 11:19:37 -05:00
Paul Licameli
7c1216edc6
Redo resource RAII without the dubious casts
2018-11-15 11:15:19 -05:00
Steve Daulton
cc34abea61
bug 2018 - Equalization does not retain settings
...
Thanks to David Bailes for the fix.
2018-11-13 15:52:18 +00:00
Paul Licameli
50cf2e9a1f
Give TrackArtist a back-pointer to TrackPanel
2018-11-05 10:54:58 -05:00
Paul Licameli
99106e3ed3
Carry more information in TrackPanelDrawingContext; fewer arguments
2018-11-05 09:12:45 -05:00
James Crook
b5d4a828d1
More doxygen
2018-11-04 14:21:00 +00:00
Paul Licameli
370d3e6338
spelling in comments
2018-11-03 11:45:05 -04:00
James Crook
7030c9fc4f
More doxygen
2018-11-03 13:18:26 +00:00
James Crook
466e9c179e
Create ComponentInterface
...
It combines the old IdentInterface with the ParamsInterface, providing an identifier and parameters (if needed).
The main purpose of the change is to make the class hierarchy (as viewed via doxygen) much easier to follow.
2018-11-02 17:04:43 +00:00
Steve Daulton
4f964c359b
bug 2017 'offset' was used uninitialised
2018-10-30 15:58:47 +00:00
James Crook
cc2c3dc2fc
Bug 2016 - Multiple problems with Change Pitch
2018-10-30 12:21:24 +00:00
Steve Daulton
46a3f91d59
Add some useful path definitions for Nyquist
2018-10-29 20:01:21 +00:00
James Crook
6a4663e19c
Use wxGetUTCTimeMillis in preference to wxGetLocalTimeMillis
...
For internal time-difference test, it is significantly faster, and does not suffer from daylight-saving time shifts.
2018-10-29 19:59:28 +00:00
Paul Licameli
0fbea5f9ea
Fix failure of Nyquist to translate some multiline strings...
...
... Don't trim leading whitespace from source file lines before passing them
to eval.
So when a string in Lisp code is (_ "like
this")
(the Lisp reader allows embedded newlines in quoted strings),
then the string extracted to the .pot file by xgettext contains the spaces, and
the string literal seen by our Lisp interpreter will also retain the spaces and
match the msgid in the catalog exactly.
2018-10-29 13:49:14 -04:00
Paul Licameli
38f97349f5
Don't form translated strings with concatenation
2018-10-25 04:13:44 -04:00
Paul Licameli
303553ae4e
Take class AdornedRulerPanel out of src/widgets...
...
... It's not a utility widget like RulerPanel. It has a lot of application
specific logic in it.
2018-10-24 15:04:41 -04:00
Paul Licameli
e048a4aacd
Move a static function and an enumeration out of MenuCommandHandler
2018-10-24 12:16:46 -04:00
Paul Licameli
9759c6bd4f
Plugin Menus
2018-10-24 12:16:44 -04:00
Paul Licameli
df3c2a7b2f
Don't mutate uninitialized Maybe
2018-10-23 06:02:19 -04:00
Paul Licameli
48a1538b37
Comment, to deter repeat of the mistake corrected in the last commit!
2018-10-22 20:02:33 -04:00
Paul Licameli
2b8c4aa816
Fix the binding of ngettext in XLisp
2018-10-22 19:58:13 -04:00
Paul Licameli
ce9f2e2538
Include Menus.h directly, only where needed, not via Project.h
2018-10-16 16:45:26 -04:00
Paul Licameli
fc6570646d
MenuCommandHandler is not a base class of MenuManager...
...
... This forces a better placement of state variables in the appropriate
classes.
In future perhaps, MenuManager should be splintered into several classes, one
for each of the main toolbar menus.
2018-10-16 13:01:22 +01:00
Paul Licameli
6ca721b03a
Fix a string again...
...
... This string appears when you enter a positive, invalid value for peak
amplitude in the Normalize effect. It didn't look right with periods (a space
was left before the first period). Let's use parentheses instead.
2018-10-15 12:59:02 -04:00
Paul Licameli
ef97ce88ca
Correct more double spaces
2018-10-15 12:54:44 -04:00
scootergrisen
b4f7946e9b
Remove some double space
2018-10-14 10:42:01 +01:00
James Crook
e20a98588c
Replace pointless looping by 'if'
...
The for loop was only to test if *some* track was selected, and its body only needs to be executed once.
Note that an empty IteratorRange is false and one with something in it is true.
2018-10-11 12:04:43 +01:00
James Crook
7e5a716e65
Fix C4458 Warnings
...
C4458 is 'Declaration hides class member'
2018-10-10 19:46:25 +01:00
James Crook
657159d542
Fix C4189 and C4100 Warnings
...
C4189 is 'Local variable initialised but not used'
C4100 is 'Unreferenced parameter'
Fixed some other warnings, e.g. about empty if, too.
2018-10-10 19:46:24 +01:00
James Crook
5fd95dd131
Fix C4456 Warnings.
...
"C4456 declaration hides previous local declaration."
These arise from repeated declarations of the same name.
2018-10-10 17:28:50 +01:00
Paul Licameli
14fe11f4d4
Bug2008: There was error in stereo Contrast calculation, at aee4005
2018-10-07 10:29:58 -04:00
Paul Licameli
90e2da7f14
Fix uses of TrackList::GroupChannels in Mix and effect preview
2018-10-04 11:34:14 -04:00
Paul Licameli
df1103822e
Don't crash in Nyquist tools with mOutputTracks undefined
2018-10-04 10:56:03 -04:00
Paul Licameli
beebe648fb
Remove more uses of Track::SetLinked() and Track::SetChannel()
2018-10-01 13:42:36 -04:00
Paul Licameli
4aa990e835
Remove GetLink(ed) in various other places
2018-10-01 13:42:33 -04:00
Paul Licameli
22c85dd99c
Rewrite GetLink(ed) in SBSMS
2018-10-01 13:42:31 -04:00
Paul Licameli
48ae1eb3c9
Rewrite GetLink(ed) in SoundTouch
2018-10-01 13:42:31 -04:00
Paul Licameli
518df314eb
Rewrite GetLink(ed) in vamp effects
2018-10-01 13:42:30 -04:00
Paul Licameli
4c75175e41
Remove GetLink(ed) in Normalize effect...
...
... It's much simpler and should be easy to generalize, but what would be
appropriate messages?
2018-10-01 13:42:29 -04:00
Paul Licameli
aee4005044
Rewrite many iterations over tracks and channels in src/effects
2018-10-01 11:24:04 -04:00
Paul Licameli
b6a6b8e73e
Rewrite iterations over sync-lock groups
2018-10-01 11:09:20 -04:00
Paul Licameli
bb3aa00f50
Effect::CopyInputTracks was only called with two values...
...
So now it simply takes a bool.
2018-10-01 11:06:31 -04:00
Paul Licameli
2e11844f6a
Effect::inputTracks() now gives only const access
2018-10-01 10:59:48 -04:00
Paul Licameli
1be3187b99
Use TrackIterRange::Visit
2018-10-01 10:59:24 -04:00
Paul Licameli
51842fc78b
Use TypeSwitch and track_cast
2018-10-01 10:58:47 -04:00
Paul Licameli
89748cbe3c
Remove "skiplinked" argument of old track iterators
2018-10-01 10:35:46 -04:00
Paul Licameli
6930b63192
Redo track kind as an enum class defined at global scope
2018-09-29 21:41:47 -04:00
Paul Licameli
af06691982
casting of Track* to WaveTrack* happens at lower level in OD manager
2018-09-29 12:46:45 -04:00
