Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-08 14:13:57 +01:00
Code Issues Releases Wiki Activity
6,174 Commits 23 Branches 23 Tags
7dbb946d298bbf2a103168b66e2388ab4849a04c
Commit Graph

977 Commits

Author SHA1 Message Date
Paul Licameli
b910bf63da Style changes and use of unsigned types in PaulStretch effect 2016-09-11 20:28:13 -04:00
James Crook
b44ad7cd71 More unused parameters. 2016-09-11 20:52:04 +01:00
James Crook
65c7e8051a ThomasFeher - Unused parameters clean up. 2016-09-11 20:31:49 +01:00
Paul Licameli
2263a0f477 Don't use wxArrayPtrVoid with casts, use std::vector 2016-09-08 11:08:49 -04:00
Paul Licameli
67cec5ad83 Make many counts of tracks and channels unsigned... 
... And in some places where a library uses signed types, assert that
the reported number is not negative.

What led me to this, is that there are many places where a size_t value for
an allocation is the product of a number of channels and some other number.
 2016-09-07 10:11:41 -04:00
Paul Licameli
919d77d176 More uses of min and max 2016-09-06 20:46:25 -04:00
Paul Licameli
9d633f4c47 Some simplification in the Repair effect 2016-09-06 12:39:58 -04:00
Paul Licameli
c8e7372886 Rewrite Resample::Process to take and return size_t values 2016-09-06 12:39:58 -04:00
Paul Licameli
c9a9ad6220 Fix incorrect comment, use auto 2016-09-06 12:39:57 -04:00
Darrell Walisser
5f8c48d520 use std::isnan since c++11 provides it and wxIsNan is broken in c++11 2016-09-04 17:00:12 -04:00
Paul Licameli
6043638e31 Another std::min, more auto & decltype, remove more casts 2016-08-29 20:07:43 -04:00
Paul Licameli
38ee7c0e3e Bug 1501 again: don't crash for extreme Start values for FindClipping 2016-08-28 15:53:51 -04:00
Paul Licameli
36ddd98757 Bug1501: Fix bad_alloc crash for some effects with extreme inputs 2016-08-28 12:30:43 -04:00
Paul Licameli
3b04bb1726 More uses of limitSampleBufferSize 2016-08-27 07:54:22 -04:00
Paul Licameli
52417c444d Remove unnecessary casts to sampleCount 2016-08-24 14:50:46 -04:00
Paul Licameli
fd2b050d6f Type agnosticism for some other variables that were not sampleCount... 
... in some cases, this fixes narrowings.
 2016-08-24 14:50:45 -04:00
Paul Licameli
79c79f9cd3 Remove many mentions of sampleCount with auto and decltype... 
... This makes much code agnostic about how other things (functions and
arguments) are typed.

Many of these neeed to become size_t instead of sampleCount.
 2016-08-24 14:50:45 -04:00
Paul Licameli
ee5a0db9ff some uses of size_t 2016-08-24 14:50:45 -04:00
Paul Licameli
2949a080d2 More cautions in SBSMSEffect.cpp... 
... The narrowings from sampleCount to long might be fixed, but it would
require changes in lib-src
 2016-08-24 14:50:45 -04:00
Paul Licameli
b5e410d987 Fix Windows build differently 2016-08-24 12:13:53 -04:00
James Crook
781de82d02 Workaround build breakers. Needs review. 
These changes fix a broken build in Windows.
#include <algorithm> needed for min/max to be in std.
decltype(+name) was declaring a const variable, that could not be incremented.  Changed to auto.
 2016-08-23 21:46:12 +01:00
Paul Licameli
1281f1b14b Common function limits buffer size to sampleCount known to be small 2016-08-23 12:46:10 -04:00
Paul Licameli
477d8d9d1d spaces 2016-08-22 21:45:54 -04:00
Paul Licameli
26b94a447b change a variable name 2016-08-22 21:45:54 -04:00
Paul Licameli
39df8d0b51 Don't use conversion of sampleCount to bool 2016-08-22 21:45:54 -04:00
Paul Licameli
a6de680cdb use std::min and std::max 2016-08-22 21:45:54 -04:00
Paul Licameli
2be2e73e66 LadspaEffect::mSampleRate has type double, like other plug-in effects 2016-08-22 21:45:54 -04:00
Paul Licameli
1189cfd62a Identify the few unsafe narrowing conversions from sampleCount... 
... I believe this list of four places is exhaustive.

There are many, many more safe narrowings that I examined.

This resulted from changing the definition of sampleCount in my builds so that
narrowing conversions failed to compile without some fixes, and I examined and
fixed every place.

The rest of that work is not yet shared.
 2016-08-21 15:28:32 -04:00
Paul Licameli
56586770e0 EffectClientInterface::SetSampleRate takes double... 
... All the overrides (except Ladspa) were casting it to floating poing anyway
 2016-08-21 09:51:32 -04:00
Paul Licameli
49e699b1df Remove overloads for sampleCount from ConfigInterface... 
... The value was always cast to int anyway when writing, and it was used
only for one value in VST effect, which did not need 64 bits
 2016-08-21 09:11:44 -04:00
Paul Licameli
2a7d8dca77 time warper bug 2016-08-21 08:59:48 -04:00
James Crook
b1526fbdc8 Change strings for clarity/consistency. 
Changes suggested by (translator) scootergrisen
 2016-08-19 19:30:21 +01:00
Paul Licameli
a0a76e86d1 Remove naked new and delete in effect preview 2016-08-16 13:30:26 -04:00
Steve Daulton
7b14e68b37 Pass name of proxy effect to EffectSBSMS 
Allows progress bar to show meaningful title when using SBSMS
time stretching in Change Pitch/Tempo.
 2016-08-16 14:54:34 +01:00
David Bailes
19fa6d2833 Improvements to accessibility names in Change Tempo effect. 
The change tempo effect was modified in commit 8e0089c.
The most significant change is to include the "from" length in the accessibility name of the "to" length textctrl. (The nvda screen reader cannot access the value of the "from" length textctrl, and it's not straightforward using Jaws. Note that this issue existed before the recent change of Change Tempo.)

There remains a minor issue of Jaws, but not NVDA reading the names of wxStaticBoxes, and so some repetition in what is read by Jaws.
 2016-08-16 13:57:19 +01:00
Steve Daulton
8e0089c552 Add SBSMS option to Change Tempo effect 
Thanks to Clayton Otey for his help and patience.
 2016-08-15 12:33:33 +01:00
Paul Licameli
32f24eabb2 Review uses of safenew... 
... add comments and assertions, and use make_unique instead where possible
 2016-08-13 23:16:05 -04:00
Steve Daulton
90e400b0a7 Add SBSMS option to Change Pitch effect 2016-08-13 17:28:49 +01:00
Paul Licameli
e412c13e78 Fix crash at program exit after use of Stereo to Mono 2016-08-13 10:39:56 -04:00
Paul Licameli
e599cfa6fa Effect::mOutputTracks is managed by smart pointer 2016-08-13 10:37:51 -04:00
Paul Licameli
cb48ca2b91 Use arrays of smart pointers to WaveClip 2016-08-12 20:53:38 -04:00
Paul Licameli
a400a7408c Distinguish whether clip ptr arrays own; vector; const-correctness 2016-08-12 20:53:38 -04:00
Paul Licameli
b548e641ae Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ... 
... also add some const qualifiers
 2016-08-12 20:53:37 -04:00
James Crook
8089bd484a (Cosmetic) added 'final' to class definition. 
Putting the word 'final' is a bit like adding a comment that nothing is derived from this effect.
 2016-08-10 18:25:07 +01:00
Paul Licameli
14c23803ac Various uses of make_unique 2016-08-10 11:05:52 -04:00
Paul Licameli
11305b956f Use make_unique for wxMenu objects 2016-08-10 11:05:52 -04:00
Paul Licameli
4045d96a58 Fix a memory leak I introduced in Truncate Silence ... sorry 2016-08-10 11:05:52 -04:00
Paul Licameli
6e4e710d3b Remove seeming naked new and deletes in comments and uncompiled code 2016-08-10 11:05:51 -04:00
Paul Licameli
fec4069d9d Some uses of Destroy_ptr let us remove some naked news 2016-08-10 11:05:51 -04:00
Paul Licameli
384fc4a4ae Prefer Destroy() to deleting a window 2016-08-10 11:05:50 -04:00