1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-04 07:40:12 +01:00
Commit Graph

211 Commits

Author SHA1 Message Date
Paul Licameli
0d86890657 Bug968 status bar and mouse preference messages updated for new scrub UI...
... Note too that the mouse preference message for old ctrl-click behavior
is now removed
2015-05-24 17:57:51 -04:00
Paul Licameli
c1f093ed2e Bug920 - Backward playback when selection beyond end of the project 2015-05-19 22:52:16 -04:00
David Bailes
f458df1c7b Changes to a number of dialogs so that the NVDA screen reader can read the titles. Missed these in my last patch. The accessibility name of the dialog is set to the title. 2015-05-18 13:57:05 +01:00
Daniel Winzen
92d522132e Variable cleanup 2015-04-23 18:30:38 +02:00
Daniel Winzen
759ff8cd0d Performance improvements 2015-04-23 16:07:25 +02:00
Paul-Licameli
a3fcf5a265 Revert unintended changes. Should have changed Ruler.cpp only.
This (partially) reverts commit 79b7caac07.
2015-04-21 19:37:19 -04:00
Steve Daulton
79b7caac07 Fix play from click position when Quick Play Loop in selection. 2015-04-20 04:06:07 +01:00
Leland Lucius
69b044e321 Restore tracks if recording fails to start
During an append record, silence may need to be added to the
end of the existing track(s) to fill any gap between the end
and the common recording start time.

But, if the recording fails to start, this silence is left at
the ends of the tracks.

This change fixes that by making a copy of the tracks before
recording starts and restoring the tracks from that copy if
the start fails.
2015-04-17 16:35:48 -05:00
Paul-Licameli
10e35bb6bb Add user interface for scrubbing and Experimental.h switches
EXPERIMENTAL_SCRUBBING_BASIC enables middle-click-drag to scrub, or to seek
when shift is down.

EXPERIMENTAL_SCRUBBING_SMOOTH_SCROLL adds middle-double-click-drag to
scrub or (with SHIFT down) to seek while keeping the playhead at the midline
of the track display.

EXPERIMENTAL_SCRUBBING_SCROLL_WHEEL allows control wheel to vary the speed
limit, while scrubbing (not seeking).

All three are enabled in this commit.

Also notice the changes to status bar messages and the Mouse Preferences dialog.

Scrubbing works only in Select and Multi tools.
2015-04-17 14:09:35 -04:00
Steve Daulton
702d9d75e5 Timeline Quick Play bug fixes and enhancements 2015-04-17 17:52:13 +01:00
Paul-Licameli
5abfd25a34 Support backwards play, a requirement for scrubbing
Uncomment the line at the top of ControlToolBar::PlayPlayRegion to play
everything backwards and test it

It even works correctly with a time track
2015-04-17 02:25:52 -04:00
Paul-Licameli
2b85d0edb4 Preliminary function argument list changes and comments, for scrubbing project
In particular, use an options structure for AudioIO::StartStream to simplify
calls

ControlToolBar::PlayPlayRegion also takes that structure as an argument, and a
SelectedRegion instead of two times

And other changes
2015-04-17 02:25:39 -04:00
Paul-Licameli
7d6de21e3a Enh809 - Add persistency of spectral selections, including those in labels 2015-04-10 15:20:50 -04:00
Paul Licameli
bc50440210 Bug881 - Status bar messages swapped 2015-04-07 12:18:40 +01:00
lllucius
57d18d7bcb Further correction for bug #795 2015-01-10 18:16:55 +00:00
lllucius
1201c5abe3 Applying patch from bug #795 2015-01-04 19:41:08 +00:00
lllucius
3a098714d9 Persist looped button across toolbar resets...
...when started from the keyboard.
2015-01-03 11:27:24 +00:00
lllucius
0c00a5f463 SetCursor() is only needed once
Thanks to a discussion with Steve, I went back to the docs
and found that SetCursor() is persistent.  So it doesn't
have to be done in a mouse event handler.  The constructor
is perfectly sufficient.
2015-01-02 14:58:22 +00:00
lllucius
15ac9905ad Do not allow resizer to accept focus. 2015-01-02 14:39:56 +00:00
lllucius
bec5866653 Persist meter state across toolbar resets and fix clipping indicator
This will fix the clipping indicator turning on after a toolbar reset
and, as a bonus, the timers now only run if playing, capturing, or
monitoring.  Will (slightly) reduce the CPU consumption.
2015-01-01 23:29:08 +00:00
lllucius
2e6e110a34 Allow speed slider to persist across toolbar reset 2015-01-01 20:27:29 +00:00
lllucius
6459324b4c Allow selected tool to persist across toolbar reset 2015-01-01 20:05:06 +00:00
lllucius
622b609f91 Allow button state to persist across toolbar reset 2015-01-01 11:46:52 +00:00
lllucius
6a3ef5565c Independent meters with combined menu/icon
Many other changes including:

1)  Independent preferences
2)  Automatic layout separated from vertical/horizontal orientation choices 
3)  Combined menu and icon which saves space
4)  Click to start monitoring label no longer covers peak hold line completely
5)  Click to start monitoring label now adjusts label based on available width
6)  Click to start monitoring label now appears on vertical meter (not sure about this one...)
7)  Reduced width of vertical meter by moving icon to left of meters
8)  Includes a compact vertical meter now
9)  Clipping indicator is easier to see
10) All 1-off drawing issues resolved (99.9% sure...I challenge you to find some ;-))
11) Bevels around meters are no longer overlaid by meter updates
12) "Old" menu handling code removed
13) Though not perfect since some non-English characters are taller/wider than the meters, non-English text is now handled better
14) Clicking play meter resets indicators as appropriate
15) Indicators on meters now stick around until the meter is clicked
16) Ugly flashing while resizing is now gone
17) There should be NO magic numbers in the code.  Every +1 or -2 is explained in comments...
18) Size of L/R labels are recalculated now when preferences are updated (to pull in locale changes)
2014-12-28 03:18:00 +00:00
lllucius@gmail.com
7c1535fdfd Always assign an order if a bar is docked
Otherwise, the next time Audacity is started, it will
become undocked.
2014-12-26 09:21:35 +00:00
lllucius
7108b71f5d Fix for bug #804
But, I did leave in the disabling/enabling of the 
transcription toolbar play button when recording.
Thought that was a good idea.
2014-12-22 09:29:14 +00:00
windinthew@gmail.com
00af97edd6 No need for a period in a tooltip that is not a complete sentence. 2014-12-20 23:27:41 +00:00
lllucius
6a0492e15d Default all toolbars to docked on reset and new config
Combined meter and spectral toolbars default to hidden.
2014-12-20 22:03:10 +00:00
lllucius@gmail.com
9404a28954 Fix missing toolbars at startup on Linux
The problem was that on Linux (not Windows or Mac) menu
events are generated when checking the menu items in
the toolbar menu.

Becuase of the recent changes I made and how the toolbars
are being shown (toggled) when the toolbar menu is checked,
they were simply being hidden.  Actually, the were being
shown and then hidden because of the toggle.

So, with this change I made exposing toolbars a bit more
deterministic.  The menus still use a toggle, but the 
ToolManager now shows or hides the bars explicitly during
setup, so the menu toggle issue is resolved.
2014-12-20 20:08:45 +00:00
stevethefiddle@gmail.com
9a0d4b2364 Fix for Spectral Selection bar layout from David Bailes. 2014-12-20 15:39:35 +00:00
lllucius
9bbc261321 Attempt #2 at taming the meter toolbars
It corrects several "multiple project" problems with the
meter toolbars and meters.

In addition, there was a "multiple project" issue where
the transport buttons didn't disable properly in the
non-active project.
2014-12-19 16:38:56 +00:00
lllucius
64afdbb508 A couple of meter orientation fixes
1)  On startup if the capture meter is vertical and
    the playback meter is horizontal, capture meter
    would jump to horizontal if you start monitoring.

2)  To cut down on meter orientation weirdness, the
    orientation is now mirrored in both meters when
    it changes.

    If this is not a desired behavior then the only
    option would be to have separate config file
    settings for each meter.  That means that the
    orientation settings in meter preferences will
    correspond to that meter only.

    Let me know if this is what is wanted.
2014-12-18 07:48:33 +00:00
lllucius
49b332ebd3 Fix for very strange toolbar setup after removing audacity.cfg 2014-12-18 06:33:44 +00:00
lllucius
f5380be663 Fix cut/paste mishap...thanks Martyn 2014-12-18 05:51:38 +00:00
lllucius@gmail.com
b24fccfb17 Fix build on Linux and Mac 2014-12-17 19:31:58 +00:00
lllucius
fe42e881a5 First stab at taming the meter toolbars
This should correct at least a couple of the reported
issues.  And it also has some fixes in for multiple
project support.
2014-12-17 19:16:08 +00:00
lllucius
431166561e Getting rid of some warnings...mostly unused parms 2014-12-15 21:51:02 +00:00
lllucius@gmail.com
012debf65a Fix crash when opening Screenshot Tools 2014-12-13 21:52:31 +00:00
lllucius
f7837eea1b Remove debug logging 2014-12-13 03:14:33 +00:00
lllucius
2f177032ed Fix the weird mouse pointer behavior over toolbar resizers
I couldn't handle it anymore.  The darn pointer would seemingly
switch to left/right arrows whenever it felt like it...and stay
that way.

Actually, it was when it passed over the toolbar resizer when
docked.  The problem was that it wouldn't change back to a normal
pointer because it didn't have the events it needed to do that.

So, I moved the resizer logic into it's own window and now the
pointer changes like it should.

As a bonus, we get a tooltip so the user will know what to do
when the pointer changes as it passes over the resizer.
2014-12-11 08:05:11 +00:00
lllucius
6539d693b3 Fix for bug #783
This should correct the crash and will also correct
the problem where one project's playback/capture was
being metered in another project if multiple projects
were open.
2014-12-08 04:53:53 +00:00
lllucius@gmail.com
9317bbb3f7 Applying patch from bug #766
This patch fixes the corrupted device names as 
documented by the bug report.
2014-12-06 05:05:21 +00:00
lllucius
abaac6b443 Make sure controls are empty if the last sound device is removed. 2014-12-06 03:41:33 +00:00
lllucius
4d76e14794 Changes to the Effect dialog based on QA suggestions
Solves the problem of what the "Settings" button should say
by converting it to a bitmap button.

Adds the missing "bypass effect" button.

The Ok/Cancel buttons are now Apply/Close buttons and the
dialog stays open after the apply is done.

Record is no longer disabled when an RTP effect is open as
the RTP effect now monitors when recording starts and disables
its buttons as needed.

Added "Play", "Skip forward", and "Skip backward" buttons.
While the other stuff is required, this last one is in to
get a feel for its usefulness.  We'll need to get feedback
on it pretty quickly so we can rip it out if need be.
2014-12-02 08:55:02 +00:00
lllucius
da76615bf3 Now do the reverse...disable record if a realtime effect is open. 2014-11-30 21:55:13 +00:00
james.k.crook@gmail.com
c71397beae Changes to seeking and scrubbing from Paul Licameli.
These are mostly under an EXPERIMENTAL_ #ifdef.  Also has a change for the prompt string for preferences so the displayed keybinding is adjusted when in multitool mode.
2014-11-29 22:09:57 +00:00
james.k.crook@gmail.com
94c243cb2e No disabled state for meters. Monitoring can be on or off. Input meter now has prompt when monitoring off.
I haven't got rid of the preferences for disabled/enabled.
2014-11-29 21:10:44 +00:00
james.k.crook@gmail.com
7324997db6 Fix for http://bugzilla.audacityteam.org/show_bug.cgi?id=643 "Residual consistency issues with SHIFT showing Loop Play button icon" by Paul Licameli.
* Loop play-at-speed and cut preview play-at-speed implemented.
* Shift or ctrl down now affect all relevant buttons, loop or cut preview, normal or at speed, and append-record.
2014-11-29 17:22:05 +00:00
james.k.crook@gmail.com
4ed7396b24 Spectral Selection ToolBar Accessibility, by David Bailes. (untested by me as I am Jawless) 2014-11-29 16:50:08 +00:00
james.k.crook@gmail.com
bce372bfee Tooltip on recording meter toolbar now changes with meter on/off 2014-11-13 16:29:08 +00:00