1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-13 14:13:32 +02:00
Commit Graph

375 Commits

Author SHA1 Message Date
luzpaz
7a3bdcf3f2 Fix typos (user facing and non-user facing) (#727)
Found via `codespell v2.1.dev0`  
`codespell -q 3 -S *.po,./lib-src -L parm,parms,toke`
2021-01-24 09:46:08 +00:00
freddii
534359de6c Fix minor typos (#720)
Co-authored-by: freddii <https://freddii@github.com>
2021-01-12 11:56:09 +00:00
freddii
2593a84d56 Fix some spelling mistakes. 2021-01-12 09:55:31 +00:00
Paul Licameli
f4f8194dc6 Bug2606: Import shouldn't be lossy or narrower than Quality pref 2020-12-03 19:20:33 -05:00
Paul Licameli
31b391737f Choice of format for imported tracks now in just one place...
... Doing the widening as needed to match Quality preference.

Fewer direct dependencies on QualityPrefs.h.

FLAC and OGG may import as float where before it was 24 bits; only 16 bits or
float.  This makes them behave consistently with Raw and PCM.
2020-12-03 19:19:30 -05:00
Paul Licameli
791dbea1af Bug2109 residual: apply fix also in case of import of MIDI...
... Muting the new track, in case any solo track already existed.
2020-11-21 15:56:20 -05:00
Paul Licameli
caa312ab7b Remove some unneeded #includes and forward declarations 2020-11-20 13:47:47 -05:00
Paul Licameli
6dea5434a6 Bug2586: .aup with envelopes in wave tracks should import correctly 2020-11-19 16:48:41 -05:00
Paul Licameli
0277e00402 Bug2569: Alias block files should import correctly into .aup3 2020-11-17 23:19:06 -05:00
Paul Licameli
a8bc89e4c4 Bug2570: Save-compressed or -lossless files from 2.x should import 2020-11-17 21:37:54 -05:00
Paul Licameli
e9d72ed6df Change handling of added tracks in ImportAup...
... Add them to the project, not a temporary array; revoke the addition if
there is a failure.

Preliminary for fixing bug 2570.
2020-11-17 21:14:04 -05:00
dofuuz
f144a1f689 Improve 'Import Raw Data' dialog (#679)
* Add sample rate preset(combo box) to Import Raw Data dialog

* Import Raw Data dialog: Get default sample rate from Project Rate

* Fix build
2020-09-27 14:03:37 +01:00
Paul Licameli
c5741cc1da Remove unnecessary #include 2020-09-26 20:34:02 -04:00
James Crook
caf4eadb97 Help button for many warning messages; Restored warning icon.
The error icon was gone because we are now using the ErrorDialog, which didn't have it.  So added back explicitly.  I decided to go with wxART_WARNING rather than wxART_ERROR because nearly all of these present as warnings.
2020-09-14 17:43:28 +01:00
Paul Licameli
a00fe789b9 More aup import review (#656)
* More format fixes on import: beware sequences with differing format...

... It could happen.  When collecting file information to be used in the
second pass, record the correct format for each.

Don't mistakenly use whatever was the format of the last read Sequence for all
files.

This only matters for the avoidance of unnecessary sample format conversions
when finally appending samples to tracks.  It won't affect the space ultimately
occupied in the database.

* Cautions against double throw in a finally block

* Fix some Doxygen in ImportAUP.cpp
2020-09-02 00:36:48 -05:00
Paul Licameli
d5a4ed74d2 Bug2538: Fix persistence of Sequence format in imported .aup ...
... which may be important if the user saved 16 bit for space efficiency.
Don't lose that efficiency.
2020-09-01 22:25:55 -04:00
Paul Licameli
1e3885730f Aup import review (#654)
* Remove unused member

* I think you want to null the clip pointer when done with it?

* Simplify end tag handling

* Clear tracks in one place, but it may not matter...

... The file handle object is destroyed and not reused in any case

* Log messages can be English

* Let first error message override any mere warning; comments, assertion

* Remove unreachable code -- see the loop preceding it

* fix more unreachable code

* Correct unusual case of file names (is it used?)

* Re-use SFCall, in case we decide in future that the mutex does matter
2020-09-01 09:26:23 -05:00
Paul Licameli
7294f7a8e0 Bug2532: should preserve sharing of sample blocks when importing AUP (#651) 2020-08-30 17:18:18 -05:00
Paul Licameli
4ca3e7096f Track factory cleanup (#646)
* Don't need TrackFactory to make LabelTrack

* Don't need TrackFactory to make NoteTrack

* Don't need TrackFactory to make TimeTrack, or ZoomInfo in the factory

* Remove some forward declarations

* Rename TrackFactory as WaveTrackFactory, move it out of Track.cpp
2020-08-22 18:44:49 -05:00
Leland Lucius
030f92c40b AUP3: Fix condition 2020-08-12 11:38:54 -05:00
Leland Lucius
f43ad3f0e0 Fix missing OPUS files in import file dialog 2020-08-11 17:07:21 -05:00
Leland Lucius
6d08c600df Bail on any error when checking for valid MP3 frames 2020-08-11 10:10:51 -05:00
Leland Lucius
dffa24cf69 Bug 2445 - Cryptic, unhelpful, error message when importing malformed MP3 file 2020-08-09 13:24:48 -05:00
Leland Lucius
56b1b5c31f Bug 2445 - Cryptic, unhelpful, error message when importing malformed MP3 file 2020-08-09 13:23:09 -05:00
Leland Lucius
f09f03e44b Skip APE and Lyrics tags in MP3 importer
In addition, CheckMP3 was updated to use the mad header decoder
to more easily scan for valid MP3 frames.
2020-08-08 03:38:38 -05:00
Leland Lucius
7bb2417db3 AUP3: Fix flushing of tracks/clips in AUP importer 2020-07-22 14:40:14 -05:00
Paul Licameli
bd6536f3c4 Remove obsolete mentions of blockfiles in comments & incomplete types 2020-07-20 19:03:31 -04:00
Leland Lucius
e669b365f1 AUP3: Remove unneeded error message 2020-07-18 09:25:10 -05:00
Leland Lucius
df4f3bd4e2 AUP3: "All supported files" filter missing AUP3 extension 2020-07-17 20:45:54 -05:00
Leland Lucius
79b8c65f60 AUP3: Make the AUP3/AUP file types consistent 2020-07-15 11:58:45 -05:00
Leland Lucius
2accd9e93f AUP3: Bug 2187 - no error message) when using a missing aliased audio file 2020-07-15 08:40:39 -05:00
Leland Lucius
176eb49a1e AUP3: Several little fixes
Handle bypassing of timetracks in AUP importer correctly
Add bypassing of timetracks in AUP3 importer
Move/add AUP3 in filter lists.
2020-07-15 07:57:20 -05:00
Leland Lucius
5bc3ae659c AUP3: Added AUP3 importer and improved progress dialogs 2020-07-15 01:32:48 -05:00
Leland Lucius
25d9e1c387 AUP3: Add better progress to AUP importer 2020-07-13 00:59:12 -05:00
Leland Lucius
a0008831e0 Revert "AUP3: Reworked CopyTo() yet again"
A bit more thought needs to do into this.
2020-07-12 10:55:54 -05:00
Leland Lucius
e3c5563d35 AUP3: Reworked CopyTo() yet again
This time it has the potential to produce much smaller
output files since it ONLY copies the active blocks and
not all of the blocks related to undo history.
2020-07-12 10:39:37 -05:00
Leland Lucius
5ffff72d35 AUP3: Fix includes 2020-07-09 14:08:21 -05:00
Leland Lucius
251da3bb3b AUP3: First go at the AUP importer
Near as I can tell, it's pretty much done. Feeding all manner of
.aup projects will definitely need to be done. It would be best
to feed it REAL projects, not the contrived ones I've been playing
with.
2020-07-12 03:53:25 -05:00
Leland Lucius
d39590cf41 AUP3: First round of updates
!!! THERE WILL NO DOUBT BE BUGS !!!

This is a big one and there's still several things to
complete. Just want to get this in the wild to start
receiving feedback.

One big thing right now is that it will NOT load pre-aup3
files.  An importer is on the way for that.
2020-07-01 02:30:18 -05:00
Leland Lucius
cbf1bb558e AUP3: Removes OD code related to project file handling
This removes all of the OnDemand code embedded throughout
    the main codebase. Individual files related specifically
    to OD have been left in place, but removed from the build.
2020-07-01 01:14:05 -05:00
Leland Lucius
3276234ae8 Bug 2484 - OPUS import fails 2020-06-16 09:05:29 -05:00
Paul Licameli
3869a8f460 Remove allegro.h from other headers 2020-06-14 10:32:16 -04:00
Paul Licameli
da93757401 Remove ImportRaw.h from other headers 2020-06-13 12:19:38 -04:00
Paul Licameli
f3d91f488e Remove extern declarations from .cpp files...
... Require the declarations to be in .h files, to be sure graph.pl detects the
dependencies.

Only one more #include was needed in Nyquist.cpp.   This doesn't reveal any
more hidden cycles.
2020-05-28 05:50:25 -04:00
Paul Licameli
ae9aca8177 Implement member functions of classes in corresponding .cpp files...
... in four cases; not in some other .cpp file.

This is another move that causes the generated graph to reflect dependencies
correctly.

This fixes other large, hidden cycles that involved PrefsDialog.cpp: there was
link dependency on that when PrefsPanel.h was used for the base class.  No
longer.

Also cycles involving TrackPanel.cpp, which contained the default
implementations for TrackPanelCell and related abstract base classes.
2020-05-28 05:50:22 -04:00
Paul Licameli
0c97138840 Include only Registry.h where needed, without CommandManager.h 2020-05-28 05:45:11 -04:00
Paul Licameli
226a80140a Add some unnecessary #include directives...
... They are not necessary to build, but the do indicate some link
dependencies to fix, that were not shown in results of scripts/graph.pl.

The link dependencies exist because the header declaring some name did not
correspond to the .cpp file that defined it.
2020-05-27 19:58:17 -04:00
Paul Licameli
66c5b76573 Simplify public interface of FileHistory 2020-05-26 10:47:47 -04:00
Leland Lucius
35e88d995b Bug 421 - Crash importing malformed MP3 file using libmad
This adds LAME tag handling and bad MP3 detection, but
it's pretty much a complete rewrite, so plenty of testing
is needed.
2020-05-23 22:03:41 -05:00
Paul Licameli
d373e27840 Remove some unused forward declarations and #include directives 2020-05-23 05:32:01 -04:00