... Doing the widening as needed to match Quality preference.
Fewer direct dependencies on QualityPrefs.h.
FLAC and OGG may import as float where before it was 24 bits; only 16 bits or
float. This makes them behave consistently with Raw and PCM.
The error icon was gone because we are now using the ErrorDialog, which didn't have it. So added back explicitly. I decided to go with wxART_WARNING rather than wxART_ERROR because nearly all of these present as warnings.
* More format fixes on import: beware sequences with differing format...
... It could happen. When collecting file information to be used in the
second pass, record the correct format for each.
Don't mistakenly use whatever was the format of the last read Sequence for all
files.
This only matters for the avoidance of unnecessary sample format conversions
when finally appending samples to tracks. It won't affect the space ultimately
occupied in the database.
* Cautions against double throw in a finally block
* Fix some Doxygen in ImportAUP.cpp
* Remove unused member
* I think you want to null the clip pointer when done with it?
* Simplify end tag handling
* Clear tracks in one place, but it may not matter...
... The file handle object is destroyed and not reused in any case
* Log messages can be English
* Let first error message override any mere warning; comments, assertion
* Remove unreachable code -- see the loop preceding it
* fix more unreachable code
* Correct unusual case of file names (is it used?)
* Re-use SFCall, in case we decide in future that the mutex does matter
* Don't need TrackFactory to make LabelTrack
* Don't need TrackFactory to make NoteTrack
* Don't need TrackFactory to make TimeTrack, or ZoomInfo in the factory
* Remove some forward declarations
* Rename TrackFactory as WaveTrackFactory, move it out of Track.cpp
This time it has the potential to produce much smaller
output files since it ONLY copies the active blocks and
not all of the blocks related to undo history.
Near as I can tell, it's pretty much done. Feeding all manner of
.aup projects will definitely need to be done. It would be best
to feed it REAL projects, not the contrived ones I've been playing
with.
!!! THERE WILL NO DOUBT BE BUGS !!!
This is a big one and there's still several things to
complete. Just want to get this in the wild to start
receiving feedback.
One big thing right now is that it will NOT load pre-aup3
files. An importer is on the way for that.
This removes all of the OnDemand code embedded throughout
the main codebase. Individual files related specifically
to OD have been left in place, but removed from the build.
... Require the declarations to be in .h files, to be sure graph.pl detects the
dependencies.
Only one more #include was needed in Nyquist.cpp. This doesn't reveal any
more hidden cycles.
... in four cases; not in some other .cpp file.
This is another move that causes the generated graph to reflect dependencies
correctly.
This fixes other large, hidden cycles that involved PrefsDialog.cpp: there was
link dependency on that when PrefsPanel.h was used for the base class. No
longer.
Also cycles involving TrackPanel.cpp, which contained the default
implementations for TrackPanelCell and related abstract base classes.
... They are not necessary to build, but the do indicate some link
dependencies to fix, that were not shown in results of scripts/graph.pl.
The link dependencies exist because the header declaring some name did not
correspond to the .cpp file that defined it.