1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-24 00:00:06 +02:00

89 Commits

Author SHA1 Message Date
Paul Licameli
f42a953752 Track duplication methods return unique_ptr, although some callers...
... simply release() them for now.
2016-03-26 11:50:10 -04:00
Paul Licameli
c609af3bbe Correct TrackList::Swap -- mind the back-pointers in the tracks. 2016-03-14 11:18:32 -04:00
Paul Licameli
aee12f5755 Define and use copy and move for TrackList, simplifying recording code 2016-03-07 06:43:42 -05:00
Leland Lucius
9dc9348127 Fixes bug #1344 (mac build)
In addition, the Xcode project can now build against the 10.6
or 10.7 SDKs.  All that is needed is to change the SDK version
and the other settings will change automatically.
2016-03-07 00:29:26 -06:00
Paul Licameli
cd8a19f055 Define copy, move, and Swap for TrackList 2016-03-06 10:41:07 -05:00
Paul Licameli
43790cfa56 std::vector for wave track pointers; remove deprecated TrackList function; ...
... and some more uses of const
2016-03-01 20:54:48 -05:00
Paul Licameli
7aee5d09d8 Move the recent const_casts elsewhere 2016-02-29 19:56:27 -05:00
Paul Licameli
48a5f55179 More const qualifiers, for copying of tracks, and replacing in lists of tracks
... (the tracks may be const, not the list, when replacing)
2016-02-27 17:30:30 -05:00
Paul Licameli
6f63226291 More const qualifiers and mutable members for drawing of tracks 2016-02-27 13:04:34 -05:00
Paul Licameli
d097c7fad4 More const qualifications. The source of a paste is const. 2016-02-27 12:54:57 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
a5b6c9fd8f Add some const qualifiers; define TrackListConstIterator 2016-02-24 19:10:39 -05:00
Paul Licameli
a1c7b396b3 UndoStackElem has proper constructor and destructor; use std::vector 2016-02-24 19:10:36 -05:00
Paul Licameli
c98b090182 Rename SyncLockTracksIterator::First to StartWith to be consistent 2016-02-24 12:59:28 -05:00
Paul Licameli
9bf098c7d9 Sweep unnecessary wxString copies: rest 2016-02-23 02:15:56 -05:00
Paul Licameli
17c9369286 Bug1239: Correct time rulers after importing files (with File>Open) ...
... The fisheye stuff was to blame.
2016-01-26 18:09:29 -05:00
Leland Lucius
6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli
439fdc66ff weaken dependency of TrackPanel.cpp on LabelTrack.h, a bit 2015-08-23 19:02:06 -04:00
Paul-Licameli
1992b0c7e3 Fix a compilation warning, make some member functions const 2015-05-29 00:35:00 -04:00
Paul-Licameli
bdc2839112 Preliminaries for bug 900
Create WaveTrackCache as a utility class but don't use it anywhere yet.

The possible minor performance problem with effects is fixed by changes
in WaveTrack::GetBestBlockSize().
2015-05-26 20:02:37 -04:00
Paul-Licameli
14a36dad46 Bug834, part 2 - Memory leak and orphans after cancelling any generator
New project.  New track.  Generate sound -- do not cancel.  Select all,
generate sound again -- this time, do cancel the progress dialog.

Undo, so you see one, empty track again.  Save.  Close.  Reopen.

The cause of these orphans is different from the first case.  The previous
commit is necessary but not sufficient to fix this.
2015-04-08 11:41:38 -04:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
v.audacity
cc876ce7be just some cleanups on FIXMEs and unused method parameters 2013-08-31 05:57:48 +00:00
v.audacity
c7daafede2 In off-list discussion, Steve mentioned that kdevelop / kate highlighting recognizes "FIXME", but not "FIX-ME", which has been the Audacity convention. This commit changes Audacity code to use the "FIXME" convention (though I've never known it as convention and MSVC doesn't recognize it).
Also, minor change in WaveTrack.cpp in the effort on bug 641. Should have no functional difference.
2013-08-24 20:30:47 +00:00
martynshaw99
f209391d59 John (Thales) code to make the waveform display look like the output of the gain and pan sliders, rather than the input. Added as EXPERIMENTAL_OUTPUT_DISPLAY since there is work to do, but I think this deserves wider input/views. 2013-05-30 23:14:25 +00:00
richardash1981
eae6a70c6e always resize a track when it linked/unlinked so that it's minimised size is honoured, and we don't get over-minimised tracks. splitting very-small-but-not-minimised tracks can still give these symptoms. Patch by Sven Giermann 2013-03-10 16:31:07 +00:00
richardash1981
72f6eded20 I got fed up of unused parameter warning from my compiler hiding the warnings I wanted to see, so have added WXUNUSED annotations to a lot of widely used header files, and cleaned up trailing junk on the way. 2012-12-31 16:57:15 +00:00
v.audacity
0e287db4c9 Turns out the failsafe I added yesterday in r11929 was the correct solution to bug 367. This commit just adjusts the comments.
This also has the fix for bug 232, derived from the patch by Gaurav Agarwal.

Also changed several lingering "linking" comments to "sync-lock", the agreed on current terminology.
2012-08-20 20:26:42 +00:00
v.audacity
de184c3b86 clarifications and corrections in some comments 2011-04-26 21:19:59 +00:00
v.audacity
2ea3fd6553 clarifications in comments 2011-04-18 06:30:07 +00:00
mchinen
68a2c2514a Bug 367 (P2) followup - fix another crash case. Rewrite of MoveClipToTrack will need to be done as a lot of the code does not take into account sync locked tracks. 2011-04-17 23:54:30 +00:00
rbdannenberg
a1f0e5ed5b Extensive changes to improve NoteTrack display and (some) editing, NoteTrack playback via MIDI, and Midi-to-Audio alignment. 2010-09-18 21:02:36 +00:00
v.audacity
50ea5acf27 Consolidate multiple names for the same feature: sticky/linked/sync/synchro/grouped -> sync-lock. 2010-08-11 23:56:50 +00:00
v.audacity
209a2b193d Consolidate multiple names for the same feature: sticky/linked/sync/synchro/grouped -> sync-lock. 2010-08-11 22:47:26 +00:00
businessmanprogrammersteve
e35e019e17 Change lots of code that uses linking to use the new
scheme.
2010-02-16 20:50:38 +00:00
businessmanprogrammersteve
818f949f4b TrackKindEnum should be the name of the enum, not a variable decl. 2010-02-13 02:16:47 +00:00
businessmanprogrammersteve
b646b10df2 Adds Track::IsSynchroSelected() and visuals for synchro (group) selection 2010-02-12 16:05:02 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00