Paul Licameli
2e314b9dd2
ScrubForwarder pushes and pops itself on the window handler stack...
...
... Fixing crashes on close of project window seen in some Linux builds of
2.3.3. The bug began at commit a3b434be1c
2020-02-21 14:15:14 -05:00
Paul Licameli
d06625ba60
Revert "Fix unbalanced event handler push/pop"
...
This reverts commit 8ac5699fcd .
2020-02-21 12:42:24 -05:00
Leland Lucius
80662a1b60
Add missing value initialization
2020-02-21 11:17:59 -06:00
Leland Lucius
8ac5699fcd
Fix unbalanced event handler push/pop
...
Fix was provided by Hans Petter Selasky with the following comment:
This is a regression issue after:
Move the scrub mouse event handler into ScrubUI...
Where:
if (mWindow)
mWindow->PushEventHandler(&mForwarder);
was removed from the Scrubber() constructor function and
not from the ~Scrubber().
2020-02-21 10:57:30 -06:00
Leland Lucius
26827bc5e5
Fix missing AU, VST, and Ladspa effects
...
This also prevents a link error if you specifically link against the
10.9 SDK or older.
2020-02-21 10:16:17 -06:00
James Crook
3332c9451e
Slightly faster parsing of Nyquist programs.
...
This reads the program into a buffer first.
It also preallocates space for the Nyquist program.
2020-02-21 15:39:37 +00:00
David Bailes
f5b8b4028b
Accessibility: AutoDuck and Truncate silence effects.
...
Problem:
Screen readers don't automatically read the units of the values in text boxes.
Fix:
Add units the the accessibility name of the text boxes.
Thanks to Paul for providing ShuttleGui::NameSuffix(), which makes the code neat and readable.
2020-02-21 14:55:15 +00:00
James Crook
952ff1f61e
Don't register the Demo command
...
It's only for developers.
2020-02-21 09:53:54 +00:00
Paul Licameli
dfee1b1116
Fix sorting and grouping of effects by publisher
2020-02-20 15:32:49 -05:00
Paul Licameli
adb46093fa
Show drag cursor to rearrange tracks only when there is more than one
2020-02-20 13:41:18 -05:00
Paul Licameli
e4d5eefee0
A tooltip for the sub-view rearranging cursor
2020-02-20 13:25:03 -05:00
Paul Licameli
38bf4f558b
Better cursors for open and closed hands
2020-02-20 13:16:13 -05:00
Paul Licameli
571f42df79
Add some comments
2020-02-20 08:51:39 -05:00
Paul Licameli
96d8328aa3
fix a comment
2020-02-20 07:19:27 -05:00
Leland Lucius
692174ce2e
Forgot several resources in the Mac CMake build
...
Thanks Peter.
2020-02-19 14:59:33 -06:00
SteveDaulton
3ba5f69089
Fix bug 2328: Ensure fade out at end of each DTMF tone
2020-02-19 19:42:21 +00:00
Leland Lucius
53840f7a3e
Various fixes to CMake build
...
Mostly a result of not defining __WXMSW__, but the portmixer cmakelist
wasn't looking for the right portaudio variables.
2020-02-19 10:53:50 -06:00
David Bailes
b67c82171c
Bug 2329 - Keyboard shortcuts: new or changed defaults can create duplicates
...
Problem:
If a new version of Audacity introduces a new default shortcut, or changes an existing one, then this may be the same shortcut as a user has previously assigned to another command. Both commands will have the same shortcut, and the shortcut will only execute one of those commands.
Fix:
Check for any such duplicates when a user opens a version of audacity using an audacity.cfg file which was created with a different version.
For each duplicate found, remove the shortcut from the command which has a new or changed default.
If duplicates where found, open a message box informing the user of the removed shortcuts.
2020-02-19 15:02:08 +00:00
Paul Licameli
33b5d151ac
Bug2271, Compressor ratio slider should not overlap the label...
...
... commit 707a069 was at fault
2020-02-18 14:21:11 -05:00
Paul Licameli
b423413278
Fix comments
2020-02-17 22:40:05 -05:00
James Crook
38f77e5820
Bug 2276 - Screenshot tool either fails, or may capture the wrong screenshot
2020-02-17 22:50:56 +00:00
James Crook
970061483b
Bug 2269 - Linux: Graphic Eq crash
2020-02-17 22:17:16 +00:00
James Crook
b2d9f7c396
Bug 2305 - The Gain, Play-at-Speed and Mixer Board sliders do not display the numeric value in the tooltip when sliding
2020-02-17 21:55:32 +00:00
Paul Licameli
e5540c6118
Don't crash on exit when a module attaches a menu item...
...
... such as Nyquist Workbench.
I don't fully understand why, but destroying the menu registry items very late,
during the destruction of static objects, causes a crash in memory deallocation,
at least on Mac.
So destroy the menu registry explicitly in application shut-down.
2020-02-17 16:08:59 -05:00
James Crook
0fcb965b15
Revert 72f20d91; Pointer for TCP cursor.
...
- The TCP cursor is indicating both selection and dragability, so we use the arrow (as UI for tabs does, which are selectable and draggable).
- When actually dragging, we use the clenched fist icon, not the new clenched fist with the fingers cut off icon (aka snowball icon).
2020-02-17 19:17:36 +00:00
James Crook
4512ad76ac
Bug 2284 - Macro Manager offers to apply changes to wrong macro
2020-02-17 17:42:17 +00:00
James Crook
a6699ed494
Bug 2283 - Crash on editing Nyquist Generator plug-in parameters in Macro
...
Big Thanks to Steve for finding this and writing clear steps to reproduce when logging this bug in Bugzilla. Also thanks to Peter for confirming the same bug is present on Windows, i.e. is all platforms, not just Linux.
2020-02-17 16:31:40 +00:00
James Crook
1d9aa20a40
Bug 2261 - Graphic EQ sliders have no frequency labels
2020-02-17 14:10:37 +00:00
James Crook
4d54430c7c
Bug 2270 - Graphic Eq: GUI opens too small vertically
2020-02-17 13:27:13 +00:00
James Crook
3d7cf17950
Bug 2254 - Graphic Eq: Inappropriate presets
2020-02-17 13:21:44 +00:00
James Crook
83c294c844
Bug 2237 - Equalization effects have no Import or Export for curves
...
This is a minimal fix for this bug, and can be improved on in time. There is almost no error checking in the file read and write, so if you use a bad presets file, you won't be told (yet).
It does provide import and export for all effects that have presets.
2020-02-17 11:59:40 +00:00
Paul Licameli
11bbce10b1
a null check and a comment
2020-02-16 13:32:10 -05:00
James Crook
60a113da26
Bug 2318 - Time Toolbar is needlessly resized too large when accommodating longer time formats
...
Tweaks to TimerToolbar.
- When docked, resizer will spring back to right edge when released.
- Now prefers a smaller font, unless bigger is forced.
2020-02-16 11:15:31 +00:00
Paul Licameli
3b9b0eb5f2
Register Wave Color, Spectrogram Settings popup menu items
2020-02-15 15:58:02 -05:00
Paul Licameli
87382d51d8
Demote convenience function that makes computed items to base class
2020-02-15 14:44:17 -05:00
Paul Licameli
4d7a9f00a1
Popup menu table for wave track has member function to get the track
2020-02-15 13:52:41 -05:00
Paul Licameli
cfd07af245
PopupMenuTable supports registration
2020-02-15 13:49:13 -05:00
SteveDaulton
63c7f6b722
Nyquist: Handle nyx_list return value
...
Required to avoid error on running Macoro Scripting commands
from Nyquist.
2020-02-15 15:28:01 +00:00
Paul Licameli
4cfbf07227
Registry passed to Visit can be const
2020-02-14 22:08:35 -05:00
Paul Licameli
46f958f376
Use computed registry items for conditionally shown popup menu items
2020-02-14 21:38:07 -05:00
Leland Lucius
e07b5df6f3
Reworked cmake command options
...
And fixed a recursion problem when copying DLLs to dest folder
The command options are now:
// Enable Audio Unit plug-in support
audacity_enable_audiounits:BOOL=ON
// Library preference [system (if available), local]
audacity_lib_preference:STRING=system
// Use FileDialog library [local]
audacity_use_FileDialog:STRING=local
// Use expat library [local]
audacity_use_expat:STRING=local
// Use ffmpeg library [loaded, off]
audacity_use_ffmpeg:STRING=off
// Use flac library [system (if available), local, off]
audacity_use_flac:STRING=local
// Use id3tag library [system (if available), local, off]
audacity_use_id3tag:STRING=local
// Use LADSPA plug-in support [on, off]
audacity_use_ladspa:BOOL=ON
// Use lame library [system (if available), local]
audacity_use_lame:STRING=local
// Use libextra library [local]
audacity_use_libextra:STRING=local
// Use lv2 library [system (if available), local, off]
audacity_use_lv2:STRING=local
// Use mad library [system (if available), local, off]
audacity_use_mad:STRING=local
// Use midi library [system (if available), local, off]
audacity_use_midi:STRING=local
// Use nyquist library [local, off]
audacity_use_nyquist:STRING=local
// Use ogg library [system (if available), local, off]
audacity_use_ogg:STRING=local
// Use the portaudio CoreAudio interface if available
audacity_use_pa_coreaudio:BOOL=YES
// Use the JACK audio interface if available [loaded, linked, off]
audacity_use_pa_jack:STRING=off
// Use the OSS audio interface if available
audacity_use_pa_oss:BOOL=NO
// Use portaudio library [local]
audacity_use_portaudio:STRING=local
// Use portmixer library [local, off]
audacity_use_portmixer:STRING=local
// Use portsmf library [system (if available), local, off]
audacity_use_portsmf:STRING=local
// Use sbsms library [system (if available), local, off]
audacity_use_sbsms:STRING=local
// Use sndfile library [system (if available), local]
audacity_use_sndfile:STRING=local
// Use soundtouch library [system (if available), local, off]
audacity_use_soundtouch:STRING=local
// Use soxr library [system (if available), local]
audacity_use_soxr:STRING=local
// Use twolame library [system (if available), local, off]
audacity_use_twolame:STRING=local
// Use vamp library [system (if available), local, off]
audacity_use_vamp:STRING=local
// Use vorbis library [system (if available), local, off]
audacity_use_vorbis:STRING=local
// Use VST2 plug-in support [on, off]
audacity_use_vst:BOOL=ON
// Use wxwidgets library [system (if available), local]
audacity_use_wxwidgets:STRING=system
2020-02-14 15:56:33 -06:00
Paul Licameli
5501ac0fc2
Move defs of menu items for changing tools, to be with the toolbar
2020-02-14 14:55:39 -05:00
Paul Licameli
d0a99d5ae5
Each toolbar registers its menu item
2020-02-14 14:51:11 -05:00
Paul Licameli
4bbf8bfb6a
ToolDock does not depend directly on ToolManager
2020-02-14 12:55:12 -05:00
Paul Licameli
ab4751d092
Remove some unused things
2020-02-14 09:43:55 -05:00
James Crook
f7c230319e
Bug 2317 - Scripting: "GetInfo: Commands" omits commands without parameters
2020-02-14 13:37:13 +00:00
James Crook
de2459d98a
Allow slightly smaller font to fix an edge case.
...
With the minimum size of 21, it was still possible to hide the drop-down.
2020-02-14 13:06:25 +00:00
James Crook
b837d49b6b
Improve positioning of dock-drop indicator
...
The triangle showing where in the dock a toolbar will drop now takes into account that overly tall toolbars will be resized to 2 tbs once they are docked.
2020-02-14 12:46:43 +00:00
James Crook
9985b8a9b8
Fix Big Time TimerToolBar, Stage III
...
Fixed issue where format selector could disappear.
Fixed upgrade from 2.3.3.
Remembers time format.
2020-02-14 12:02:21 +00:00
Leland Lucius
709f2f91da
Make it build on 64-bit AND 32-bit
2020-02-12 13:28:16 -06:00