Compute default WaveTrack height analogously to NoteTrack...
Default MIDI track height is enough to display velocity slider...
Make gain slider again visible in default sized WaveTrack
EXPERIMENTAL_MIDI_OUT off -- then no invisible channel buttons...
... using rect.width instead; and making no changes in appearance.
Some routines, like that for the sync lock icon, are pleasingly simplified.
But see comments about some questionable things that may have been based
on the misunderstanding that kTrackInfoWidth was the width between bounding
lines, when in fact, that width was 5 less.
Change some names in TrackArtist to match terminology in TrackPanel
Exclude left, top, bottom margins from rectangles describing TCP
Exclude bottom margin from vruler rectangle reported from FindCell...
Fix a confusion in argument names. No change in behavior
Explanatory comments in TrackPanel drawing; fewer magic numbers
... Rearrange drag is now simply the default of all other hit tests.
The comment, as to the purpose of the removed call to TrackSelFunc, is
obsolete, because clicks on hidden buttons and sliders have recently been
disabled.
The mention of "the area left of the minimize button" is obsolete because there
is no such area any more after 2.2.0 layout changes.
Just before this commit, click in the minimize button but near the left edge
did not minimize, but started a track rearrange drag! That should not be so.
Also fewer magic numbers in TrackPanel drawing code.
* TrackControls:
Shift TCP status text down two pixels, leaving other controls unmoved
Remove argument of DrawOutside that is no longer used...
Don't overlap WaveTrack status and title bar by one pixel...
Fix NoteTrack stray lines; no magic numbers in DrawBordersWithin...
Hidden buttons and sliders in narrow tracks are never clickable
Placement of minimize button and sync-lock icon are also table driven
Don't overlap MIDI channel buttons with menu button & slider...
CalcItemY is table-driven; stack Mute & Solo for NoteTrack too in DA
Now includes 2 'outlier' analysis effects, and has simpler code.
The tricky capture cases are now first in the list.
Vocorder and Chirp are now included. Comma was missing between them.
Now gives error report for an unknown command.
... Formerly it was outside of the yellow focus at the right side. Now it
follows the yellow consistently on four sides.
The constant dx in TrackPanelAx::GetLocation might be adjusted.
No change of behavior is intended at other uses of FindTrackRect
Only available if you define EXPERIMENTAL_DOCS_AUTOMATION.
This code is still a bit ropey and not suited for prime time, but fine for our own (careful) use in preparing the manual.
It captures most of the effects, generator and analyze built ins and nyquist dialogs. Use it by creating a track, making a selection and then clicking the 'All Effects' button in the screenshot tools. The dialogs will be captured to your user directory.
Somewhere along the line, GetEffectIdentifier got changed to GetEffectByIdentifier, leading to abuse of an iterator when attempting to invoke an effect by name.
The layout of SelectionToolbar and SpectralSelction Tollbar now match, and they can be placed nicely side by side.
The borders around controls have been tweaked.
Extra vertical spacer lines have been added into the title row.
I've deliberately not given the choice a title, and deliberately put the word 'selection' at the end, so as to be better/faster for Screen Reader users.
The look of Selection Toolbar and Spectral Selection Toolbar is now consistent. In dark themes both could have better looking choice boxes.
