1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-19 07:01:25 +01:00
Commit Graph

38 Commits

Author SHA1 Message Date
Paul Licameli
668714942b ToolBar::MakeButton is public and static 2016-05-28 22:55:15 -04:00
Paul Licameli
9ab0e42f29 Control scrub with motion, click, drag, wheel almost anywhere in main window...
... if the event is not handled and skipped by sub-windows first, such as for
toolbar button clicks.

(But track panel clicks are skipped even after doing something, so they may
also cause seeking besides other responses.  So click can seek AND set cursor.)

This is meant to make drag to seek and wheel for change of speed easier,
without needing to keep the mouse in the narrow time ruler.

Also lets you click in the ruler, then move in any direction, and not miss the
motion event that should start the scrub playback.

The event handling is a bit of a hack, using propagation.  It does not use
capture.
2016-04-26 12:12:06 -04:00
Paul Licameli
d34715d6ad Various other drags could crash Mac debug build if you option-W. Fixed too...
... And I think this fix is now exhaustive.
2016-04-25 01:49:54 -04:00
Paul Licameli
42bdc274dd Resizing of meter toolbars (docked or undocked) responds to ESC key 2016-04-24 01:01:44 -04:00
Paul Licameli
c78e91f6c1 Image manipulation functions return smart pointers 2016-04-06 16:06:34 -04:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
1c07741d57 Sizers are owned by wxWindow objects when added, so use safenew, or...
... use unique_ptr in the interim between building them and adding.

This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli
4d78e353c3 Revert "sizers"
This reverts commit 84c0a0b666.
2016-02-18 14:50:52 -05:00
Paul Licameli
84c0a0b666 sizers 2016-02-18 02:54:50 -05:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
daa7617e88 auto_ptr (deprecated) -> unique_ptr (preferred in C++11) 2016-02-13 12:00:28 -05:00
Leland Lucius
1e195ecea6 Fix many wx3.1.0 assertions now to prevent double testing 2015-07-30 02:05:23 -05:00
lllucius
0c00a5f463 SetCursor() is only needed once
Thanks to a discussion with Steve, I went back to the docs
and found that SetCursor() is persistent.  So it doesn't
have to be done in a mouse event handler.  The constructor
is perfectly sufficient.
2015-01-02 14:58:22 +00:00
lllucius
15ac9905ad Do not allow resizer to accept focus. 2015-01-02 14:39:56 +00:00
lllucius
6a3ef5565c Independent meters with combined menu/icon
Many other changes including:

1)  Independent preferences
2)  Automatic layout separated from vertical/horizontal orientation choices 
3)  Combined menu and icon which saves space
4)  Click to start monitoring label no longer covers peak hold line completely
5)  Click to start monitoring label now adjusts label based on available width
6)  Click to start monitoring label now appears on vertical meter (not sure about this one...)
7)  Reduced width of vertical meter by moving icon to left of meters
8)  Includes a compact vertical meter now
9)  Clipping indicator is easier to see
10) All 1-off drawing issues resolved (99.9% sure...I challenge you to find some ;-))
11) Bevels around meters are no longer overlaid by meter updates
12) "Old" menu handling code removed
13) Though not perfect since some non-English characters are taller/wider than the meters, non-English text is now handled better
14) Clicking play meter resets indicators as appropriate
15) Indicators on meters now stick around until the meter is clicked
16) Ugly flashing while resizing is now gone
17) There should be NO magic numbers in the code.  Every +1 or -2 is explained in comments...
18) Size of L/R labels are recalculated now when preferences are updated (to pull in locale changes)
2014-12-28 03:18:00 +00:00
lllucius
49b332ebd3 Fix for very strange toolbar setup after removing audacity.cfg 2014-12-18 06:33:44 +00:00
lllucius
fe42e881a5 First stab at taming the meter toolbars
This should correct at least a couple of the reported
issues.  And it also has some fixes in for multiple
project support.
2014-12-17 19:16:08 +00:00
lllucius@gmail.com
012debf65a Fix crash when opening Screenshot Tools 2014-12-13 21:52:31 +00:00
lllucius
f7837eea1b Remove debug logging 2014-12-13 03:14:33 +00:00
lllucius
2f177032ed Fix the weird mouse pointer behavior over toolbar resizers
I couldn't handle it anymore.  The darn pointer would seemingly
switch to left/right arrows whenever it felt like it...and stay
that way.

Actually, it was when it passed over the toolbar resizer when
docked.  The problem was that it wouldn't change back to a normal
pointer because it didn't have the events it needed to do that.

So, I moved the resizer logic into it's own window and now the
pointer changes like it should.

As a bonus, we get a tooltip so the user will know what to do
when the pointer changes as it passes over the resizer.
2014-12-11 08:05:11 +00:00
james.k.crook@gmail.com
7324997db6 Fix for http://bugzilla.audacityteam.org/show_bug.cgi?id=643 "Residual consistency issues with SHIFT showing Loop Play button icon" by Paul Licameli.
* Loop play-at-speed and cut preview play-at-speed implemented.
* Shift or ctrl down now affect all relevant buttons, loop or cut preview, normal or at speed, and append-record.
2014-11-29 17:22:05 +00:00
james.k.crook@gmail.com
7ee3c47441 Added Space-Saver meters. These are now the default.
Fixed ResetToolbars so that SpectralSelectionBar is not shown after a reset.
2014-11-09 15:47:09 +00:00
james.k.crook@gmail.com
7a60ed4309 Meter tooltip text changes. 2014-11-02 18:02:09 +00:00
james.k.crook@gmail.com
c26917a0ee Fix to toolbar positioning.
1) No longer have toolbars appearing at top-left of screen.
2) If using an old config, we won't have combined, play and record meter bars all at the same time anymore.
2014-10-25 13:53:25 +00:00
james.k.crook@gmail.com
fbbab2ce1b Now have three varieties of the Meter Toolbar.
We have separate record and play meters.  The original kind of meter is now called a combined meter.  I've kept it because it can be useful when undocked if you do want both meters.  I've also fixed it so that if made very narrow the meters stack vertically just as they already did horizontally.
2014-10-24 16:42:46 +00:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
martynshaw99
4ce2643d5f Remove the
// Indentation settings for Vim and Emacs
etc. lines from all files, as Campbell's patch (except for other changes to Languages.cpp)
2013-09-24 00:14:37 +00:00
james.k.crook@gmail.com
dba81b3f1c Cleanup: Fixed lots of trivial MSVC warnings. 2013-08-25 21:51:26 +00:00
james.k.crook@gmail.com
860e19ae47 Fix Bug 432: Cleanspeech mode will now not activate, even if it was enabled in a previous version (and even if it has been deliberately added to audacity.cfg). 2012-03-25 20:22:10 +00:00
james.k.crook@gmail.com
69476e785c Fixed more internationalisation hints. 2012-03-20 15:36:02 +00:00
mchinen
fff977b942 ToolBar.cpp: remove excessive drawing on reset (as well as other resizing/positioning functions.)
Was causing an issue with the DeviceToolBar (discussed in bug 11,) but this change will speed up redraw of other toolbars as well.
2011-02-05 14:16:44 +00:00
mchinen
4511331f88 bug 11 followup: let DeviceToolBar be resize smaller than intial width 2011-01-29 16:06:40 +00:00
mchinen
48899f983d DeviceToolBar.cpp: improve resizing, refactor common elements.
Also change minimum width to accommodate 600px wide screens
2011-01-23 16:25:17 +00:00
mchinen
f4f4bccbbb bug 11 follow up: Fix initial width setting on windows (was working with mac/linux) 2011-01-23 13:32:49 +00:00
mchinen
0d1e121aa4 Bug 11 followup: DeviceToolBar - fix initial size conditions when audacity.cfg is not present 2011-01-23 03:53:57 +00:00
BusinessmanProgrammerSteve
2499082baa Update Sync-Lock icons on toolbar, TrackInfo; add the ability to have
a different foreground icon when a toolbar button is pressed (which
will likely be used soon for the Sync-Lock icon).
2010-10-27 04:36:26 +00:00
james.k.crook
4d5c10a690 Patch from Ed Musgrove to allow narrower meter bar, plus also actions from code-review. 2010-02-06 16:12:56 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00