Paul Licameli
d2717cac21
Move functions from AudacityProject to SelectActions
2019-05-20 21:38:09 -04:00
Paul Licameli
e227d4dfb1
Remove some unnecessary declarations in class AudacityProject
2019-05-20 21:38:07 -04:00
Paul Licameli
f86403378b
Move AudacityMessageBox to its own files...
...
... breaking cycles among low-level files introduced by 273ba9f
2019-05-20 14:48:36 -04:00
Paul Licameli
96ffc424cf
PluginManager.cpp does not depend on EffectManager.cpp...
...
... Taking PluginManager.cpp and ModuleManager.cpp out of other dependency
cycles, though still in a small cycle with each other
2019-05-18 20:32:19 -04:00
Paul Licameli
519a988467
RecordingPrefs.cpp does not depend on AudioIO.cpp...
...
... freeing it from dependency cycles, but no others
2019-05-18 20:29:25 -04:00
Paul Licameli
d68db39b5c
HelpSystem.cpp has fewer dependencies...
...
... There was no reason to store the help location preferences as per-project
state. Also move the dialog for quick fixes near its only use in
HelpMenus.cpp.
This takes 22 files out of the big strongly connected component, notably
the much used lower level utilities, ErrorDialog and AudacityException.
HelpSystem itself is still in a small cycle with LinkingHtmlWindow.
2019-05-18 20:29:25 -04:00
Paul Licameli
56b1d531b2
HelpText.cpp has fewer dependencies...
...
... freeing it to a low level and AboutDialog.cpp to a high level, by moving
functions from the latter into the former
2019-05-18 20:29:25 -04:00
Paul Licameli
b04387a21d
Move AudacityApp::GenerateCrashReport to its own files
2019-05-17 16:29:31 -04:00
Paul Licameli
8da6529329
Remove AudacityApp::GetLogger() & HelpActions::DoShowLog()
2019-05-17 16:29:04 -04:00
Paul Licameli
e845bd9544
Move AudacityApp::MacActivateApp out of WindowMenus.cpp
2019-05-17 16:29:04 -04:00
Paul Licameli
e4a8d6c3fc
Don't call AudacityApp::OnMenuAbout directly from HelpMenus.cpp
2019-05-17 16:29:04 -04:00
Paul Licameli
6cde697a8e
Don't call QuitAudacity directly from src/menus...
...
... This cuts link dependency on AudacityApp.cpp, and allows the function to
be private to that file
2019-05-17 16:29:04 -04:00
Paul Licameli
a047fa6e7a
Missing alias file tracking out of AudacityApp, into new files...
...
... which reduces the need for including AudacityApp.h
2019-05-17 16:28:50 -04:00
Paul Licameli
0ab29d21e9
Some naming consistency...
...
Prefer "MissingAliasFiles" not other permutations of the words
2019-05-17 06:47:53 -04:00
Paul Licameli
2d8c287384
Do not require AudacityApp.h when using global file history
2019-05-17 06:47:53 -04:00
Paul Licameli
338d7cd164
A class encapsulating the global clipboard
2019-05-17 06:47:53 -04:00
Paul Licameli
6c57948d8f
Remove unnecessary #include-s from .cpp files...
...
... Unnecessary because transitively included.
But each .cpp file still includes its own .h file near the top to ensure
that it compiles indenendently, even if it is reincluded transitively later.
2019-05-16 17:21:00 -04:00
Paul Licameli
9bf29f5582
CommandManager keys by CommandId, not plain wxString
2019-05-16 12:30:29 -04:00
Paul Licameli
c46fbd919c
rename function as AudacityProject::GetProjectName...
...
... So it does not hide inherited wxWindow::GetName().
And make it const.
2019-04-26 14:10:05 -04:00
Paul Licameli
544d9aa580
Don't use AudacityApp where you only need wxApp...
...
... I want to have fewer inclusions of AudacityApp.h. More work on removing
them will happen in the next version.
2019-04-26 11:54:28 -04:00
Paul Licameli
2af46016c7
Move a comma past a comment, fixes junk in extracted audacity.pot
2019-04-23 13:30:23 -04:00
James Crook
f66e753c54
Add option in metadata editor to not show it again
...
Also added help button to it
Also fixed Bug 2038 - Metadata editor opens without grid focus
2019-04-12 20:18:17 +01:00
James Crook
f4aa75f4fc
Make TypeToCreateLabel off by default.
...
Following a lengthen discussion on the quality list, consensus is this option
should always have been off by default. The main argument for not changing
it now was that 'on' is what users have come to expect.
2019-04-12 17:33:31 +01:00
Paul Licameli
617c1d8785
Make default value of /Effects/GroupBy match the dialog choice
2019-04-04 17:42:01 -04:00
Paul Licameli
0b733eed3f
Remove (or comment) ProgressDialog.h in headers...
...
... For ImportPlugin, use unique_ptr not Maybe to hold it, and take constructors
out-of-line.
2019-04-04 09:47:57 -04:00
James Crook
0c4f611b5c
Unselect tracks before auto-selecting audio
2019-03-31 20:46:07 +01:00
Paul Licameli
44d664c7bb
Remove ErrorDialog.h from .h files (one function moves out of line)
2019-03-31 15:39:55 -04:00
Paul Licameli
2d8abe6b74
Remove FileHistory.h, KeyView.h from .h files
2019-03-31 15:21:02 -04:00
Paul Licameli
e2c5444c1d
Move class HtmlTextHelpDialog out of header
2019-03-31 14:58:33 -04:00
Paul Licameli
48b184f072
Remove an unnecessary nested #include
2019-03-31 13:27:18 -04:00
Paul Licameli
03101d1d75
Briefer track iteration idiom avoids casting
2019-03-30 09:49:17 -04:00
James Crook
939bbc95a2
Don't count note tracks (MIDI) as audio in auto-select.
2019-03-30 11:42:29 +00:00
James Crook
09dab612fe
Change AutoSelect to only select Audio.
2019-03-29 22:12:00 +00:00
Paul Licameli
010d720158
Make EXPERIMENTAL_EFFECTS_RACK compilable
2019-03-28 11:12:12 -04:00
Paul Licameli
cfde442bcd
Remove a few small member functions from AudacityProject
2019-03-27 13:32:54 -04:00
Paul Licameli
69962f62d3
Remove AudacityProject::GetScreenEndTime
2019-03-27 13:32:54 -04:00
Paul Licameli
ca5bb78abe
Remove AudacityProject::GetSelection
2019-03-27 13:32:54 -04:00
Paul Licameli
0dd0a5cb5a
Remove <wx/menu.h> from CommandManager.h, moving inline functions out
2019-03-23 10:56:43 -04:00
Paul Licameli
6cea6306b7
Factor common part of help diagnostic commands...
...
... minor changes in dialog titles
(capitalization; "Save Device Info" -> "Save Audio Device Info" )
2019-03-22 14:25:50 -04:00
Paul Licameli
86dfcab6b3
Make EXPERIMENTAL_AUTOMATED_INPUT_LEVEL_ADJUSTMENT compilable
2019-03-22 12:38:54 -04:00
Paul Licameli
adcb93512c
Include Audacity.h in all files that test config USE_ macros...
...
... except Experimental.h, but see preceding commit.
This is especially important in the header files.
Be sure there are no quiet changes of meaning when a header file is included
in a different context, not having seen Audacity.h. Rather include Audacity.h
even if redundantly.
Also, in some header files, move more inside the include-guard #ifdef-#endif
pair.
2019-03-22 12:36:54 -04:00
Paul Licameli
7cd6664f7b
Require Audacity.h before Experimental.h...
...
... so that USE_* macros will be seen first, and so
EXPERIMENTAL_AUTOMATED_INPUT_LEVEL_ADJUSTMENT, for one, is correctly defined.
I hesitated actually to include Audacity.h in Experimental.h. Maybe no
need for that hesitancy. But instead I use #error if Audacity.h has not been
seen yet.
2019-03-22 11:25:30 -04:00
Paul Licameli
b4ce681867
WaveTrack.h does not include WaveClip.h
2019-03-18 01:44:42 -04:00
Paul Licameli
906e55f047
Experimental.h in all .h or .cpp files that directly use EXPERIMENTALs...
...
... except Audacity.h; and in no others.
Do so even if Experimental.h gets multiply included, as in both the .h and
.cpp files.
This makes it easier to do a text scan to be sure there are no unintended quiet
changes of meaning because of omission of Experimental.h when the flag is
an enabled one.
Also move inclusions of Experimental.h earlier.
Also don't require Experimental.h to be preceded by Audacity.h to define
EXPERIMENTAL_MIDI_OUT correctly.
2019-03-17 22:54:00 -04:00
Paul Licameli
173a300427
Include nothing before Audacity.h, as comments say we should...
...
... and remove some duplicated inclusions
2019-03-17 21:41:39 -04:00
Henric Jungheim
61291257eb
Fix "assocated" -> "associated" typo.
2019-03-17 18:06:15 -07:00
Paul Licameli
71036bed01
Remove PluginManager.h from other headers
2019-03-17 15:05:19 -04:00
Paul Licameli
41175e94cd
Simplify by removing many std::move of shared_ptr to tracks...
...
... Don't need them, as we did with std::unique_ptr
2019-03-16 13:11:33 -04:00
Paul Licameli
a0aa69a248
All tracks allocated with make_shared, no more make_unique...
...
... so that we can use Track::SharedPointer without undefined behavior even on
tracks that don't yet belong to any TrackList.
Also fix the return type of function template TrackList::Add and remove some
casts.
2019-03-16 13:11:33 -04:00
Paul Licameli
1bcb7c20a5
Remove some nested #include from Project.h
2019-03-16 13:09:54 -04:00